From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org
Cc: Amit Shah <amit.shah@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Wed, 30 May 2012 19:41:47 +0930 [thread overview]
Message-ID: <87r4u2dllo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120528125325.GA22576@redhat.com>
On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote:
> > disable_cb is just an optimization: it
> > can not guarantee that there are no callbacks.
> >
> > I didn't yet figure out whether a callback
> > in freeze will trigger a bug, but disable_cb
> > won't address it in any case. So let's remove
> > the useless calls as a first step.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Looks like this isn't in the 3.5 pull request -
> just lost in the shuffle?
> disable_cb is advisory so can't be relied upon.
I always (try to?) reply as I accept patches.
This one did slip by, but it's harmless so no need to push AFAICT.
Applied.
Thanks!
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Amit Shah <amit.shah@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Wed, 30 May 2012 19:41:47 +0930 [thread overview]
Message-ID: <87r4u2dllo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120528125325.GA22576@redhat.com>
On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote:
> > disable_cb is just an optimization: it
> > can not guarantee that there are no callbacks.
> >
> > I didn't yet figure out whether a callback
> > in freeze will trigger a bug, but disable_cb
> > won't address it in any case. So let's remove
> > the useless calls as a first step.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Looks like this isn't in the 3.5 pull request -
> just lost in the shuffle?
> disable_cb is advisory so can't be relied upon.
I always (try to?) reply as I accept patches.
This one did slip by, but it's harmless so no need to push AFAICT.
Applied.
Thanks!
Rusty.
next prev parent reply other threads:[~2012-05-30 10:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 9:19 [PATCH RFC] virtio-net: remove useless disable on freeze Michael S. Tsirkin
2012-04-04 9:19 ` Michael S. Tsirkin
2012-05-03 10:59 ` Amit Shah
2012-05-03 10:59 ` Amit Shah
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-30 10:11 ` Rusty Russell [this message]
2012-05-30 10:11 ` Rusty Russell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4u2dllo.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.