From: Marek Vasut <marex@denx.de>
To: Huang Shijie <b32955@freescale.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH 1/4] GPMI-NAND: Define ecc.strength
Date: Mon, 21 May 2012 05:48:00 +0200 [thread overview]
Message-ID: <201205210548.00536.marex@denx.de> (raw)
In-Reply-To: <4FB9B19B.2080309@freescale.com>
Dear Huang Shijie,
> 于 2012年05月21日 10:40, Marek Vasut 写道:
> > I doubt so ... but noone ever could test it without DT bindings as you
> > NAKed/stalled every single attempt to add the platform binding code. So
> > this code was rotting in the tree, who knows how many bugs are still in
> > it. Now I guess it's about time to start squashing the bugs.
>
> I checked the latest l2-mtd code. The bug does exit if the gpmi-nand
> driver can works(actually it can not).
There's also the bug where you need to put gpmi@8000c000 into the DTS file
instead of gpmi-nand@8000c000 ... maybe you should fix it?
Also, there's still the bug with subpage write size, "GPMI-NAND: Wrong ECC size
in driver" thread in linux-mtd. That thread kind of died, but gpmi-nand is still
broken in that way, it's depending on loose end of the mtd stack there. Won't
hurt fixing that too, there was even a fix proposed.
>
> I will test your patch.
> Anyway, this patch should be sent to Artem, not the arm-soc.
Resent, fixed, sorry for the inconvenience.
>
> thanks
> Huang Shijie
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] GPMI-NAND: Define ecc.strength
Date: Mon, 21 May 2012 05:48:00 +0200 [thread overview]
Message-ID: <201205210548.00536.marex@denx.de> (raw)
In-Reply-To: <4FB9B19B.2080309@freescale.com>
Dear Huang Shijie,
> ? 2012?05?21? 10:40, Marek Vasut ??:
> > I doubt so ... but noone ever could test it without DT bindings as you
> > NAKed/stalled every single attempt to add the platform binding code. So
> > this code was rotting in the tree, who knows how many bugs are still in
> > it. Now I guess it's about time to start squashing the bugs.
>
> I checked the latest l2-mtd code. The bug does exit if the gpmi-nand
> driver can works(actually it can not).
There's also the bug where you need to put gpmi at 8000c000 into the DTS file
instead of gpmi-nand at 8000c000 ... maybe you should fix it?
Also, there's still the bug with subpage write size, "GPMI-NAND: Wrong ECC size
in driver" thread in linux-mtd. That thread kind of died, but gpmi-nand is still
broken in that way, it's depending on loose end of the mtd stack there. Won't
hurt fixing that too, there was even a fix proposed.
>
> I will test your patch.
> Anyway, this patch should be sent to Artem, not the arm-soc.
Resent, fixed, sorry for the inconvenience.
>
> thanks
> Huang Shijie
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-21 3:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 1:02 [PATCH 1/4] GPMI-NAND: Define ecc.strength Marek Vasut
2012-05-21 1:02 ` [PATCH 2/4] GPMI-NAND: Fixup compile issue Marek Vasut
2012-05-21 1:16 ` Shawn Guo
2012-05-21 1:02 ` [PATCH 3/4] MXS-MMC: Move of_match_table out of CONFIG_PM Marek Vasut
2012-05-21 4:09 ` Shawn Guo
2012-05-21 4:09 ` Shawn Guo
2012-05-21 3:52 ` Chris Ball
2012-05-21 3:52 ` Chris Ball
2012-05-21 4:33 ` Marek Vasut
2012-05-21 4:33 ` Marek Vasut
2012-05-21 1:02 ` [PATCH 4/4] MXS-MMC: Add wp-inverted property Marek Vasut
2012-05-21 1:39 ` Shawn Guo
2012-05-21 1:39 ` Shawn Guo
2012-05-21 2:38 ` Marek Vasut
2012-05-21 2:38 ` Marek Vasut
2012-05-21 2:48 ` Shawn Guo
2012-05-21 2:48 ` Shawn Guo
2012-05-21 3:22 ` Chris Ball
2012-05-21 3:22 ` Chris Ball
2012-05-21 3:36 ` Marek Vasut
2012-05-21 3:36 ` Marek Vasut
2012-05-21 7:22 ` Lothar Waßmann
2012-05-21 17:38 ` Marek Vasut
2012-05-21 1:14 ` [PATCH 1/4] GPMI-NAND: Define ecc.strength Shawn Guo
2012-05-21 1:14 ` Shawn Guo
2012-05-21 1:36 ` Marek Vasut
2012-05-21 1:36 ` Marek Vasut
2012-05-21 1:41 ` Shawn Guo
2012-05-21 1:41 ` Shawn Guo
2012-05-21 2:40 ` Marek Vasut
2012-05-21 2:40 ` Marek Vasut
2012-05-21 3:08 ` Huang Shijie
2012-05-21 3:08 ` Huang Shijie
2012-05-21 3:48 ` Marek Vasut [this message]
2012-05-21 3:48 ` Marek Vasut
2012-05-21 3:45 ` Shawn Guo
2012-05-21 3:45 ` Shawn Guo
2012-05-21 3:39 ` Marek Vasut
2012-05-21 3:39 ` Marek Vasut
2012-05-21 2:44 ` Huang Shijie
2012-05-21 2:44 ` Huang Shijie
2012-05-21 3:43 ` Marek Vasut
2012-05-21 3:43 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205210548.00536.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.