[PATCH] Staging: ipack: remove pr_fmt definition.

[PATCH] Staging: ipack: remove pr_fmt definition.

[Samuel Iglesias Gonsalvez]

As there is no pr_* function used here, pr_fmt is not needed.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
---
 drivers/staging/ipack/ipack.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c
index a1448e6..c1cd97a 100644
--- a/drivers/staging/ipack/ipack.c
+++ b/drivers/staging/ipack/ipack.c
@@ -9,8 +9,6 @@
  * Software Foundation; version 2 of the License.
  */
 
-#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/idr.h>
-- 
1.7.10

Re: [PATCH] Staging: ipack: remove pr_fmt definition.

[Dan Carpenter]

On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> As there is no pr_* function used here, pr_fmt is not needed.
> 

Nah.  What about if we decide to add some?  Also there are actually
a couple pr_err() calls in there already.

regards,
dan carpenter

Re: [PATCH] Staging: ipack: remove pr_fmt definition.

[Dan Carpenter]

On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > As there is no pr_* function used here, pr_fmt is not needed.
> > 
> 
> Nah.  What about if we decide to add some?  Also there are actually
> a couple pr_err() calls in there already.

Oops.  Sorry my tree is old.  We removed the two calls to pr_err().

regards,
dan carpenter

Re: [PATCH] Staging: ipack: remove pr_fmt definition.

[Samuel Iglesias Gonsálvez]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

On Mon, 2012-06-11 at 10:25 +0300, Dan Carpenter wrote:
> On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > As there is no pr_* function used here, pr_fmt is not needed.
> > 
> 
> Nah.  What about if we decide to add some?  Also there are actually
> a couple pr_err() calls in there already.

Oops, you are right! Forget this patch!

Thanks,

Sam


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] Staging: ipack: remove pr_fmt definition.

[Samuel Iglesias Gonsálvez]

On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote:
> On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > > As there is no pr_* function used here, pr_fmt is not needed.
> > > 
> > 
> > Nah.  What about if we decide to add some?  Also there are actually
> > a couple pr_err() calls in there already.
> 
> Oops.  Sorry my tree is old.  We removed the two calls to pr_err().

Same mistake here. In greg's staging-next the pr_err calls are not
present so the patch is totally valid but in linus branch they are there
(this is the reason of my error).

So, this patch is valid, unless we want the pr_fmt definition for the
future. However, I prefer to delete it.

Cheers,

Sam

Re: [PATCH] Staging: ipack: remove pr_fmt definition.

[Dan Carpenter]

On Mon, Jun 11, 2012 at 09:40:04AM +0200, Samuel Iglesias Gonsálvez wrote:
> On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote:
> > On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> > > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > > > As there is no pr_* function used here, pr_fmt is not needed.
> > > > 
> > > 
> > > Nah.  What about if we decide to add some?  Also there are actually
> > > a couple pr_err() calls in there already.
> > 
> > Oops.  Sorry my tree is old.  We removed the two calls to pr_err().
> 
> Same mistake here. In greg's staging-next the pr_err calls are not
> present so the patch is totally valid but in linus branch they are there
> (this is the reason of my error).
> 
> So, this patch is valid, unless we want the pr_fmt definition for the
> future. However, I prefer to delete it.
> 

Sure.  I guess everything in staging/ipack/ uses dev_err() type
print statements and that includes more information than the the
pr_fmt() macro already.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter