* [PATCH] Staging: ipack: remove pr_fmt definition. @ 2012-06-11 6:56 Samuel Iglesias Gonsalvez 2012-06-11 7:25 ` Dan Carpenter 0 siblings, 1 reply; 6+ messages in thread From: Samuel Iglesias Gonsalvez @ 2012-06-11 6:56 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Samuel Iglesias Gonsalvez, devel, linux-kernel As there is no pr_* function used here, pr_fmt is not needed. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> --- drivers/staging/ipack/ipack.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c index a1448e6..c1cd97a 100644 --- a/drivers/staging/ipack/ipack.c +++ b/drivers/staging/ipack/ipack.c @@ -9,8 +9,6 @@ * Software Foundation; version 2 of the License. */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/module.h> #include <linux/slab.h> #include <linux/idr.h> -- 1.7.10 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: ipack: remove pr_fmt definition. 2012-06-11 6:56 [PATCH] Staging: ipack: remove pr_fmt definition Samuel Iglesias Gonsalvez @ 2012-06-11 7:25 ` Dan Carpenter 2012-06-11 7:27 ` Dan Carpenter 2012-06-11 7:29 ` Samuel Iglesias Gonsálvez 0 siblings, 2 replies; 6+ messages in thread From: Dan Carpenter @ 2012-06-11 7:25 UTC (permalink / raw) To: Samuel Iglesias Gonsalvez; +Cc: Greg Kroah-Hartman, devel, linux-kernel On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote: > As there is no pr_* function used here, pr_fmt is not needed. > Nah. What about if we decide to add some? Also there are actually a couple pr_err() calls in there already. regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: ipack: remove pr_fmt definition. 2012-06-11 7:25 ` Dan Carpenter @ 2012-06-11 7:27 ` Dan Carpenter 2012-06-11 7:40 ` Samuel Iglesias Gonsálvez 2012-06-11 7:29 ` Samuel Iglesias Gonsálvez 1 sibling, 1 reply; 6+ messages in thread From: Dan Carpenter @ 2012-06-11 7:27 UTC (permalink / raw) To: Samuel Iglesias Gonsalvez; +Cc: Greg Kroah-Hartman, devel, linux-kernel On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote: > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote: > > As there is no pr_* function used here, pr_fmt is not needed. > > > > Nah. What about if we decide to add some? Also there are actually > a couple pr_err() calls in there already. Oops. Sorry my tree is old. We removed the two calls to pr_err(). regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: ipack: remove pr_fmt definition. 2012-06-11 7:27 ` Dan Carpenter @ 2012-06-11 7:40 ` Samuel Iglesias Gonsálvez 2012-06-11 8:29 ` Dan Carpenter 0 siblings, 1 reply; 6+ messages in thread From: Samuel Iglesias Gonsálvez @ 2012-06-11 7:40 UTC (permalink / raw) To: Dan Carpenter; +Cc: Greg Kroah-Hartman, devel, linux-kernel On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote: > On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote: > > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote: > > > As there is no pr_* function used here, pr_fmt is not needed. > > > > > > > Nah. What about if we decide to add some? Also there are actually > > a couple pr_err() calls in there already. > > Oops. Sorry my tree is old. We removed the two calls to pr_err(). Same mistake here. In greg's staging-next the pr_err calls are not present so the patch is totally valid but in linus branch they are there (this is the reason of my error). So, this patch is valid, unless we want the pr_fmt definition for the future. However, I prefer to delete it. Cheers, Sam ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: ipack: remove pr_fmt definition. 2012-06-11 7:40 ` Samuel Iglesias Gonsálvez @ 2012-06-11 8:29 ` Dan Carpenter 0 siblings, 0 replies; 6+ messages in thread From: Dan Carpenter @ 2012-06-11 8:29 UTC (permalink / raw) To: Samuel Iglesias Gonsálvez; +Cc: devel, Greg Kroah-Hartman, linux-kernel On Mon, Jun 11, 2012 at 09:40:04AM +0200, Samuel Iglesias Gonsálvez wrote: > On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote: > > On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote: > > > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote: > > > > As there is no pr_* function used here, pr_fmt is not needed. > > > > > > > > > > Nah. What about if we decide to add some? Also there are actually > > > a couple pr_err() calls in there already. > > > > Oops. Sorry my tree is old. We removed the two calls to pr_err(). > > Same mistake here. In greg's staging-next the pr_err calls are not > present so the patch is totally valid but in linus branch they are there > (this is the reason of my error). > > So, this patch is valid, unless we want the pr_fmt definition for the > future. However, I prefer to delete it. > Sure. I guess everything in staging/ipack/ uses dev_err() type print statements and that includes more information than the the pr_fmt() macro already. Acked-by: Dan Carpenter <dan.carpenter@oracle.com> regards, dan carpenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: ipack: remove pr_fmt definition. 2012-06-11 7:25 ` Dan Carpenter 2012-06-11 7:27 ` Dan Carpenter @ 2012-06-11 7:29 ` Samuel Iglesias Gonsálvez 1 sibling, 0 replies; 6+ messages in thread From: Samuel Iglesias Gonsálvez @ 2012-06-11 7:29 UTC (permalink / raw) To: Dan Carpenter; +Cc: Greg Kroah-Hartman, devel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 391 bytes --] On Mon, 2012-06-11 at 10:25 +0300, Dan Carpenter wrote: > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote: > > As there is no pr_* function used here, pr_fmt is not needed. > > > > Nah. What about if we decide to add some? Also there are actually > a couple pr_err() calls in there already. Oops, you are right! Forget this patch! Thanks, Sam [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-11 8:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-06-11 6:56 [PATCH] Staging: ipack: remove pr_fmt definition Samuel Iglesias Gonsalvez 2012-06-11 7:25 ` Dan Carpenter 2012-06-11 7:27 ` Dan Carpenter 2012-06-11 7:40 ` Samuel Iglesias Gonsálvez 2012-06-11 8:29 ` Dan Carpenter 2012-06-11 7:29 ` Samuel Iglesias Gonsálvez
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.