From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration
Date: Thu, 5 Jul 2012 14:57:20 +0100 [thread overview]
Message-ID: <20120705135719.GK4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF59C7C.5020406@linaro.org>
On Thu, Jul 05, 2012 at 02:54:04PM +0100, Lee Jones wrote:
> On 05/07/12 14:20, Mark Brown wrote:
[Moving registration to the MFD]
> >But surely this would, if anything, remove code? You already have the
> >code to do the registration in the MFD so all you're going to be doing
> >here is removing the code from
> No, it will add platform code if we were to register the ab8500 from
> the platform area.
Why would this be the case? You've already got registration code in
there for use in DT...
> >Hrm, the usual pattern for this stuff is that the DT is parsed into
> >platform data so the DT code is isolated to the parser. It sounds like
> >you've got a very different structure here?
> Yes we do. Ref that commit ID I sent you you a few days ago:
> 5f3fc8adeec9bb12742fbfa777fa1947deda21a2
This doesn't appear to reference the platform data?
> >Well, it also introduces code into mainline which is likely to be used
> >as a template by other people - I'd be especially worried about the next
> >ST platform ending up repeating the same mistakes.
> There are no mistakes. It would work for other platforms. :)
Working and good idea aren't the same thing!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120705/cb0022f5/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
arnd@arndb.de, sameo@linux.intel.com
Subject: Re: [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration
Date: Thu, 5 Jul 2012 14:57:20 +0100 [thread overview]
Message-ID: <20120705135719.GK4111@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FF59C7C.5020406@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
On Thu, Jul 05, 2012 at 02:54:04PM +0100, Lee Jones wrote:
> On 05/07/12 14:20, Mark Brown wrote:
[Moving registration to the MFD]
> >But surely this would, if anything, remove code? You already have the
> >code to do the registration in the MFD so all you're going to be doing
> >here is removing the code from
> No, it will add platform code if we were to register the ab8500 from
> the platform area.
Why would this be the case? You've already got registration code in
there for use in DT...
> >Hrm, the usual pattern for this stuff is that the DT is parsed into
> >platform data so the DT code is isolated to the parser. It sounds like
> >you've got a very different structure here?
> Yes we do. Ref that commit ID I sent you you a few days ago:
> 5f3fc8adeec9bb12742fbfa777fa1947deda21a2
This doesn't appear to reference the platform data?
> >Well, it also introduces code into mainline which is likely to be used
> >as a template by other people - I'd be especially worried about the next
> >ST platform ending up repeating the same mistakes.
> There are no mistakes. It would work for other platforms. :)
Working and good idea aren't the same thing!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-05 13:57 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 11:59 [PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration Lee Jones
2012-07-03 11:59 ` Lee Jones
2012-07-03 12:35 ` Mark Brown
2012-07-03 12:35 ` Mark Brown
2012-07-03 13:07 ` Lee Jones
2012-07-03 13:07 ` Lee Jones
2012-07-03 13:24 ` Mark Brown
2012-07-03 13:24 ` Mark Brown
2012-07-03 13:48 ` Lee Jones
2012-07-03 13:48 ` Lee Jones
2012-07-03 14:21 ` Mark Brown
2012-07-03 14:21 ` Mark Brown
2012-07-05 7:36 ` Lee Jones
2012-07-05 7:36 ` Lee Jones
2012-07-05 9:45 ` Mark Brown
2012-07-05 9:45 ` Mark Brown
2012-07-05 11:46 ` Lee Jones
2012-07-05 11:46 ` Lee Jones
2012-07-05 12:06 ` Mark Brown
2012-07-05 12:06 ` Mark Brown
2012-07-05 12:15 ` Lee Jones
2012-07-05 12:15 ` Lee Jones
2012-07-05 12:29 ` Mark Brown
2012-07-05 12:29 ` Mark Brown
2012-07-05 12:41 ` Lee Jones
2012-07-05 12:41 ` Lee Jones
2012-07-05 12:45 ` Mark Brown
2012-07-05 12:45 ` Mark Brown
2012-07-05 12:55 ` Lee Jones
2012-07-05 12:55 ` Lee Jones
2012-07-05 13:03 ` Mark Brown
2012-07-05 13:03 ` Mark Brown
2012-07-05 13:12 ` Lee Jones
2012-07-05 13:12 ` Lee Jones
2012-07-05 13:20 ` Mark Brown
2012-07-05 13:20 ` Mark Brown
2012-07-05 13:54 ` Lee Jones
2012-07-05 13:54 ` Lee Jones
2012-07-05 13:57 ` Mark Brown [this message]
2012-07-05 13:57 ` Mark Brown
2012-07-05 14:06 ` Samuel Ortiz
2012-07-05 14:06 ` Samuel Ortiz
2012-07-05 13:57 ` Arnd Bergmann
2012-07-05 13:57 ` Arnd Bergmann
2012-07-05 14:04 ` Mark Brown
2012-07-05 14:04 ` Mark Brown
2012-07-05 14:06 ` Lee Jones
2012-07-05 14:06 ` Lee Jones
2012-07-05 14:13 ` Mark Brown
2012-07-05 14:13 ` Mark Brown
2012-07-05 14:35 ` Lee Jones
2012-07-05 14:35 ` Lee Jones
2012-07-05 15:41 ` Arnd Bergmann
2012-07-05 15:41 ` Arnd Bergmann
2012-07-05 15:51 ` Lee Jones
2012-07-05 15:51 ` Lee Jones
2012-07-03 14:01 ` Arnd Bergmann
2012-07-03 14:01 ` Arnd Bergmann
2012-07-03 14:43 ` Mark Brown
2012-07-03 14:43 ` Mark Brown
2012-07-05 7:33 ` Lee Jones
2012-07-05 7:33 ` Lee Jones
2012-07-05 13:08 ` Fabio Estevam
2012-07-05 13:08 ` Fabio Estevam
2012-07-05 13:13 ` Lee Jones
2012-07-05 13:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705135719.GK4111@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.