From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain
Date: Mon, 6 Aug 2012 11:50:52 +0000 [thread overview]
Message-ID: <201208061150.53076.arnd@arndb.de> (raw)
In-Reply-To: <1344250002-6011-3-git-send-email-lee.jones@linaro.org>
On Monday 06 August 2012, Lee Jones wrote:
>
> +struct irq_domain *db8500_irq_domain;
> +
Should this be static?
> @@ -2583,7 +2585,7 @@ static void prcmu_irq_mask(struct irq_data *d)
>
> spin_lock_irqsave(&mb0_transfer.dbb_irqs_lock, flags);
>
> - mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->irq - IRQ_PRCMU_BASE];
> + mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->hwirq];
>
> spin_unlock_irqrestore(&mb0_transfer.dbb_irqs_lock, flags);
Ah, so the hwirq number *is* used directly here, unlike what I thought
when we first discussed it. I suppose that means we don't need the
xlate function after all (and you did not add one).
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, dmitry.torokhov@gmail.com,
sameo@linux.intel.com
Subject: Re: [PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain
Date: Mon, 6 Aug 2012 11:50:52 +0000 [thread overview]
Message-ID: <201208061150.53076.arnd@arndb.de> (raw)
In-Reply-To: <1344250002-6011-3-git-send-email-lee.jones@linaro.org>
On Monday 06 August 2012, Lee Jones wrote:
>
> +struct irq_domain *db8500_irq_domain;
> +
Should this be static?
> @@ -2583,7 +2585,7 @@ static void prcmu_irq_mask(struct irq_data *d)
>
> spin_lock_irqsave(&mb0_transfer.dbb_irqs_lock, flags);
>
> - mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->irq - IRQ_PRCMU_BASE];
> + mb0_transfer.req.dbb_irqs &= ~prcmu_irq_bit[d->hwirq];
>
> spin_unlock_irqrestore(&mb0_transfer.dbb_irqs_lock, flags);
Ah, so the hwirq number *is* used directly here, unlike what I thought
when we first discussed it. I suppose that means we don't need the
xlate function after all (and you did not add one).
Arnd
next prev parent reply other threads:[~2012-08-06 11:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 10:46 [PATCH 0/6] Device Tree IRQ related enablement patches Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 1/6] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 11:50 ` Arnd Bergmann [this message]
2012-08-06 11:50 ` Arnd Bergmann
2012-08-06 10:46 ` [PATCH 3/6] ARM: ux500: Force AB8500 to use the GIC as its interrupt controller Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 4/6] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 15:54 ` Mark Brown
2012-08-06 15:54 ` Mark Brown
2012-08-06 17:21 ` Lee Jones
2012-08-06 17:21 ` Lee Jones
2012-08-06 10:46 ` [PATCH 5/6] ARM: ux500: Match-up compatible stings with associated MFD cell Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 11:17 ` Linus Walleij
2012-08-06 11:17 ` Linus Walleij
2012-08-06 12:36 ` Lee Jones
2012-08-06 12:36 ` Lee Jones
2012-08-06 16:00 ` Mark Brown
2012-08-06 16:00 ` Mark Brown
2012-08-06 17:22 ` Lee Jones
2012-08-06 17:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208061150.53076.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.