From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Mon, 6 Aug 2012 18:22:05 +0100 [thread overview]
Message-ID: <20120806172204.GB31409@gmail.com> (raw)
In-Reply-To: <20120806160039.GE29272@sirena.org.uk>
On Mon, Aug 06, 2012 at 05:00:39PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2012 at 11:46:42AM +0100, Lee Jones wrote:
> > If we're booting with Device Tree enabled, we want the IRQ numbers to
> > be taken and translated from the Device Tree binary. If not, they
> > should be taken from the resource allocation defined in the AB8500 MFD
> > core driver.
>
> > ponkey->ab8500 = ab8500;
> > - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> > - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
> > +
> > + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf;
> > + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;
>
> Shouldn't the irq domain be coping with this? It seems like a massive
> failure to have to do this in every single user, the irq domain should
> be able to encapsulate all this stuff.
Already in hand.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
arnd@arndb.de, dmitry.torokhov@gmail.com,
STEricsson_nomadik_linux@list.st.com, sameo@linux.intel.com
Subject: Re: [PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Mon, 6 Aug 2012 18:22:05 +0100 [thread overview]
Message-ID: <20120806172204.GB31409@gmail.com> (raw)
In-Reply-To: <20120806160039.GE29272@sirena.org.uk>
On Mon, Aug 06, 2012 at 05:00:39PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2012 at 11:46:42AM +0100, Lee Jones wrote:
> > If we're booting with Device Tree enabled, we want the IRQ numbers to
> > be taken and translated from the Device Tree binary. If not, they
> > should be taken from the resource allocation defined in the AB8500 MFD
> > core driver.
>
> > ponkey->ab8500 = ab8500;
> > - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> > - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
> > +
> > + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf;
> > + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;
>
> Shouldn't the irq domain be coping with this? It seems like a massive
> failure to have to do this in every single user, the irq domain should
> be able to encapsulate all this stuff.
Already in hand.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-08-06 17:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 10:46 [PATCH 0/6] Device Tree IRQ related enablement patches Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 1/6] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 11:50 ` Arnd Bergmann
2012-08-06 11:50 ` Arnd Bergmann
2012-08-06 10:46 ` [PATCH 3/6] ARM: ux500: Force AB8500 to use the GIC as its interrupt controller Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 4/6] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 15:54 ` Mark Brown
2012-08-06 15:54 ` Mark Brown
2012-08-06 17:21 ` Lee Jones
2012-08-06 17:21 ` Lee Jones
2012-08-06 10:46 ` [PATCH 5/6] ARM: ux500: Match-up compatible stings with associated MFD cell Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 11:17 ` Linus Walleij
2012-08-06 11:17 ` Linus Walleij
2012-08-06 12:36 ` Lee Jones
2012-08-06 12:36 ` Lee Jones
2012-08-06 16:00 ` Mark Brown
2012-08-06 16:00 ` Mark Brown
2012-08-06 17:22 ` Lee Jones [this message]
2012-08-06 17:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806172204.GB31409@gmail.com \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.