All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mfd: Use interrupt-parent as IRQ controller if specified in DT
Date: Mon, 6 Aug 2012 16:54:46 +0100	[thread overview]
Message-ID: <20120806155446.GD29272@sirena.org.uk> (raw)
In-Reply-To: <1344250002-6011-5-git-send-email-lee.jones@linaro.org>

On Mon, Aug 06, 2012 at 11:46:40AM +0100, Lee Jones wrote:

> -				domain = irq_find_host(parent->of_node);
> +#ifdef CONFIG_OF
> +				parent_node = of_irq_find_parent(np);
> +#endif

Shouldn't of_irq_find_parent() be stubbed out by the header?  Every
single user of this is going to need it.  Indeed, shouldn't we be making
irq_find_host() just do this?

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
	arnd@arndb.de, dmitry.torokhov@gmail.com,
	STEricsson_nomadik_linux@list.st.com, sameo@linux.intel.com
Subject: Re: [PATCH 4/6] mfd: Use interrupt-parent as IRQ controller if specified in DT
Date: Mon, 6 Aug 2012 16:54:46 +0100	[thread overview]
Message-ID: <20120806155446.GD29272@sirena.org.uk> (raw)
In-Reply-To: <1344250002-6011-5-git-send-email-lee.jones@linaro.org>

On Mon, Aug 06, 2012 at 11:46:40AM +0100, Lee Jones wrote:

> -				domain = irq_find_host(parent->of_node);
> +#ifdef CONFIG_OF
> +				parent_node = of_irq_find_parent(np);
> +#endif

Shouldn't of_irq_find_parent() be stubbed out by the header?  Every
single user of this is going to need it.  Indeed, shouldn't we be making
irq_find_host() just do this?

  reply	other threads:[~2012-08-06 15:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 10:46 [PATCH 0/6] Device Tree IRQ related enablement patches Lee Jones
2012-08-06 10:46 ` Lee Jones
2012-08-06 10:46 ` [PATCH 1/6] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 10:46 ` [PATCH 2/6] mfd: Provide the PRCMU with its own IRQ domain Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 11:50   ` Arnd Bergmann
2012-08-06 11:50     ` Arnd Bergmann
2012-08-06 10:46 ` [PATCH 3/6] ARM: ux500: Force AB8500 to use the GIC as its interrupt controller Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 10:46 ` [PATCH 4/6] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 15:54   ` Mark Brown [this message]
2012-08-06 15:54     ` Mark Brown
2012-08-06 17:21     ` Lee Jones
2012-08-06 17:21       ` Lee Jones
2012-08-06 10:46 ` [PATCH 5/6] ARM: ux500: Match-up compatible stings with associated MFD cell Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 10:46 ` [PATCH 6/6] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Lee Jones
2012-08-06 10:46   ` Lee Jones
2012-08-06 11:17   ` Linus Walleij
2012-08-06 11:17     ` Linus Walleij
2012-08-06 12:36   ` Lee Jones
2012-08-06 12:36     ` Lee Jones
2012-08-06 16:00   ` Mark Brown
2012-08-06 16:00     ` Mark Brown
2012-08-06 17:22     ` Lee Jones
2012-08-06 17:22       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120806155446.GD29272@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.