All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dove: Remove watchdog from DT
Date: Tue, 25 Sep 2012 11:46:10 +0200	[thread overview]
Message-ID: <20120925094610.GF27099@lunn.ch> (raw)
In-Reply-To: <20120925111826.6f4086ee@skate>

On Tue, Sep 25, 2012 at 11:18:26AM +0200, Thomas Petazzoni wrote:
> Dear Sebastian Hesselbarth,
> 
> On Tue, 25 Sep 2012 11:11:42 +0200, Sebastian Hesselbarth wrote:
> 
> > I didn't try to post all the dove on mach-mvebu patches in the current
> > release cycle, because mach-mvebu is still evolving to fast for me to keep
> > up with my limited spare time. But I have dove running on mach-mvebu...
> 
> Yes, this work is really great. However, I think that instead of making
> a big change at once, we should rather follow something like:
> 
>  * Make mach-dove, mach-kirkwood, mach-orion5x, mach-mv78xx0 use the
>    new gpio/pinctrl code

I principle, i agree. However, i'm not too sure about mach-orion5x &
mach-mv78xx0. orion5x has probably been broken since -rc1 was released
and nobody noticed. In the same time, we got around 5 people
independently reporting kirkwood was broken. We have not received any
new boards for orion5x in the time i've been looking at Orion
platforms. mv78xx0 only has one board which is not a Marvell reference
design. So im tempted to not spend any effort moving orion5x or
mv78xx0 to DT unless these actually hinder the effort of moving the
others to DT.  What may make sense is to flatten mv78xx0 and orion5x
into plat-orion and then just watch the bit-rot happen.

I have patches which convert all existing DT based kirkwood boards to
the new gpio/pinctrl code. There are two outstanding issues:

1) I've no idea which kirkwood variant each board uses. Hence the
   compatibility string will be wrong for a lot of them.

2) I'm probably made lots of dumb typos.

So we need to get board maintainers to complete and test the work.

>  * Refactor the PCI code so that it can cover all cases. We should soon
>    be working on PCI support on Armada 370/XP, so it will show what are
>    the differences/issues in having something that covers all cases.

Have you looked at the orion5x PCI code? Its very different to all the
others and i doubt it will be easy to make work with all the others.

       Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@arm.linux.org.uk>,
	Jason Cooper <jason@lakedaemon.net>,
	Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH 5/6] ARM: dove: Remove watchdog from DT
Date: Tue, 25 Sep 2012 11:46:10 +0200	[thread overview]
Message-ID: <20120925094610.GF27099@lunn.ch> (raw)
In-Reply-To: <20120925111826.6f4086ee@skate>

On Tue, Sep 25, 2012 at 11:18:26AM +0200, Thomas Petazzoni wrote:
> Dear Sebastian Hesselbarth,
> 
> On Tue, 25 Sep 2012 11:11:42 +0200, Sebastian Hesselbarth wrote:
> 
> > I didn't try to post all the dove on mach-mvebu patches in the current
> > release cycle, because mach-mvebu is still evolving to fast for me to keep
> > up with my limited spare time. But I have dove running on mach-mvebu...
> 
> Yes, this work is really great. However, I think that instead of making
> a big change at once, we should rather follow something like:
> 
>  * Make mach-dove, mach-kirkwood, mach-orion5x, mach-mv78xx0 use the
>    new gpio/pinctrl code

I principle, i agree. However, i'm not too sure about mach-orion5x &
mach-mv78xx0. orion5x has probably been broken since -rc1 was released
and nobody noticed. In the same time, we got around 5 people
independently reporting kirkwood was broken. We have not received any
new boards for orion5x in the time i've been looking at Orion
platforms. mv78xx0 only has one board which is not a Marvell reference
design. So im tempted to not spend any effort moving orion5x or
mv78xx0 to DT unless these actually hinder the effort of moving the
others to DT.  What may make sense is to flatten mv78xx0 and orion5x
into plat-orion and then just watch the bit-rot happen.

I have patches which convert all existing DT based kirkwood boards to
the new gpio/pinctrl code. There are two outstanding issues:

1) I've no idea which kirkwood variant each board uses. Hence the
   compatibility string will be wrong for a lot of them.

2) I'm probably made lots of dumb typos.

So we need to get board maintainers to complete and test the work.

>  * Refactor the PCI code so that it can cover all cases. We should soon
>    be working on PCI support on Armada 370/XP, so it will show what are
>    the differences/issues in having something that covers all cases.

Have you looked at the orion5x PCI code? Its very different to all the
others and i doubt it will be easy to make work with all the others.

       Andrew

  reply	other threads:[~2012-09-25  9:46 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25  0:02 [PATCH 0/6] Dove fixes for arm-soc/for-next Sebastian Hesselbarth
2012-09-25  0:02 ` Sebastian Hesselbarth
2012-09-25  0:02 ` [PATCH 1/6] ARM: dove: Add pcie clock support Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  0:02 ` [PATCH 2/6] ARM: dove: Fix tauros2 device tree init Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  1:22   ` Sebastian Hesselbarth
2012-09-25  1:22     ` Sebastian Hesselbarth
2012-09-25  5:19     ` Andrew Lunn
2012-09-25  5:19       ` Andrew Lunn
2012-09-25  8:56       ` Sebastian Hesselbarth
2012-09-25  8:56         ` Sebastian Hesselbarth
2012-09-25  0:02 ` [PATCH 3/6] ARM: dove: Fix clock names of sata and gbe Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  0:02 ` [PATCH 4/6] ARM: dove: Restructure SoC device tree descriptor Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  0:02 ` [PATCH 5/6] ARM: dove: Remove watchdog from DT Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  5:35   ` Andrew Lunn
2012-09-25  5:35     ` Andrew Lunn
2012-09-25  9:11     ` Sebastian Hesselbarth
2012-09-25  9:11       ` Sebastian Hesselbarth
2012-09-25  9:18       ` Thomas Petazzoni
2012-09-25  9:18         ` Thomas Petazzoni
2012-09-25  9:46         ` Andrew Lunn [this message]
2012-09-25  9:46           ` Andrew Lunn
2012-09-25 10:14           ` Thomas Petazzoni
2012-09-25 10:14             ` Thomas Petazzoni
2012-09-25 10:31             ` Andrew Lunn
2012-09-25 10:31               ` Andrew Lunn
2012-09-25 11:20               ` Arnd Bergmann
2012-09-25 11:20                 ` Arnd Bergmann
2012-09-25 11:48                 ` Arnaud Patard (Rtp)
2012-09-25 11:48                   ` Arnaud Patard
2012-09-25 12:28                   ` Arnd Bergmann
2012-09-25 12:28                     ` Arnd Bergmann
2012-10-08 18:40                     ` Martin Michlmayr
2012-10-08 19:57                       ` Andrew Lunn
2012-10-08 20:10                         ` Arnd Bergmann
2012-10-08 20:29                           ` Andrew Lunn
2012-09-25 12:33                 ` Arnd Bergmann
2012-09-25 12:33                   ` Arnd Bergmann
2012-09-25 18:25                   ` sebastien requiem
2012-09-25 20:02                     ` Arnd Bergmann
2012-09-25 20:02                       ` Arnd Bergmann
2012-09-25  0:02 ` [PATCH 6/6] ARM: dove: Add crypto engine to DT Sebastian Hesselbarth
2012-09-25  0:02   ` Sebastian Hesselbarth
2012-09-25  5:37 ` [PATCH 0/6] Dove fixes for arm-soc/for-next Andrew Lunn
2012-09-25  5:37   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925094610.GF27099@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.