All of lore.kernel.org
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib
Date: Fri, 28 Sep 2012 18:01:05 +0200	[thread overview]
Message-ID: <20120928160105.GA17667@game.jcrosoft.org> (raw)
In-Reply-To: <50658AD0.1050501@antcom.de>

On 13:32 Fri 28 Sep     , Roland Stigge wrote:
> On 09/28/2012 12:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> gpio0 = {1};
> >> set0 = {1};
> >>
> >> gpio1 = {33, 34};
> > here should be
> > 
> > pin0 = {1};
> > set0 = {1};
> > 
> > pin1 = {1, 2, 23};
> > set1 = {0, 0, 1};
> > 
> > set_blocks(gpio_chip0, pin0, set0, 1);
> > set_blocks(gpio_chip1, pin1, set1, 3);
> > 
> > You may need to add a prepare to do not do the conversion between array and
> > gpio_chip array as I guess you will work on gpio block with multiple time
> > acces
> 
> Maybe like this, for some struct block *?
> 
> block = set_block_prepare(gc, pins, values, size);
> if (block) {
> 	set_block(gc, block);
> 	...
> 	set_block_unprepare(gc, block);
> }
> 
> Would mean that all supported drivers would need to implement those 3
> new functions... Need to be careful about not introducing bloat...
the prepare is gpiolib specific, it will be a helper to conver a gpio list to
a gpio block list

I was thinking more

block = gpio_block_prepare(pins, size);

gpio_block_set_value(pin0, val);
gpio_block_set_value(pin1, val);
gpio_block_set_value(pin2, val);
gpio_block_set(block);

andfor get

gpio_block_get(block)
val = gpio_block_get_value(block, pin0);
val = gpio_block_get_value(block, pin1);

for the gpio driver ti's transparent

Best Regards,
J.

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Roland Stigge <stigge@antcom.de>
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	w.sang@pengutronix.de, grant.likely@secretlab.ca,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib
Date: Fri, 28 Sep 2012 18:01:05 +0200	[thread overview]
Message-ID: <20120928160105.GA17667@game.jcrosoft.org> (raw)
In-Reply-To: <50658AD0.1050501@antcom.de>

On 13:32 Fri 28 Sep     , Roland Stigge wrote:
> On 09/28/2012 12:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> gpio0 = {1};
> >> set0 = {1};
> >>
> >> gpio1 = {33, 34};
> > here should be
> > 
> > pin0 = {1};
> > set0 = {1};
> > 
> > pin1 = {1, 2, 23};
> > set1 = {0, 0, 1};
> > 
> > set_blocks(gpio_chip0, pin0, set0, 1);
> > set_blocks(gpio_chip1, pin1, set1, 3);
> > 
> > You may need to add a prepare to do not do the conversion between array and
> > gpio_chip array as I guess you will work on gpio block with multiple time
> > acces
> 
> Maybe like this, for some struct block *?
> 
> block = set_block_prepare(gc, pins, values, size);
> if (block) {
> 	set_block(gc, block);
> 	...
> 	set_block_unprepare(gc, block);
> }
> 
> Would mean that all supported drivers would need to implement those 3
> new functions... Need to be careful about not introducing bloat...
the prepare is gpiolib specific, it will be a helper to conver a gpio list to
a gpio block list

I was thinking more

block = gpio_block_prepare(pins, size);

gpio_block_set_value(pin0, val);
gpio_block_set_value(pin1, val);
gpio_block_set_value(pin2, val);
gpio_block_set(block);

andfor get

gpio_block_get(block)
val = gpio_block_get_value(block, pin0);
val = gpio_block_get_value(block, pin1);

for the gpio driver ti's transparent

Best Regards,
J.

  reply	other threads:[~2012-09-28 16:01 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 21:22 [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib Roland Stigge
2012-09-27 21:22 ` Roland Stigge
2012-09-27 21:22 ` [PATCH RFC 2/2] gpio-max730x: Add block GPIO API Roland Stigge
2012-09-27 21:22   ` Roland Stigge
2012-09-28  2:47 ` [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  2:47   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  7:14   ` Roland Stigge
2012-09-28  7:14     ` Roland Stigge
2012-09-28  7:51     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  7:51       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  8:51       ` Roland Stigge
2012-09-28  8:51         ` Roland Stigge
2012-09-28  9:08         ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  9:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  9:23           ` Roland Stigge
2012-09-28  9:23             ` Roland Stigge
2012-09-28 10:28           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 10:28             ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 11:32             ` Roland Stigge
2012-09-28 11:32               ` Roland Stigge
2012-09-28 16:01               ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-28 16:01                 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 18:32                 ` Roland Stigge
2012-09-28 18:32                   ` Roland Stigge
2012-09-29 19:57                   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-29 19:57                     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 10:34                     ` Roland Stigge
2012-09-30 10:34                       ` Roland Stigge
2012-09-30 15:11                       ` Stijn Devriendt
2012-09-30 15:11                         ` Stijn Devriendt
2012-09-28  9:14 ` Linus Walleij
2012-09-28  9:14   ` Linus Walleij
2012-09-28  9:52   ` Roland Stigge
2012-09-28  9:52     ` Roland Stigge
2012-09-28 11:34     ` Linus Walleij
2012-09-28 11:34       ` Linus Walleij
2012-09-28 12:35       ` Roland Stigge
2012-09-28 12:35         ` Roland Stigge
2012-09-30  9:35 ` Stijn Devriendt
2012-09-30  9:39   ` Stijn Devriendt
2012-09-30 10:50   ` Roland Stigge
2012-09-30 10:50     ` Roland Stigge
2012-09-30 14:52     ` Stijn Devriendt
2012-09-30 14:52       ` Stijn Devriendt
2012-09-30 15:09       ` Roland Stigge
2012-09-30 15:09         ` Roland Stigge
2012-09-30 15:19         ` Stijn Devriendt
2012-09-30 15:19           ` Stijn Devriendt
2012-09-30 15:46           ` Roland Stigge
2012-09-30 15:46             ` Roland Stigge
2012-10-03 23:11             ` Linus Walleij
2012-10-03 23:11               ` Linus Walleij
2012-10-03 23:07     ` Linus Walleij
2012-10-03 23:07       ` Linus Walleij
2012-10-04 20:25       ` Roland Stigge
2012-10-04 20:25         ` Roland Stigge
2012-10-03 19:08 ` Mark Brown
2012-10-03 19:08   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928160105.GA17667@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.