All of lore.kernel.org
 help / color / mirror / Atom feed
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib
Date: Thu, 04 Oct 2012 22:25:48 +0200	[thread overview]
Message-ID: <506DF0CC.9000202@antcom.de> (raw)
In-Reply-To: <CACRpkdYGePft_XvhhoNyRfBm484FD46WGagivQzjh5-OE3VJUA@mail.gmail.com>

Hi,

On 04/10/12 01:07, Linus Walleij wrote:
>> What do others think? JC? Linus? I'm considering this (unsigned int
>> data) a valid option.
> 
> I think we mostly use an unsigned long for such stuff as IRQ flags
> and ioctl() parameters in the kernel.
> 
> In this case it has the upside that it will be 32bit on 32bit systems
> and 64bit on 64bit systems if I'm not mistaken.

Fine. Will try to prepare a patch tomorrow, including fallback to single
GPIO handling (if the driver doesn't implement block operations) and
omitting the sysfs interface in the first patch.

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stijn Devriendt <highguy@gmail.com>,
	grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, w.sang@pengutronix.de,
	jbe@pengutronix.de,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
	bgat@billgatliff.com,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib
Date: Thu, 04 Oct 2012 22:25:48 +0200	[thread overview]
Message-ID: <506DF0CC.9000202@antcom.de> (raw)
In-Reply-To: <CACRpkdYGePft_XvhhoNyRfBm484FD46WGagivQzjh5-OE3VJUA@mail.gmail.com>

Hi,

On 04/10/12 01:07, Linus Walleij wrote:
>> What do others think? JC? Linus? I'm considering this (unsigned int
>> data) a valid option.
> 
> I think we mostly use an unsigned long for such stuff as IRQ flags
> and ioctl() parameters in the kernel.
> 
> In this case it has the upside that it will be 32bit on 32bit systems
> and 64bit on 64bit systems if I'm not mistaken.

Fine. Will try to prepare a patch tomorrow, including fallback to single
GPIO handling (if the driver doesn't implement block operations) and
omitting the sysfs interface in the first patch.

Roland

  reply	other threads:[~2012-10-04 20:25 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 21:22 [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib Roland Stigge
2012-09-27 21:22 ` Roland Stigge
2012-09-27 21:22 ` [PATCH RFC 2/2] gpio-max730x: Add block GPIO API Roland Stigge
2012-09-27 21:22   ` Roland Stigge
2012-09-28  2:47 ` [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  2:47   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  7:14   ` Roland Stigge
2012-09-28  7:14     ` Roland Stigge
2012-09-28  7:51     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  7:51       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  8:51       ` Roland Stigge
2012-09-28  8:51         ` Roland Stigge
2012-09-28  9:08         ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  9:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28  9:23           ` Roland Stigge
2012-09-28  9:23             ` Roland Stigge
2012-09-28 10:28           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 10:28             ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 11:32             ` Roland Stigge
2012-09-28 11:32               ` Roland Stigge
2012-09-28 16:01               ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 16:01                 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 18:32                 ` Roland Stigge
2012-09-28 18:32                   ` Roland Stigge
2012-09-29 19:57                   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-29 19:57                     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-30 10:34                     ` Roland Stigge
2012-09-30 10:34                       ` Roland Stigge
2012-09-30 15:11                       ` Stijn Devriendt
2012-09-30 15:11                         ` Stijn Devriendt
2012-09-28  9:14 ` Linus Walleij
2012-09-28  9:14   ` Linus Walleij
2012-09-28  9:52   ` Roland Stigge
2012-09-28  9:52     ` Roland Stigge
2012-09-28 11:34     ` Linus Walleij
2012-09-28 11:34       ` Linus Walleij
2012-09-28 12:35       ` Roland Stigge
2012-09-28 12:35         ` Roland Stigge
2012-09-30  9:35 ` Stijn Devriendt
2012-09-30  9:39   ` Stijn Devriendt
2012-09-30 10:50   ` Roland Stigge
2012-09-30 10:50     ` Roland Stigge
2012-09-30 14:52     ` Stijn Devriendt
2012-09-30 14:52       ` Stijn Devriendt
2012-09-30 15:09       ` Roland Stigge
2012-09-30 15:09         ` Roland Stigge
2012-09-30 15:19         ` Stijn Devriendt
2012-09-30 15:19           ` Stijn Devriendt
2012-09-30 15:46           ` Roland Stigge
2012-09-30 15:46             ` Roland Stigge
2012-10-03 23:11             ` Linus Walleij
2012-10-03 23:11               ` Linus Walleij
2012-10-03 23:07     ` Linus Walleij
2012-10-03 23:07       ` Linus Walleij
2012-10-04 20:25       ` Roland Stigge [this message]
2012-10-04 20:25         ` Roland Stigge
2012-10-03 19:08 ` Mark Brown
2012-10-03 19:08   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506DF0CC.9000202@antcom.de \
    --to=stigge@antcom.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.