All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	Josh Triplett <josh@joshtriplett.org>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	paul.gortmaker@windriver.com, davem@davemloft.net,
	rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
	aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
	eric.dumazet@gmail.com, axboe@kernel.dk, agk@redhat.com,
	dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
	teigland@redhat.com, Trond.Myklebust@netapp.com,
	bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
	venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
	snitzer@redhat.com, edumazet@google.com,
	linux-nfs@vger.kernel.org, dev@openvswitch.org,
	rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH v7 06/16] tracepoint: use new hashtable implementation
Date: Mon, 29 Oct 2012 11:58:14 -0700	[thread overview]
Message-ID: <20121029185814.GC4066@htj.dyndns.org> (raw)
In-Reply-To: <20121029185319.GA21546@Krystal>

On Mon, Oct 29, 2012 at 02:53:19PM -0400, Mathieu Desnoyers wrote:
> The argument about hash_init being useful to add magic values in the
> future only works for the cases where a hash table is declared with
> DECLARE_HASHTABLE(). It's completely pointless with DEFINE_HASHTABLE(),
> because we could initialize any debugging variables from within
> DEFINE_HASHTABLE().

You can do that with [0 .. HASH_SIZE - 1] initializer.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
	Josh Triplett <josh@joshtriplett.org>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	paul.gortmaker@windriver.com, davem@davemloft.net,
	rostedt@goodmis.org, mingo@elte.hu, ebiederm@xmission.com,
	aarcange@redhat.com, ericvh@gmail.com, netdev@vger.kernel.org,
	eric.dumazet@gmail.com, axboe@kernel.dk, agk@redhat.com,
	dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
	teigland@redhat.com, Trond.Myklebust@netapp.com,
	bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
	venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
	snitzer@redhat.com, edumazet@google.com,
	linux-nfs@vger.kernel.org, dev@openvswitch.org,
	rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH v7 06/16] tracepoint: use new hashtable implementation
Date: Mon, 29 Oct 2012 11:58:14 -0700	[thread overview]
Message-ID: <20121029185814.GC4066@htj.dyndns.org> (raw)
In-Reply-To: <20121029185319.GA21546@Krystal>

On Mon, Oct 29, 2012 at 02:53:19PM -0400, Mathieu Desnoyers wrote:
> The argument about hash_init being useful to add magic values in the
> future only works for the cases where a hash table is declared with
> DECLARE_HASHTABLE(). It's completely pointless with DEFINE_HASHTABLE(),
> because we could initialize any debugging variables from within
> DEFINE_HASHTABLE().

You can do that with [0 .. HASH_SIZE - 1] initializer.

Thanks.

-- 
tejun

  reply	other threads:[~2012-10-29 18:58 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-28 19:02 [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
2012-10-28 19:02 ` Sasha Levin
2012-10-28 19:02 ` Sasha Levin
2012-10-28 19:02 ` [PATCH v7 05/16] mm/huge_memory: use new hashtable implementation Sasha Levin
2012-10-28 19:02   ` Sasha Levin
2012-10-28 19:02 ` [PATCH v7 06/16] tracepoint: " Sasha Levin
2012-10-28 19:02   ` Sasha Levin
2012-10-29 11:35   ` Mathieu Desnoyers
2012-10-29 11:35     ` Mathieu Desnoyers
2012-10-29 17:29     ` Sasha Levin
2012-10-29 17:29       ` Sasha Levin
     [not found]       ` <CA+1xoqce6uJ6wy3+2CBwsLHKnsz4wD0vt8MBEGKCFfXTvuC0Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 17:50         ` Mathieu Desnoyers
2012-10-29 17:50           ` Mathieu Desnoyers
2012-10-29 17:50           ` Mathieu Desnoyers
2012-10-29 18:31         ` Josh Triplett
2012-10-29 18:31           ` Josh Triplett
2012-10-29 18:31           ` Josh Triplett
2012-10-29 18:42           ` Sasha Levin
2012-10-29 18:42             ` Sasha Levin
     [not found]             ` <CA+1xoqfMrn9zDFMJNFfA0NA86wE_DedD97cP1yJ2UQdTjs3uyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 18:53               ` Mathieu Desnoyers
2012-10-29 18:53                 ` Mathieu Desnoyers
2012-10-29 18:53                 ` Mathieu Desnoyers
2012-10-29 18:58                 ` Tejun Heo [this message]
2012-10-29 18:58                   ` Tejun Heo
     [not found]                   ` <20121029185814.GC4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:01                     ` Tejun Heo
2012-10-29 19:01                       ` Tejun Heo
2012-10-29 19:01                       ` Tejun Heo
     [not found]                       ` <20121029190107.GD4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:10                         ` Mathieu Desnoyers
2012-10-29 19:10                           ` Mathieu Desnoyers
2012-10-29 19:10                           ` Mathieu Desnoyers
2012-10-29 19:09                 ` Sasha Levin
2012-10-29 19:09                   ` Sasha Levin
     [not found]                   ` <CA+1xoqcSx04JEXy2aPu4Qt7Zb4iSqXBSjARgMae_FusgzpgnaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 19:12                     ` Tejun Heo
2012-10-29 19:12                       ` Tejun Heo
2012-10-29 19:12                       ` Tejun Heo
     [not found]                       ` <20121029191256.GE4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:17                         ` Sasha Levin
2012-10-29 19:17                           ` Sasha Levin
2012-10-29 19:17                           ` Sasha Levin
2012-10-29 19:16                   ` Mathieu Desnoyers
2012-10-29 19:16                     ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 08/16] block,elevator: " Sasha Levin
2012-10-28 19:02   ` Sasha Levin
2012-10-29  1:29   ` Tejun Heo
2012-10-29  1:29     ` Tejun Heo
     [not found]   ` <1351450948-15618-8-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:20     ` Mathieu Desnoyers
2012-10-29 12:20       ` Mathieu Desnoyers
2012-10-29 12:20       ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 09/16] SUNRPC/cache: " Sasha Levin
2012-10-28 19:02   ` Sasha Levin
2012-10-29 12:42   ` Mathieu Desnoyers
2012-10-29 12:42     ` Mathieu Desnoyers
2012-10-29 14:49     ` Linus Torvalds
2012-10-29 14:49       ` Linus Torvalds
2012-10-29 14:49       ` Linus Torvalds
2012-10-29 15:13       ` Mathieu Desnoyers
2012-10-29 15:13         ` Mathieu Desnoyers
2012-10-29 15:16         ` J. Bruce Fields
2012-10-29 15:16           ` J. Bruce Fields
     [not found]           ` <20121029151653.GC9502-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-10-29 15:41             ` Mathieu Desnoyers
2012-10-29 15:41               ` Mathieu Desnoyers
2012-10-29 15:41               ` Mathieu Desnoyers
     [not found]       ` <CA+55aFzO8DJJP3HBfgqXFac9r3=bYK+_nYe4cuXiNFg-623s6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 16:27         ` Andrew Morton
2012-10-29 16:27           ` Andrew Morton
2012-10-29 16:27           ` Andrew Morton
2012-10-28 19:02 ` [PATCH v7 11/16] net,l2tp: " Sasha Levin
2012-10-28 19:02   ` Sasha Levin
2012-10-29 13:04   ` Mathieu Desnoyers
2012-10-29 13:04     ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 13/16] lockd: " Sasha Levin
2012-10-28 19:02   ` Sasha Levin
     [not found]   ` <1351450948-15618-13-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 13:23     ` Mathieu Desnoyers
2012-10-29 13:23       ` Mathieu Desnoyers
2012-10-29 13:23       ` Mathieu Desnoyers
     [not found] ` <1351450948-15618-1-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-28 19:02   ` [PATCH v7 02/16] userns: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02   ` [PATCH v7 03/16] mm, ksm: " Sasha Levin
2012-10-28 19:02     ` [PATCH v7 03/16] mm,ksm: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02   ` [PATCH v7 04/16] workqueue: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
     [not found]     ` <1351450948-15618-4-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29  1:25       ` Tejun Heo
2012-10-29  1:25         ` Tejun Heo
2012-10-29  1:25         ` Tejun Heo
2012-10-28 19:02   ` [PATCH v7 07/16] net, 9p: " Sasha Levin
2012-10-28 19:02     ` [PATCH v7 07/16] net,9p: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
     [not found]     ` <1351450948-15618-7-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:15       ` [PATCH v7 07/16] net, 9p: " Mathieu Desnoyers
2012-10-29 12:15         ` [PATCH v7 07/16] net,9p: " Mathieu Desnoyers
2012-10-29 12:15         ` Mathieu Desnoyers
2012-10-28 19:02   ` [PATCH v7 10/16] dlm: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
     [not found]     ` <1351450948-15618-10-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:46       ` Mathieu Desnoyers
2012-10-29 12:46         ` Mathieu Desnoyers
2012-10-29 12:46         ` Mathieu Desnoyers
2012-10-29 13:07         ` Mathieu Desnoyers
2012-10-29 13:07           ` Mathieu Desnoyers
2012-10-29 15:53           ` Sasha Levin
2012-10-29 15:53             ` Sasha Levin
2012-10-29 15:53             ` Sasha Levin
2012-10-29 16:07             ` Mathieu Desnoyers
2012-10-29 16:07               ` Mathieu Desnoyers
2012-10-29 16:23               ` David Teigland
2012-10-29 16:23                 ` David Teigland
2012-10-28 19:02   ` [PATCH v7 12/16] dm: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02   ` [PATCH v7 14/16] net, rds: " Sasha Levin
2012-10-28 19:02     ` [PATCH v7 14/16] net,rds: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
     [not found]     ` <1351450948-15618-14-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 13:25       ` Mathieu Desnoyers
2012-10-29 13:25         ` Mathieu Desnoyers
2012-10-29 13:25         ` Mathieu Desnoyers
2012-10-28 19:02   ` [PATCH v7 15/16] openvswitch: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-29 13:29     ` Mathieu Desnoyers
2012-10-29 13:29       ` Mathieu Desnoyers
2012-10-29 15:43       ` Sasha Levin
2012-10-29 15:43         ` Sasha Levin
2012-10-29 15:43         ` Sasha Levin
     [not found]         ` <CA+1xoqfRGhPaBEVh228O5_295bWh8FmcyLSOwq8VE5Dm7i3JHg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 15:59           ` Mathieu Desnoyers
2012-10-29 15:59             ` Mathieu Desnoyers
2012-10-29 15:59             ` Mathieu Desnoyers
2012-10-29 17:35             ` Sasha Levin
2012-10-29 17:35               ` Sasha Levin
     [not found]               ` <CA+1xoqcr5xmOkDfqL3P84CNdotOALOhiLRkJjsPCZzijSQUF6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 18:16                 ` Mathieu Desnoyers
2012-10-29 18:16                   ` Mathieu Desnoyers
2012-10-29 18:16                   ` Mathieu Desnoyers
2012-10-29 18:22                   ` Tejun Heo
2012-10-29 18:22                     ` Tejun Heo
2012-10-29 18:22                     ` Tejun Heo
     [not found]                     ` <20121029182209.GB4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 18:35                       ` Mathieu Desnoyers
2012-10-29 18:35                         ` Mathieu Desnoyers
2012-10-29 18:35                         ` Mathieu Desnoyers
2012-10-28 19:02   ` [PATCH v7 16/16] tracing output: " Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-28 19:02     ` Sasha Levin
2012-10-29 11:29 ` [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Mathieu Desnoyers
2012-10-29 11:29   ` Mathieu Desnoyers
2012-10-29 16:06   ` Sasha Levin
2012-10-29 16:06     ` Sasha Levin
2012-10-29 16:14     ` Mathieu Desnoyers
2012-10-29 16:14       ` Mathieu Desnoyers
2012-10-29 16:18       ` Tejun Heo
2012-10-29 16:18         ` Tejun Heo
2012-10-29 16:18         ` Tejun Heo
2012-10-29 16:22         ` Mathieu Desnoyers
2012-10-29 16:22           ` Mathieu Desnoyers
2012-10-29 16:26       ` Sasha Levin
2012-10-29 16:26         ` Sasha Levin
     [not found]         ` <CA+1xoqfBXM4sjvcZtUncnWAaUxA9_YBod3Hjx3ZO=K1oJO_j7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 16:29           ` Mathieu Desnoyers
2012-10-29 16:29             ` Mathieu Desnoyers
2012-10-29 16:29             ` Mathieu Desnoyers
  -- strict thread matches above, loose matches on Subject: below --
2012-10-30 11:29 [PATCH v7 06/16] tracepoint: use new hashtable implementation Staci Page

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121029185814.GC4066@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=aarcange@redhat.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bfields@fieldses.org \
    --cc=ccaulfie@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dm-devel@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=ejt@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ericvh@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jesse@nicira.com \
    --cc=josh@joshtriplett.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=lw@cn.fujitsu.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=snitzer@redhat.com \
    --cc=teigland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=venkat.x.venkatsubra@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.