All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz,
	kamezawa.hiroyu@jp.fujitsu.com, rientjes@google.com,
	linux-kernel@vger.kernel.org, Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH V2 0/2] Provide more precise dump info for memcg-oom
Date: Wed, 7 Nov 2012 11:31:07 -0800	[thread overview]
Message-ID: <20121107113107.d91eba43.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352277602-21687-1-git-send-email-handai.szj@taobao.com>

On Wed,  7 Nov 2012 16:40:02 +0800
Sha Zhengju <handai.szj@gmail.com> wrote:

> When memcg oom is happening the current memcg related dump information
> is limited for debugging. The patches provide more detailed memcg page statistics
> and also take hierarchy into consideration.

Within the changelogs, please include a sample of the proposed output
so we can properly review the proposal.

Also it would be useful to provide some justification for the decisions
in this patch: which data is displayed and, particularly, which is not?
Why is the displayed information useful to developers, etc.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, mhocko@suse.cz,
	kamezawa.hiroyu@jp.fujitsu.com, rientjes@google.com,
	linux-kernel@vger.kernel.org, Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH V2 0/2] Provide more precise dump info for memcg-oom
Date: Wed, 7 Nov 2012 11:31:07 -0800	[thread overview]
Message-ID: <20121107113107.d91eba43.akpm@linux-foundation.org> (raw)
In-Reply-To: <1352277602-21687-1-git-send-email-handai.szj@taobao.com>

On Wed,  7 Nov 2012 16:40:02 +0800
Sha Zhengju <handai.szj@gmail.com> wrote:

> When memcg oom is happening the current memcg related dump information
> is limited for debugging. The patches provide more detailed memcg page statistics
> and also take hierarchy into consideration.

Within the changelogs, please include a sample of the proposed output
so we can properly review the proposal.

Also it would be useful to provide some justification for the decisions
in this patch: which data is displayed and, particularly, which is not?
Why is the displayed information useful to developers, etc.


  parent reply	other threads:[~2012-11-07 19:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07  8:40 [PATCH V2 0/2] Provide more precise dump info for memcg-oom Sha Zhengju
2012-11-07  8:40 ` Sha Zhengju
2012-11-07  8:41 ` [PATCH 1/2] memcg, oom: provide more precise dump info while memcg oom happening Sha Zhengju
2012-11-07  8:41   ` Sha Zhengju
2012-11-07 18:02   ` David Rientjes
2012-11-07 18:02     ` David Rientjes
     [not found]     ` <alpine.DEB.2.00.1211070956540.27451-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-11-08 12:37       ` Sha Zhengju
2012-11-08 12:37         ` Sha Zhengju
2012-11-08 12:37         ` Sha Zhengju
     [not found]         ` <509BA799.505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-08 12:44           ` Michal Hocko
2012-11-08 12:44             ` Michal Hocko
2012-11-08 12:44             ` Michal Hocko
     [not found]   ` <1352277696-21724-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-11-07 22:17     ` Michal Hocko
2012-11-07 22:17       ` Michal Hocko
2012-11-07 22:17       ` Michal Hocko
     [not found]       ` <20121107221709.GB26382-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-11-08 12:45         ` Sha Zhengju
2012-11-08 12:45           ` Sha Zhengju
2012-11-08 12:45           ` Sha Zhengju
2012-11-08  9:07   ` Kamezawa Hiroyuki
2012-11-08  9:07     ` Kamezawa Hiroyuki
     [not found]     ` <509B7658.1020807-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-11-08 13:12       ` Sha Zhengju
2012-11-08 13:12         ` Sha Zhengju
2012-11-08 13:12         ` Sha Zhengju
     [not found] ` <1352277602-21687-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-11-07  8:41   ` [PATCH 2/2] oom: rework dump_tasks to optimize memcg-oom situation Sha Zhengju
2012-11-07  8:41     ` Sha Zhengju
2012-11-07  8:41     ` Sha Zhengju
     [not found]     ` <1352277719-21760-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
2012-11-07 18:07       ` David Rientjes
2012-11-07 18:07         ` David Rientjes
2012-11-07 18:07         ` David Rientjes
2012-11-07 22:34     ` Michal Hocko
2012-11-07 22:34       ` Michal Hocko
     [not found]       ` <20121107223437.GC26382-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-11-08 13:58         ` Sha Zhengju
2012-11-08 13:58           ` Sha Zhengju
2012-11-08 13:58           ` Sha Zhengju
2012-11-07 19:31 ` Andrew Morton [this message]
2012-11-07 19:31   ` [PATCH V2 0/2] Provide more precise dump info for memcg-oom Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121107113107.d91eba43.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=handai.szj@gmail.com \
    --cc=handai.szj@taobao.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.