From: Andrew Morton <akpm@linux-foundation.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Lin Feng <linfeng@cn.fujitsu.com>,
viro@zeniv.linux.org.uk, bcrl@kvack.org, mhocko@suse.cz,
hughd@google.com, cl@linux.com, mgorman@suse.de,
minchan@kernel.org, isimatu.yasuaki@jp.fujitsu.com,
laijs@cn.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined
Date: Fri, 30 Nov 2012 00:00:43 -0800 [thread overview]
Message-ID: <20121130000043.cf356676.akpm@linux-foundation.org> (raw)
In-Reply-To: <50B85C8C.2030702@jp.fujitsu.com>
On Fri, 30 Nov 2012 16:13:16 +0900 Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > What about futexes?
> >
>
> IIUC, futex's key is now a pair of (mm,address) or (inode, pgoff).
> Then, get_user_page() in futex.c will release the page by put_page().
> 'struct page' is just touched by get_futex_key() to obtain page->mapping info.
Ah yes, that page is unpinned before syscall return.
grep -rl get_user_pages .
Gad.
These should be audited. The great majority will be simple and OK,
but drivers/media, drivers/infiniband and net/rds could be problematic.
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Lin Feng <linfeng@cn.fujitsu.com>,
viro@zeniv.linux.org.uk, bcrl@kvack.org, mhocko@suse.cz,
hughd@google.com, cl@linux.com, mgorman@suse.de,
minchan@kernel.org, isimatu.yasuaki@jp.fujitsu.com,
laijs@cn.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined
Date: Fri, 30 Nov 2012 00:00:43 -0800 [thread overview]
Message-ID: <20121130000043.cf356676.akpm@linux-foundation.org> (raw)
In-Reply-To: <50B85C8C.2030702@jp.fujitsu.com>
On Fri, 30 Nov 2012 16:13:16 +0900 Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > What about futexes?
> >
>
> IIUC, futex's key is now a pair of (mm,address) or (inode, pgoff).
> Then, get_user_page() in futex.c will release the page by put_page().
> 'struct page' is just touched by get_futex_key() to obtain page->mapping info.
Ah yes, that page is unpinned before syscall return.
grep -rl get_user_pages .
Gad.
These should be audited. The great majority will be simple and OK,
but drivers/media, drivers/infiniband and net/rds could be problematic.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Lin Feng <linfeng@cn.fujitsu.com>,
viro@zeniv.linux.org.uk, bcrl@kvack.org, mhocko@suse.cz,
hughd@google.com, cl@linux.com, mgorman@suse.de,
minchan@kernel.org, isimatu.yasuaki@jp.fujitsu.com,
laijs@cn.fujitsu.com, wency@cn.fujitsu.com,
tangchen@cn.fujitsu.com, linux-fsdevel@vger.kernel.org,
linux-aio@kvack.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined
Date: Fri, 30 Nov 2012 00:00:43 -0800 [thread overview]
Message-ID: <20121130000043.cf356676.akpm@linux-foundation.org> (raw)
In-Reply-To: <50B85C8C.2030702@jp.fujitsu.com>
On Fri, 30 Nov 2012 16:13:16 +0900 Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > What about futexes?
> >
>
> IIUC, futex's key is now a pair of (mm,address) or (inode, pgoff).
> Then, get_user_page() in futex.c will release the page by put_page().
> 'struct page' is just touched by get_futex_key() to obtain page->mapping info.
Ah yes, that page is unpinned before syscall return.
grep -rl get_user_pages .
Gad.
These should be audited. The great majority will be simple and OK,
but drivers/media, drivers/infiniband and net/rds could be problematic.
next prev parent reply other threads:[~2012-11-30 8:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 6:54 [BUG REPORT] [mm-hotplug, aio] aio ring_pages can't be offlined Lin Feng
2012-11-29 6:54 ` Lin Feng
2012-11-29 6:54 ` Lin Feng
2012-11-29 23:39 ` Andrew Morton
2012-11-29 23:39 ` Andrew Morton
2012-11-29 23:39 ` Andrew Morton
2012-11-30 0:04 ` Zach Brown
2012-11-30 0:04 ` Zach Brown
2012-11-30 0:04 ` Zach Brown
2012-11-30 3:39 ` Lin Feng
2012-11-30 3:39 ` Lin Feng
2012-11-30 3:39 ` Lin Feng
2012-11-30 3:42 ` Lin Feng
2012-11-30 3:42 ` Lin Feng
2012-11-30 5:57 ` Andrew Morton
2012-11-30 5:57 ` Andrew Morton
2012-11-30 7:01 ` Lin Feng
2012-11-30 7:01 ` Lin Feng
2012-11-30 7:55 ` Andrew Morton
2012-11-30 7:55 ` Andrew Morton
2012-11-30 10:29 ` Lin Feng
2012-11-30 10:29 ` Lin Feng
2012-11-30 10:47 ` Andrew Morton
2012-11-30 10:47 ` Andrew Morton
2012-11-30 10:47 ` Andrew Morton
2012-12-03 3:00 ` Lin Feng
2012-12-03 3:00 ` Lin Feng
2012-12-03 3:00 ` Lin Feng
2012-11-30 11:00 ` Mel Gorman
2012-11-30 11:00 ` Mel Gorman
2012-12-03 2:52 ` Lin Feng
2012-12-03 2:52 ` Lin Feng
2012-12-03 11:37 ` Mel Gorman
2012-12-03 11:37 ` Mel Gorman
2012-12-03 11:37 ` Mel Gorman
2012-11-30 7:13 ` Kamezawa Hiroyuki
2012-11-30 7:13 ` Kamezawa Hiroyuki
2012-11-30 8:00 ` Andrew Morton [this message]
2012-11-30 8:00 ` Andrew Morton
2012-11-30 8:00 ` Andrew Morton
2012-11-30 10:57 ` Mel Gorman
2012-11-30 10:57 ` Mel Gorman
2012-11-30 10:57 ` Mel Gorman
2012-11-30 15:24 ` Domenico Andreoli
2012-11-30 15:24 ` Domenico Andreoli
2012-11-30 15:24 ` Domenico Andreoli
2012-12-03 2:05 ` Lin Feng
2012-12-03 2:05 ` Lin Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130000043.cf356676.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.