From: Andrew Murray <andrew.murray@arm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Michal Simek <monstr@monstr.eu>,
Rob Herring <robherring2@gmail.com>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
linux-pci@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thierry Reding <thierry.reding@avionic-design.de>
Subject: Re: pci and pcie device-tree binding - range No cells
Date: Wed, 12 Dec 2012 12:19:12 +0000 [thread overview]
Message-ID: <20121212121912.GA2776@arm.com> (raw)
In-Reply-To: <CAPcvp5EJH-Q6wd7my+V+FUVE1=hzwMN-yOfHiukGvDmkcoRcsQ@mail.gmail.com>
On Wed, Dec 12, 2012 at 10:49 AM, Grant Likely wrote:
> On Wed, Dec 12, 2012 at 10:37 AM, Michal Simek <monstr@monstr.eu<mailto:monstr@monstr.eu>> wrote:
> > On 12/10/2012 10:41 PM, Grant Likely wrote:
> >> drivers/pci/pci-of.c would be good. I'd also accept drivers/of/pci.c
> >> which might actually be a good idea in the short term so that it gets
> >> appropriate supervision while being generalized before being moved into
> >> the pci directory.
> >
> > Ben: Are you willing to move that ppc code to this location?
> > It is probably not good idea that I should do it when I even don't have
> > hardware available for testing (Asking someone else).
>
> You're a clever guy, you are more than capable of crafting the patch,
> even if you can't test on hardware. :-)
>
> I refactored most of the OF support code without having access to most
> of the affected hardware. Once I got the changes out there for review
> I also asked for spot testing before getting it into linux-next for
> even more testing.
I've been working on a relatively architecture agnostic PCI host bridge driver
and also wanted to avoid duplicating more generic DT parsing code for PCI
bindings.
I've ended up with a patch which provides an iterator for returning resources
based on the the typical 'ranges' binding. This has ended up living in
drivers/of/address.c. I originally started out in drivers/of/pci.c and
drivers/pci/pci-of.c but found there were good (and static) implementations in
drivers/of/address.c which can be reused (e.g. of_bus_pci_get_flags,
bus->count_cells).
I'm not just ready to post it - but can do before early next week if you can
wait.
Andrew Murray
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Murray <andrew.murray@arm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Michal Simek <monstr@monstr.eu>,
linux-pci@vger.kernel.org,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
Rob Herring <rob.herring@calxeda.com>,
Rob Herring <robherring2@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: pci and pcie device-tree binding - range No cells
Date: Wed, 12 Dec 2012 12:19:12 +0000 [thread overview]
Message-ID: <20121212121912.GA2776@arm.com> (raw)
In-Reply-To: <CAPcvp5EJH-Q6wd7my+V+FUVE1=hzwMN-yOfHiukGvDmkcoRcsQ@mail.gmail.com>
On Wed, Dec 12, 2012 at 10:49 AM, Grant Likely wrote:
> On Wed, Dec 12, 2012 at 10:37 AM, Michal Simek <monstr@monstr.eu<mailto:m=
onstr@monstr.eu>> wrote:
> > On 12/10/2012 10:41 PM, Grant Likely wrote:
> >> drivers/pci/pci-of.c would be good. I'd also accept drivers/of/pci.c
> >> which might actually be a good idea in the short term so that it gets
> >> appropriate supervision while being generalized before being moved int=
o
> >> the pci directory.
> >
> > Ben: Are you willing to move that ppc code to this location?
> > It is probably not good idea that I should do it when I even don't have
> > hardware available for testing (Asking someone else).
>=20
> You're a clever guy, you are more than capable of crafting the patch,
> even if you can't test on hardware. :-)
>=20
> I refactored most of the OF support code without having access to most
> of the affected hardware. Once I got the changes out there for review
> I also asked for spot testing before getting it into linux-next for
> even more testing.
I've been working on a relatively architecture agnostic PCI host bridge dri=
ver
and also wanted to avoid duplicating more generic DT parsing code for PCI
bindings.
I've ended up with a patch which provides an iterator for returning resourc=
es
based on the the typical 'ranges' binding. This has ended up living in
drivers/of/address.c. I originally started out in drivers/of/pci.c and
drivers/pci/pci-of.c but found there were good (and static) implementations=
in
drivers/of/address.c which can be reused (e.g. of_bus_pci_get_flags,
bus->count_cells).
I'm not just ready to post it - but can do before early next week if you ca=
n
wait.
Andrew Murray
next prev parent reply other threads:[~2012-12-12 12:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 12:20 pci and pcie device-tree binding - range No cells Michal Simek
2012-12-10 14:26 ` Rob Herring
2012-12-10 14:26 ` Rob Herring
2012-12-10 15:05 ` Michal Simek
2012-12-10 15:05 ` Michal Simek
2012-12-10 15:21 ` Rob Herring
2012-12-10 15:21 ` Rob Herring
2012-12-10 15:37 ` Michal Simek
2012-12-10 15:37 ` Michal Simek
2012-12-10 15:52 ` David Laight
2012-12-10 15:52 ` David Laight
2012-12-10 15:52 ` David Laight
2012-12-10 16:05 ` Michal Simek
2012-12-10 16:05 ` Michal Simek
2012-12-10 17:15 ` Thomas Petazzoni
2012-12-10 17:15 ` Thomas Petazzoni
2012-12-10 23:24 ` Rob Herring
2012-12-10 23:24 ` Rob Herring
2012-12-12 16:16 ` Thomas Petazzoni
2012-12-12 16:16 ` Thomas Petazzoni
2012-12-12 17:22 ` Grant Likely
2012-12-12 17:22 ` Grant Likely
2012-12-12 17:29 ` Rob Herring
2012-12-12 17:29 ` Rob Herring
2012-12-10 16:02 ` Rob Herring
2012-12-10 16:02 ` Rob Herring
2012-12-10 16:11 ` Michal Simek
2012-12-10 16:11 ` Michal Simek
2012-12-10 21:43 ` Grant Likely
2012-12-10 21:43 ` Grant Likely
2012-12-10 22:38 ` Benjamin Herrenschmidt
2012-12-10 22:38 ` Benjamin Herrenschmidt
2012-12-10 23:11 ` Mitch Bradley
2012-12-10 23:11 ` Mitch Bradley
2012-12-10 23:11 ` Mitch Bradley
2012-12-10 21:41 ` Grant Likely
2012-12-10 21:41 ` Grant Likely
2012-12-12 10:37 ` Michal Simek
2012-12-12 10:37 ` Michal Simek
2012-12-12 10:49 ` Grant Likely
2012-12-12 10:49 ` Grant Likely
[not found] ` <CAPcvp5EJH-Q6wd7my+V+FUVE1=hzwMN-yOfHiukGvDmkcoRcsQ@mail.gmail.com>
2012-12-12 12:19 ` Andrew Murray [this message]
2012-12-12 12:19 ` Andrew Murray
2012-12-12 13:34 ` Thierry Reding
2012-12-12 13:34 ` Thierry Reding
2012-12-12 16:44 ` Andrew Murray
2012-12-12 16:44 ` Andrew Murray
2012-12-12 16:55 ` Michal Simek
2012-12-12 16:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212121912.GA2776@arm.com \
--to=andrew.murray@arm.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.