* [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 10:58 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 10:58 UTC (permalink / raw) To: linux-kernel, devicetree-discuss, linuxppc-dev Cc: Anatolij Gustschin, Stephen Warren, Rob Herring Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" renamed of_find_matching_node() to of_find_matching_node_and_match() and created a new static inline of_find_matching_node() wrapper around the new name. However, the change neglected to change the EXPORT_SYMBOL() reference causing build errors for modules. This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC Efika build with the mpc52xx_uart driver being built as a module. Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Cc: Stephen Warren <swarren@nvidia.com> Cc: Rob Herring <rob.herring@calxeda.com> Cc: Anatolij Gustschin <agust@denx.de> --- I'll push this patch out to my tree ASAP. drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index db8d211..2390ddb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, read_unlock(&devtree_lock); return np; } -EXPORT_SYMBOL(of_find_matching_node); +EXPORT_SYMBOL(of_find_matching_node_and_match); /** * of_modalias_node - Lookup appropriate modalias for a device node -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 10:58 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 10:58 UTC (permalink / raw) To: linux-kernel, devicetree-discuss, linuxppc-dev Cc: Grant Likely, Stephen Warren, Rob Herring, Anatolij Gustschin Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" renamed of_find_matching_node() to of_find_matching_node_and_match() and created a new static inline of_find_matching_node() wrapper around the new name. However, the change neglected to change the EXPORT_SYMBOL() reference causing build errors for modules. This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC Efika build with the mpc52xx_uart driver being built as a module. Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Cc: Stephen Warren <swarren@nvidia.com> Cc: Rob Herring <rob.herring@calxeda.com> Cc: Anatolij Gustschin <agust@denx.de> --- I'll push this patch out to my tree ASAP. drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index db8d211..2390ddb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, read_unlock(&devtree_lock); return np; } -EXPORT_SYMBOL(of_find_matching_node); +EXPORT_SYMBOL(of_find_matching_node_and_match); /** * of_modalias_node - Lookup appropriate modalias for a device node -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 10:58 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 10:58 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ Cc: Stephen Warren, Rob Herring Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" renamed of_find_matching_node() to of_find_matching_node_and_match() and created a new static inline of_find_matching_node() wrapper around the new name. However, the change neglected to change the EXPORT_SYMBOL() reference causing build errors for modules. This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC Efika build with the mpc52xx_uart driver being built as a module. Reported-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> Cc: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org> --- I'll push this patch out to my tree ASAP. drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index db8d211..2390ddb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, read_unlock(&devtree_lock); return np; } -EXPORT_SYMBOL(of_find_matching_node); +EXPORT_SYMBOL(of_find_matching_node_and_match); /** * of_modalias_node - Lookup appropriate modalias for a device node -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() 2012-12-19 10:58 ` Grant Likely @ 2012-12-19 11:02 ` Grant Likely -1 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 11:02 UTC (permalink / raw) To: Linux Kernel Mailing List, devicetree-discuss, linuxppc-dev@lists.ozlabs.org Cc: Anatolij Gustschin, Stephen Warren, Rob Herring On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely <grant.likely@secretlab.ca> wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. > > Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca> > Cc: Stephen Warren <swarren@nvidia.com> > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: Anatolij Gustschin <agust@denx.de> Rob, I've just pushed this out to my devicetree/merge branch. If you've got any fixes queued up for Linus, then please pull this in before sending them on to him. Otherwise I'll send Linus a pull req for this fix this evening. Ether way, please reply to let me know what you're going to do. g. The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 devicetree/merge for you to fetch changes up to 80c2022e5645a1a789531d13010292c5c18bf1db: of: Fix export of of_find_matching_node_and_match() (2012-12-19 10:58:53 +0000) ---------------------------------------------------------------- Grant Likely (1): of: Fix export of of_find_matching_node_and_match() drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) > --- > > I'll push this patch out to my tree ASAP. > > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index db8d211..2390ddb 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, > read_unlock(&devtree_lock); > return np; > } > -EXPORT_SYMBOL(of_find_matching_node); > +EXPORT_SYMBOL(of_find_matching_node_and_match); > > /** > * of_modalias_node - Lookup appropriate modalias for a device node > -- > 1.7.10.4 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 11:02 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 11:02 UTC (permalink / raw) To: Linux Kernel Mailing List, devicetree-discuss, linuxppc-dev@lists.ozlabs.org Cc: Grant Likely, Stephen Warren, Rob Herring, Anatolij Gustschin On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely <grant.likely@secretlab.ca> wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. > > Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca> > Cc: Stephen Warren <swarren@nvidia.com> > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: Anatolij Gustschin <agust@denx.de> Rob, I've just pushed this out to my devicetree/merge branch. If you've got any fixes queued up for Linus, then please pull this in before sending them on to him. Otherwise I'll send Linus a pull req for this fix this evening. Ether way, please reply to let me know what you're going to do. g. The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 devicetree/merge for you to fetch changes up to 80c2022e5645a1a789531d13010292c5c18bf1db: of: Fix export of of_find_matching_node_and_match() (2012-12-19 10:58:53 +0000) ---------------------------------------------------------------- Grant Likely (1): of: Fix export of of_find_matching_node_and_match() drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) > --- > > I'll push this patch out to my tree ASAP. > > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index db8d211..2390ddb 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, > read_unlock(&devtree_lock); > return np; > } > -EXPORT_SYMBOL(of_find_matching_node); > +EXPORT_SYMBOL(of_find_matching_node_and_match); > > /** > * of_modalias_node - Lookup appropriate modalias for a device node > -- > 1.7.10.4 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 13:50 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2012-12-19 13:50 UTC (permalink / raw) To: Grant Likely Cc: Stephen Warren, devicetree-discuss, linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List, Rob Herring On 12/19/2012 05:02 AM, Grant Likely wrote: > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > <grant.likely@secretlab.ca> wrote: >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" >> renamed of_find_matching_node() to of_find_matching_node_and_match() and >> created a new static inline of_find_matching_node() wrapper around the >> new name. However, the change neglected to change the EXPORT_SYMBOL() >> reference causing build errors for modules. >> >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC >> Efika build with the mpc52xx_uart driver being built as a module. >> >> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> >> Cc: Stephen Warren <swarren@nvidia.com> >> Cc: Rob Herring <rob.herring@calxeda.com> >> Cc: Anatolij Gustschin <agust@denx.de> > > Rob, I've just pushed this out to my devicetree/merge branch. If > you've got any fixes queued up for Linus, then please pull this in > before sending them on to him. Otherwise I'll send Linus a pull req > for this fix this evening. Ether way, please reply to let me know what > you're going to do. > The only item on my todo is this one: "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" But I'm not going to get to it today if you want to pick it up. Rob > g. > > The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: > > Merge branch 'i2c-embedded/for-next' of > git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) > > are available in the git repository at: > > git://git.secretlab.ca/git/linux-2.6 devicetree/merge > > for you to fetch changes up to 80c2022e5645a1a789531d13010292c5c18bf1db: > > of: Fix export of of_find_matching_node_and_match() (2012-12-19 > 10:58:53 +0000) > > ---------------------------------------------------------------- > Grant Likely (1): > of: Fix export of of_find_matching_node_and_match() > > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >> --- >> >> I'll push this patch out to my tree ASAP. >> >> drivers/of/base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index db8d211..2390ddb 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, >> read_unlock(&devtree_lock); >> return np; >> } >> -EXPORT_SYMBOL(of_find_matching_node); >> +EXPORT_SYMBOL(of_find_matching_node_and_match); >> >> /** >> * of_modalias_node - Lookup appropriate modalias for a device node >> -- >> 1.7.10.4 >> > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 13:50 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2012-12-19 13:50 UTC (permalink / raw) To: Grant Likely Cc: Linux Kernel Mailing List, devicetree-discuss, linuxppc-dev@lists.ozlabs.org, Stephen Warren, Rob Herring On 12/19/2012 05:02 AM, Grant Likely wrote: > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > <grant.likely@secretlab.ca> wrote: >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" >> renamed of_find_matching_node() to of_find_matching_node_and_match() and >> created a new static inline of_find_matching_node() wrapper around the >> new name. However, the change neglected to change the EXPORT_SYMBOL() >> reference causing build errors for modules. >> >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC >> Efika build with the mpc52xx_uart driver being built as a module. >> >> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> >> Cc: Stephen Warren <swarren@nvidia.com> >> Cc: Rob Herring <rob.herring@calxeda.com> >> Cc: Anatolij Gustschin <agust@denx.de> > > Rob, I've just pushed this out to my devicetree/merge branch. If > you've got any fixes queued up for Linus, then please pull this in > before sending them on to him. Otherwise I'll send Linus a pull req > for this fix this evening. Ether way, please reply to let me know what > you're going to do. > The only item on my todo is this one: "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" But I'm not going to get to it today if you want to pick it up. Rob > g. > > The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: > > Merge branch 'i2c-embedded/for-next' of > git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) > > are available in the git repository at: > > git://git.secretlab.ca/git/linux-2.6 devicetree/merge > > for you to fetch changes up to 80c2022e5645a1a789531d13010292c5c18bf1db: > > of: Fix export of of_find_matching_node_and_match() (2012-12-19 > 10:58:53 +0000) > > ---------------------------------------------------------------- > Grant Likely (1): > of: Fix export of of_find_matching_node_and_match() > > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >> --- >> >> I'll push this patch out to my tree ASAP. >> >> drivers/of/base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index db8d211..2390ddb 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, >> read_unlock(&devtree_lock); >> return np; >> } >> -EXPORT_SYMBOL(of_find_matching_node); >> +EXPORT_SYMBOL(of_find_matching_node_and_match); >> >> /** >> * of_modalias_node - Lookup appropriate modalias for a device node >> -- >> 1.7.10.4 >> > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 13:50 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2012-12-19 13:50 UTC (permalink / raw) To: Grant Likely Cc: Stephen Warren, devicetree-discuss, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linux Kernel Mailing List, Rob Herring On 12/19/2012 05:02 AM, Grant Likely wrote: > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote: >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" >> renamed of_find_matching_node() to of_find_matching_node_and_match() and >> created a new static inline of_find_matching_node() wrapper around the >> new name. However, the change neglected to change the EXPORT_SYMBOL() >> reference causing build errors for modules. >> >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC >> Efika build with the mpc52xx_uart driver being built as a module. >> >> Reported-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> >> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> >> Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> >> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> >> Cc: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org> > > Rob, I've just pushed this out to my devicetree/merge branch. If > you've got any fixes queued up for Linus, then please pull this in > before sending them on to him. Otherwise I'll send Linus a pull req > for this fix this evening. Ether way, please reply to let me know what > you're going to do. > The only item on my todo is this one: "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" But I'm not going to get to it today if you want to pick it up. Rob > g. > > The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: > > Merge branch 'i2c-embedded/for-next' of > git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) > > are available in the git repository at: > > git://git.secretlab.ca/git/linux-2.6 devicetree/merge > > for you to fetch changes up to 80c2022e5645a1a789531d13010292c5c18bf1db: > > of: Fix export of of_find_matching_node_and_match() (2012-12-19 > 10:58:53 +0000) > > ---------------------------------------------------------------- > Grant Likely (1): > of: Fix export of of_find_matching_node_and_match() > > drivers/of/base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >> --- >> >> I'll push this patch out to my tree ASAP. >> >> drivers/of/base.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index db8d211..2390ddb 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, >> read_unlock(&devtree_lock); >> return np; >> } >> -EXPORT_SYMBOL(of_find_matching_node); >> +EXPORT_SYMBOL(of_find_matching_node_and_match); >> >> /** >> * of_modalias_node - Lookup appropriate modalias for a device node >> -- >> 1.7.10.4 >> > > > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 15:04 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 15:04 UTC (permalink / raw) To: Rob Herring Cc: Stephen Warren, devicetree-discuss, linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List, Rob Herring On Wed, 19 Dec 2012 07:50:00 -0600, Rob Herring <robherring2@gmail.com> wrote: > On 12/19/2012 05:02 AM, Grant Likely wrote: > > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > > <grant.likely@secretlab.ca> wrote: > >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > >> renamed of_find_matching_node() to of_find_matching_node_and_match() and > >> created a new static inline of_find_matching_node() wrapper around the > >> new name. However, the change neglected to change the EXPORT_SYMBOL() > >> reference causing build errors for modules. > >> > >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > >> Efika build with the mpc52xx_uart driver being built as a module. > >> > >> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > >> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> > >> Cc: Stephen Warren <swarren@nvidia.com> > >> Cc: Rob Herring <rob.herring@calxeda.com> > >> Cc: Anatolij Gustschin <agust@denx.de> > > > > Rob, I've just pushed this out to my devicetree/merge branch. If > > you've got any fixes queued up for Linus, then please pull this in > > before sending them on to him. Otherwise I'll send Linus a pull req > > for this fix this evening. Ether way, please reply to let me know what > > you're going to do. > > > > The only item on my todo is this one: > > "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" > > But I'm not going to get to it today if you want to pick it up. I don't see that one anywhere. Where did it come from? g. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 15:04 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 15:04 UTC (permalink / raw) To: Rob Herring Cc: Linux Kernel Mailing List, devicetree-discuss, linuxppc-dev@lists.ozlabs.org, Stephen Warren, Rob Herring On Wed, 19 Dec 2012 07:50:00 -0600, Rob Herring <robherring2@gmail.com> wrote: > On 12/19/2012 05:02 AM, Grant Likely wrote: > > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > > <grant.likely@secretlab.ca> wrote: > >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > >> renamed of_find_matching_node() to of_find_matching_node_and_match() and > >> created a new static inline of_find_matching_node() wrapper around the > >> new name. However, the change neglected to change the EXPORT_SYMBOL() > >> reference causing build errors for modules. > >> > >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > >> Efika build with the mpc52xx_uart driver being built as a module. > >> > >> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > >> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> > >> Cc: Stephen Warren <swarren@nvidia.com> > >> Cc: Rob Herring <rob.herring@calxeda.com> > >> Cc: Anatolij Gustschin <agust@denx.de> > > > > Rob, I've just pushed this out to my devicetree/merge branch. If > > you've got any fixes queued up for Linus, then please pull this in > > before sending them on to him. Otherwise I'll send Linus a pull req > > for this fix this evening. Ether way, please reply to let me know what > > you're going to do. > > > > The only item on my todo is this one: > > "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" > > But I'm not going to get to it today if you want to pick it up. I don't see that one anywhere. Where did it come from? g. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 15:04 ` Grant Likely 0 siblings, 0 replies; 14+ messages in thread From: Grant Likely @ 2012-12-19 15:04 UTC (permalink / raw) To: Rob Herring Cc: Stephen Warren, devicetree-discuss, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linux Kernel Mailing List, Rob Herring On Wed, 19 Dec 2012 07:50:00 -0600, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On 12/19/2012 05:02 AM, Grant Likely wrote: > > On Wed, Dec 19, 2012 at 10:58 AM, Grant Likely > > <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote: > >> Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > >> renamed of_find_matching_node() to of_find_matching_node_and_match() and > >> created a new static inline of_find_matching_node() wrapper around the > >> new name. However, the change neglected to change the EXPORT_SYMBOL() > >> reference causing build errors for modules. > >> > >> This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > >> Efika build with the mpc52xx_uart driver being built as a module. > >> > >> Reported-by: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> > >> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> > >> Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > >> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> > >> Cc: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org> > > > > Rob, I've just pushed this out to my devicetree/merge branch. If > > you've got any fixes queued up for Linus, then please pull this in > > before sending them on to him. Otherwise I'll send Linus a pull req > > for this fix this evening. Ether way, please reply to let me know what > > you're going to do. > > > > The only item on my todo is this one: > > "of: define struct device in of_platform.h if !OF_DEVICE and !OF_ADDRESS" > > But I'm not going to get to it today if you want to pick it up. I don't see that one anywhere. Where did it come from? g. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 16:24 ` Stephen Warren 0 siblings, 0 replies; 14+ messages in thread From: Stephen Warren @ 2012-12-19 16:24 UTC (permalink / raw) To: Grant Likely Cc: Stephen Warren, devicetree-discuss, linuxppc-dev, linux-kernel, Rob Herring On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren <swarren@nvidia.com> I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-( ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 16:24 ` Stephen Warren 0 siblings, 0 replies; 14+ messages in thread From: Stephen Warren @ 2012-12-19 16:24 UTC (permalink / raw) To: Grant Likely Cc: linux-kernel, devicetree-discuss, linuxppc-dev, Stephen Warren, Rob Herring On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren <swarren@nvidia.com> I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-( ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] of: Fix export of of_find_matching_node_and_match() @ 2012-12-19 16:24 ` Stephen Warren 0 siblings, 0 replies; 14+ messages in thread From: Stephen Warren @ 2012-12-19 16:24 UTC (permalink / raw) To: Grant Likely Cc: Stephen Warren, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-( ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-12-19 16:24 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-19 10:58 [PATCH] of: Fix export of of_find_matching_node_and_match() Grant Likely 2012-12-19 10:58 ` Grant Likely 2012-12-19 10:58 ` Grant Likely 2012-12-19 11:02 ` Grant Likely 2012-12-19 11:02 ` Grant Likely 2012-12-19 13:50 ` Rob Herring 2012-12-19 13:50 ` Rob Herring 2012-12-19 13:50 ` Rob Herring 2012-12-19 15:04 ` Grant Likely 2012-12-19 15:04 ` Grant Likely 2012-12-19 15:04 ` Grant Likely 2012-12-19 16:24 ` Stephen Warren 2012-12-19 16:24 ` Stephen Warren 2012-12-19 16:24 ` Stephen Warren
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.