Re: [PATCH v4] tools: set migration constraints from cmdline

[Olaf Hering <olaf@aepfle.de>]

On Tue, Feb 05, Ian Campbell wrote:

> On Mon, 2013-02-04 at 18:43 +0000, Olaf Hering wrote:
> > On Mon, Feb 04, Ian Campbell wrote:
> > 
> > > It just occurred to me, instead of adding lots of individual arguments
> > > perhaps packing them into a (e.g.) libxl_save_properties and adding a
> > > pointer would be a nicer and more extensible (in the future) interface?
> > 
> > Something like this (copy&paste from hg diff)?
> 
> It's a tricky balance of what goes in the struct and what goes in the
> prototype but I didn't imagine putting domid or fd into the struct,
> domid because that's how other libxl APIs behave and fd because it isn't
> really a property of the save/migrate as such.
> 
> Moving flags into the struct could be optional is it complicates the
> compat code too much.

I sent v5 with a new libxl_domain_suspend prototype. If that direction
is ok I will look how to improve the LIBXL_API_VERSION handling and how
to provide a knob for DEF_MIN_REMAINING.

While I do that I would like to drop the hvm parameter from
xc_domain_save because there is a flag for this.

Olaf