All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: kexec@lists.infradead.org, xen-devel@lists.xensource.com,
	anderson@redhat.com, crash-utility@redhat.com
Subject: Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
Date: Fri, 15 Mar 2013 12:56:36 -0400	[thread overview]
Message-ID: <20130315165636.GA16644@phenom.dumpdata.com> (raw)
In-Reply-To: <20130315150921.GB12758@debian70-amd64.local.net-space.pl>

On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> altered virtual address space. Current algorithm calculating its start could
> not cope with that change. New version establishes this value on the base of
> image start address and is more generic.

And it works with the older (3.4) hypervisors binary image?
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> 
> diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
> --- crash-6.1.4.orig/xen_hyper.c	2013-02-14 21:38:54.000000000 +0100
> +++ crash-6.1.4/xen_hyper.c	2013-03-15 13:11:16.595713662 +0100
> @@ -43,10 +43,14 @@ xen_hyper_init(void)
>  #endif
>  
>  #ifdef X86_64
> -	if (xen_major_version() >= 4)
> -		xht->xen_virt_start = 0xffff82c480000000;
> -	else
> -		xht->xen_virt_start = 0xffff828c80000000;
> +	xht->xen_virt_start = symbol_value("start");
> +
> +	/*
> +	 * Xen virtual mapping is aligned to 1 GiB boundary.
> +	 * Image starts no more than 1 GiB below
> +	 * beginning of virtual address space.
> +	 */
> +	xht->xen_virt_start &= 0xffffffffc0000000;
>  #endif
>  
>  	if (machine_type("X86_64") &&
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org,
	anderson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	crash-utility-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
Date: Fri, 15 Mar 2013 12:56:36 -0400	[thread overview]
Message-ID: <20130315165636.GA16644@phenom.dumpdata.com> (raw)
In-Reply-To: <20130315150921.GB12758-ri7RxvcH2jeCtUdEpT35kVHq7GDQUN6HS7aiLakcVNdmR6Xm/wNWPw@public.gmane.org>

On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> altered virtual address space. Current algorithm calculating its start could
> not cope with that change. New version establishes this value on the base of
> image start address and is more generic.

And it works with the older (3.4) hypervisors binary image?
> 
> Signed-off-by: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> 
> diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
> --- crash-6.1.4.orig/xen_hyper.c	2013-02-14 21:38:54.000000000 +0100
> +++ crash-6.1.4/xen_hyper.c	2013-03-15 13:11:16.595713662 +0100
> @@ -43,10 +43,14 @@ xen_hyper_init(void)
>  #endif
>  
>  #ifdef X86_64
> -	if (xen_major_version() >= 4)
> -		xht->xen_virt_start = 0xffff82c480000000;
> -	else
> -		xht->xen_virt_start = 0xffff828c80000000;
> +	xht->xen_virt_start = symbol_value("start");
> +
> +	/*
> +	 * Xen virtual mapping is aligned to 1 GiB boundary.
> +	 * Image starts no more than 1 GiB below
> +	 * beginning of virtual address space.
> +	 */
> +	xht->xen_virt_start &= 0xffffffffc0000000;
>  #endif
>  
>  	if (machine_type("X86_64") &&
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org
> http://lists.xen.org/xen-devel
> 

  reply	other threads:[~2013-03-15 16:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 15:09 [PATCH 1/2] xen: Improve calculation of beginning of virtual address space Daniel Kiper
2013-03-15 15:09 ` Daniel Kiper
2013-03-15 16:56 ` Konrad Rzeszutek Wilk [this message]
2013-03-15 16:56   ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-15 17:15   ` Daniel Kiper
2013-03-15 17:15     ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130315165636.GA16644@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=anderson@redhat.com \
    --cc=crash-utility@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=kexec@lists.infradead.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.