* [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 15:09 ` Daniel Kiper
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2013-03-15 15:09 UTC (permalink / raw)
To: anderson, crash-utility, kexec, xen-devel
Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
altered virtual address space. Current algorithm calculating its start could
not cope with that change. New version establishes this value on the base of
image start address and is more generic.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
--- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100
+++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100
@@ -43,10 +43,14 @@ xen_hyper_init(void)
#endif
#ifdef X86_64
- if (xen_major_version() >= 4)
- xht->xen_virt_start = 0xffff82c480000000;
- else
- xht->xen_virt_start = 0xffff828c80000000;
+ xht->xen_virt_start = symbol_value("start");
+
+ /*
+ * Xen virtual mapping is aligned to 1 GiB boundary.
+ * Image starts no more than 1 GiB below
+ * beginning of virtual address space.
+ */
+ xht->xen_virt_start &= 0xffffffffc0000000;
#endif
if (machine_type("X86_64") &&
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 15:09 ` Daniel Kiper
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2013-03-15 15:09 UTC (permalink / raw)
To: anderson-H+wXaHxf7aLQT0dZR+AlfA,
crash-utility-H+wXaHxf7aLQT0dZR+AlfA,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR
Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
altered virtual address space. Current algorithm calculating its start could
not cope with that change. New version establishes this value on the base of
image start address and is more generic.
Signed-off-by: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
--- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100
+++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100
@@ -43,10 +43,14 @@ xen_hyper_init(void)
#endif
#ifdef X86_64
- if (xen_major_version() >= 4)
- xht->xen_virt_start = 0xffff82c480000000;
- else
- xht->xen_virt_start = 0xffff828c80000000;
+ xht->xen_virt_start = symbol_value("start");
+
+ /*
+ * Xen virtual mapping is aligned to 1 GiB boundary.
+ * Image starts no more than 1 GiB below
+ * beginning of virtual address space.
+ */
+ xht->xen_virt_start &= 0xffffffffc0000000;
#endif
if (machine_type("X86_64") &&
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 16:56 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 16:56 UTC (permalink / raw)
To: Daniel Kiper; +Cc: kexec, xen-devel, anderson, crash-utility
On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> altered virtual address space. Current algorithm calculating its start could
> not cope with that change. New version establishes this value on the base of
> image start address and is more generic.
And it works with the older (3.4) hypervisors binary image?
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
> --- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100
> +++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100
> @@ -43,10 +43,14 @@ xen_hyper_init(void)
> #endif
>
> #ifdef X86_64
> - if (xen_major_version() >= 4)
> - xht->xen_virt_start = 0xffff82c480000000;
> - else
> - xht->xen_virt_start = 0xffff828c80000000;
> + xht->xen_virt_start = symbol_value("start");
> +
> + /*
> + * Xen virtual mapping is aligned to 1 GiB boundary.
> + * Image starts no more than 1 GiB below
> + * beginning of virtual address space.
> + */
> + xht->xen_virt_start &= 0xffffffffc0000000;
> #endif
>
> if (machine_type("X86_64") &&
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 16:56 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 16:56 UTC (permalink / raw)
To: Daniel Kiper
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR,
anderson-H+wXaHxf7aLQT0dZR+AlfA,
crash-utility-H+wXaHxf7aLQT0dZR+AlfA
On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> altered virtual address space. Current algorithm calculating its start could
> not cope with that change. New version establishes this value on the base of
> image start address and is more generic.
And it works with the older (3.4) hypervisors binary image?
>
> Signed-off-by: Daniel Kiper <daniel.kiper-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff -Npru crash-6.1.4.orig/xen_hyper.c crash-6.1.4/xen_hyper.c
> --- crash-6.1.4.orig/xen_hyper.c 2013-02-14 21:38:54.000000000 +0100
> +++ crash-6.1.4/xen_hyper.c 2013-03-15 13:11:16.595713662 +0100
> @@ -43,10 +43,14 @@ xen_hyper_init(void)
> #endif
>
> #ifdef X86_64
> - if (xen_major_version() >= 4)
> - xht->xen_virt_start = 0xffff82c480000000;
> - else
> - xht->xen_virt_start = 0xffff828c80000000;
> + xht->xen_virt_start = symbol_value("start");
> +
> + /*
> + * Xen virtual mapping is aligned to 1 GiB boundary.
> + * Image starts no more than 1 GiB below
> + * beginning of virtual address space.
> + */
> + xht->xen_virt_start &= 0xffffffffc0000000;
> #endif
>
> if (machine_type("X86_64") &&
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org
> http://lists.xen.org/xen-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 17:15 ` Daniel Kiper
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2013-03-15 17:15 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: kexec, xen-devel, anderson, crash-utility
On Fri, Mar 15, 2013 at 12:56:36PM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> > Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> > altered virtual address space. Current algorithm calculating its start could
> > not cope with that change. New version establishes this value on the base of
> > image start address and is more generic.
>
> And it works with the older (3.4) hypervisors binary image?
It works without any issue.
Daniel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH 1/2] xen: Improve calculation of beginning of virtual address space
@ 2013-03-15 17:15 ` Daniel Kiper
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2013-03-15 17:15 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR,
anderson-H+wXaHxf7aLQT0dZR+AlfA,
crash-utility-H+wXaHxf7aLQT0dZR+AlfA
On Fri, Mar 15, 2013 at 12:56:36PM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 15, 2013 at 04:09:21PM +0100, Daniel Kiper wrote:
> > Xen changeset 26447 (x86: re-introduce map_domain_page() et al) once again
> > altered virtual address space. Current algorithm calculating its start could
> > not cope with that change. New version establishes this value on the base of
> > image start address and is more generic.
>
> And it works with the older (3.4) hypervisors binary image?
It works without any issue.
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-15 17:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 15:09 [PATCH 1/2] xen: Improve calculation of beginning of virtual address space Daniel Kiper
2013-03-15 15:09 ` Daniel Kiper
2013-03-15 16:56 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-15 16:56 ` Konrad Rzeszutek Wilk
2013-03-15 17:15 ` Daniel Kiper
2013-03-15 17:15 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.