All of lore.kernel.org
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/14] sched: pack the idle load balance
Date: Fri, 26 Apr 2013 14:49:32 +0200	[thread overview]
Message-ID: <20130426124931.GC13464@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1366910611-20048-5-git-send-email-vincent.guittot@linaro.org>

On Thu, Apr 25, 2013 at 07:23:20PM +0200, Vincent Guittot wrote:
> Look for an idle CPU close to the pack buddy CPU whenever possible.
> The goal is to prevent the wake up of a CPU which doesn't share the power
> domain of the pack buddy CPU.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Morten Rasmussen <morten.rasmussen@arm.com>
> ---
>  kernel/sched/fair.c |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6adc57c..a985c98 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5469,7 +5469,26 @@ static struct {
>  
>  static inline int find_new_ilb(int call_cpu)
>  {
> +	struct sched_domain *sd;
>  	int ilb = cpumask_first(nohz.idle_cpus_mask);
> +	int buddy = per_cpu(sd_pack_buddy, call_cpu);
> +
> +	/*
> +	 * If we have a pack buddy CPU, we try to run load balance on a CPU
> +	 * that is close to the buddy.
> +	 */
> +	if (buddy != -1) {
> +		for_each_domain(buddy, sd) {
> +			if (sd->flags & SD_SHARE_CPUPOWER)
> +				continue;
> +
> +			ilb = cpumask_first_and(sched_domain_span(sd),
> +					nohz.idle_cpus_mask);
> +
> +			if (ilb < nr_cpu_ids)
> +				break;
> +		}
> +	}
>  
>  	if (ilb < nr_cpu_ids && idle_cpu(ilb))
>  		return ilb;

Ha! and here you hope people won't put multiple big-little clusters in a single
machine? :-)

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org, mingo@kernel.org,
	linux@arm.linux.org.uk, pjt@google.com, santosh.shilimkar@ti.com,
	Morten.Rasmussen@arm.com, chander.kashyap@linaro.org,
	cmetcalf@tilera.com, tony.luck@intel.com, alex.shi@intel.com,
	preeti@linux.vnet.ibm.com, paulmck@linux.vnet.ibm.com,
	tglx@linutronix.de, len.brown@intel.com, arjan@linux.intel.com,
	amit.kucheria@linaro.org, corbet@lwn.net, l.majewski@samsung.com
Subject: Re: [PATCH 04/14] sched: pack the idle load balance
Date: Fri, 26 Apr 2013 14:49:32 +0200	[thread overview]
Message-ID: <20130426124931.GC13464@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1366910611-20048-5-git-send-email-vincent.guittot@linaro.org>

On Thu, Apr 25, 2013 at 07:23:20PM +0200, Vincent Guittot wrote:
> Look for an idle CPU close to the pack buddy CPU whenever possible.
> The goal is to prevent the wake up of a CPU which doesn't share the power
> domain of the pack buddy CPU.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Morten Rasmussen <morten.rasmussen@arm.com>
> ---
>  kernel/sched/fair.c |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6adc57c..a985c98 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5469,7 +5469,26 @@ static struct {
>  
>  static inline int find_new_ilb(int call_cpu)
>  {
> +	struct sched_domain *sd;
>  	int ilb = cpumask_first(nohz.idle_cpus_mask);
> +	int buddy = per_cpu(sd_pack_buddy, call_cpu);
> +
> +	/*
> +	 * If we have a pack buddy CPU, we try to run load balance on a CPU
> +	 * that is close to the buddy.
> +	 */
> +	if (buddy != -1) {
> +		for_each_domain(buddy, sd) {
> +			if (sd->flags & SD_SHARE_CPUPOWER)
> +				continue;
> +
> +			ilb = cpumask_first_and(sched_domain_span(sd),
> +					nohz.idle_cpus_mask);
> +
> +			if (ilb < nr_cpu_ids)
> +				break;
> +		}
> +	}
>  
>  	if (ilb < nr_cpu_ids && idle_cpu(ilb))
>  		return ilb;

Ha! and here you hope people won't put multiple big-little clusters in a single
machine? :-)




  reply	other threads:[~2013-04-26 12:49 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 17:23 [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-25 17:23 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 01/14] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 02/14] sched: add a new SD_SHARE_POWERDOMAIN flag for sched_domain Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 03/14] sched: pack small tasks Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:30   ` Peter Zijlstra
2013-04-26 12:30     ` Peter Zijlstra
2013-04-26 13:16     ` Vincent Guittot
2013-04-26 13:16       ` Vincent Guittot
2013-04-26 12:38   ` Peter Zijlstra
2013-04-26 12:38     ` Peter Zijlstra
2013-04-26 13:38     ` Vincent Guittot
2013-04-26 13:38       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 04/14] sched: pack the idle load balance Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:49   ` Peter Zijlstra [this message]
2013-04-26 12:49     ` Peter Zijlstra
2013-04-26 13:47     ` Vincent Guittot
2013-04-26 13:47       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 05/14] ARM: sched: clear SD_SHARE_POWERDOMAIN Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 06/14] sched: add a knob to choose the packing level Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 07/14] sched: agressively pack at wake/fork/exec Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 13:08   ` Peter Zijlstra
2013-04-26 13:08     ` Peter Zijlstra
2013-04-26 14:23     ` Vincent Guittot
2013-04-26 14:23       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 08/14] sched: trig ILB on an idle buddy Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 13:15   ` Peter Zijlstra
2013-04-26 13:15     ` Peter Zijlstra
2013-04-26 14:52     ` Vincent Guittot
2013-04-26 14:52       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 09/14] sched: evaluate the activity level of the system Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-05-22 16:50   ` Morten Rasmussen
2013-05-23  8:11     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 10/14] sched: update the buddy CPU Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-28  8:20   ` Francesco Lavra
2013-04-28  8:20     ` Francesco Lavra
2013-04-29  7:32     ` Vincent Guittot
2013-04-29  7:32       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 11/14] sched: filter task pull request Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 10:00   ` Vincent Guittot
2013-04-26 10:00     ` Vincent Guittot
2013-05-22 15:56     ` Morten Rasmussen
2013-05-22 15:56       ` Morten Rasmussen
2013-05-22 16:03       ` Vincent Guittot
2013-05-22 16:03         ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 12/14] sched: create a new field with available capacity Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 13/14] sched: update the cpu_power Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-05-22 15:46   ` Morten Rasmussen
2013-05-22 15:58     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 14/14] sched: force migration on buddy CPU Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:08 ` [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-26 12:08   ` Vincent Guittot
2013-04-26 15:00 ` Arjan van de Ven
2013-04-26 15:00   ` Arjan van de Ven
2013-04-26 15:40   ` Vincent Guittot
2013-04-26 15:40     ` Vincent Guittot
2013-04-26 15:46     ` Arjan van de Ven
2013-04-26 15:46       ` Arjan van de Ven
2013-04-26 15:56       ` Vincent Guittot
2013-04-26 15:56         ` Vincent Guittot
2013-05-02  9:12       ` Vincent Guittot
2013-05-02  9:12         ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426124931.GC13464@dyad.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.