All of lore.kernel.org
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/14] sched: agressively pack at wake/fork/exec
Date: Fri, 26 Apr 2013 15:08:35 +0200	[thread overview]
Message-ID: <20130426130835.GA13964@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1366910611-20048-8-git-send-email-vincent.guittot@linaro.org>

On Thu, Apr 25, 2013 at 07:23:23PM +0200, Vincent Guittot wrote:
> According to the packing policy, the scheduler can pack tasks at different
> step:
> -SCHED_PACKING_NONE level: we don't pack any task.
> -SCHED_PACKING_DEFAULT: we only pack small tasks at wake up when system is not
> busy.
> -SCHED_PACKING_FULL: we pack tasks at wake up until a CPU becomes full. During
> a fork or a exec, we assume that the new task is a full running one and we
> look for an idle CPU close to the buddy CPU.

This changelog is very short on explaining how it will go about achieving these
goals.

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>  kernel/sched/fair.c |   47 ++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 42 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 98166aa..874f330 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3259,13 +3259,16 @@ static struct sched_group *
>  find_idlest_group(struct sched_domain *sd, struct task_struct *p,


So for packing into power domains, wouldn't you typically pick the busiest non-
full domain to fill from other non-full?

Picking the idlest non-full seems like it would generate a ping-pong or not
actually pack anything.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org, mingo@kernel.org,
	linux@arm.linux.org.uk, pjt@google.com, santosh.shilimkar@ti.com,
	Morten.Rasmussen@arm.com, chander.kashyap@linaro.org,
	cmetcalf@tilera.com, tony.luck@intel.com, alex.shi@intel.com,
	preeti@linux.vnet.ibm.com, paulmck@linux.vnet.ibm.com,
	tglx@linutronix.de, len.brown@intel.com, arjan@linux.intel.com,
	amit.kucheria@linaro.org, corbet@lwn.net, l.majewski@samsung.com
Subject: Re: [PATCH 07/14] sched: agressively pack at wake/fork/exec
Date: Fri, 26 Apr 2013 15:08:35 +0200	[thread overview]
Message-ID: <20130426130835.GA13964@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1366910611-20048-8-git-send-email-vincent.guittot@linaro.org>

On Thu, Apr 25, 2013 at 07:23:23PM +0200, Vincent Guittot wrote:
> According to the packing policy, the scheduler can pack tasks at different
> step:
> -SCHED_PACKING_NONE level: we don't pack any task.
> -SCHED_PACKING_DEFAULT: we only pack small tasks at wake up when system is not
> busy.
> -SCHED_PACKING_FULL: we pack tasks at wake up until a CPU becomes full. During
> a fork or a exec, we assume that the new task is a full running one and we
> look for an idle CPU close to the buddy CPU.

This changelog is very short on explaining how it will go about achieving these
goals.

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
>  kernel/sched/fair.c |   47 ++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 42 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 98166aa..874f330 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3259,13 +3259,16 @@ static struct sched_group *
>  find_idlest_group(struct sched_domain *sd, struct task_struct *p,


So for packing into power domains, wouldn't you typically pick the busiest non-
full domain to fill from other non-full?

Picking the idlest non-full seems like it would generate a ping-pong or not
actually pack anything.

  reply	other threads:[~2013-04-26 13:08 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 17:23 [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-25 17:23 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 01/14] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 02/14] sched: add a new SD_SHARE_POWERDOMAIN flag for sched_domain Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 03/14] sched: pack small tasks Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:30   ` Peter Zijlstra
2013-04-26 12:30     ` Peter Zijlstra
2013-04-26 13:16     ` Vincent Guittot
2013-04-26 13:16       ` Vincent Guittot
2013-04-26 12:38   ` Peter Zijlstra
2013-04-26 12:38     ` Peter Zijlstra
2013-04-26 13:38     ` Vincent Guittot
2013-04-26 13:38       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 04/14] sched: pack the idle load balance Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:49   ` Peter Zijlstra
2013-04-26 12:49     ` Peter Zijlstra
2013-04-26 13:47     ` Vincent Guittot
2013-04-26 13:47       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 05/14] ARM: sched: clear SD_SHARE_POWERDOMAIN Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 06/14] sched: add a knob to choose the packing level Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 07/14] sched: agressively pack at wake/fork/exec Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 13:08   ` Peter Zijlstra [this message]
2013-04-26 13:08     ` Peter Zijlstra
2013-04-26 14:23     ` Vincent Guittot
2013-04-26 14:23       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 08/14] sched: trig ILB on an idle buddy Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 13:15   ` Peter Zijlstra
2013-04-26 13:15     ` Peter Zijlstra
2013-04-26 14:52     ` Vincent Guittot
2013-04-26 14:52       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 09/14] sched: evaluate the activity level of the system Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-05-22 16:50   ` Morten Rasmussen
2013-05-23  8:11     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 10/14] sched: update the buddy CPU Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-28  8:20   ` Francesco Lavra
2013-04-28  8:20     ` Francesco Lavra
2013-04-29  7:32     ` Vincent Guittot
2013-04-29  7:32       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 11/14] sched: filter task pull request Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 10:00   ` Vincent Guittot
2013-04-26 10:00     ` Vincent Guittot
2013-05-22 15:56     ` Morten Rasmussen
2013-05-22 15:56       ` Morten Rasmussen
2013-05-22 16:03       ` Vincent Guittot
2013-05-22 16:03         ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 12/14] sched: create a new field with available capacity Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 13/14] sched: update the cpu_power Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-05-22 15:46   ` Morten Rasmussen
2013-05-22 15:58     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 14/14] sched: force migration on buddy CPU Vincent Guittot
2013-04-25 17:23   ` Vincent Guittot
2013-04-26 12:08 ` [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-26 12:08   ` Vincent Guittot
2013-04-26 15:00 ` Arjan van de Ven
2013-04-26 15:00   ` Arjan van de Ven
2013-04-26 15:40   ` Vincent Guittot
2013-04-26 15:40     ` Vincent Guittot
2013-04-26 15:46     ` Arjan van de Ven
2013-04-26 15:46       ` Arjan van de Ven
2013-04-26 15:56       ` Vincent Guittot
2013-04-26 15:56         ` Vincent Guittot
2013-05-02  9:12       ` Vincent Guittot
2013-05-02  9:12         ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426130835.GA13964@dyad.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.