* [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs @ 2013-05-06 21:30 Franklin S. Cooper Jr 2013-05-06 21:31 ` Denys Dmytriyenko 0 siblings, 1 reply; 8+ messages in thread From: Franklin S. Cooper Jr @ 2013-05-06 21:30 UTC (permalink / raw) To: meta-arago; +Cc: Franklin S. Cooper Jr * Linaro toolchain does not support ARM9 architecture. * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> --- meta-arago-distro/conf/distro/arago.conf | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf index 3954360..048c480 100644 --- a/meta-arago-distro/conf/distro/arago.conf +++ b/meta-arago-distro/conf/distro/arago.conf @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbh # Toolchain should be selected by setting TOOLCHAIN_BRAND in local.conf # Set some sane defaults, in case someone forgets to set them in local.conf -TOOLCHAIN_BRAND ?= "linaro" +# ARM9 is not supported by the Linaro toolchain so default back to the Arago +# toolchain for ARM9 based SOCs. +TOOLCHAIN_BRAND ?= "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" TOOLCHAIN_TYPE ?= "external" require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}-${TOOLCHAIN_BRAND}.inc -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 21:30 [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs Franklin S. Cooper Jr @ 2013-05-06 21:31 ` Denys Dmytriyenko 2013-05-06 21:56 ` Cooper Jr., Franklin 0 siblings, 1 reply; 8+ messages in thread From: Denys Dmytriyenko @ 2013-05-06 21:31 UTC (permalink / raw) To: Franklin S. Cooper Jr; +Cc: meta-arago On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > * Linaro toolchain does not support ARM9 architecture. > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > --- > meta-arago-distro/conf/distro/arago.conf | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf > index 3954360..048c480 100644 > --- a/meta-arago-distro/conf/distro/arago.conf > +++ b/meta-arago-distro/conf/distro/arago.conf > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda largefile pcmcia usbgadget usbh > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in local.conf > # Set some sane defaults, in case someone forgets to set them in local.conf > -TOOLCHAIN_BRAND ?= "linaro" > +# ARM9 is not supported by the Linaro toolchain so default back to the Arago > +# toolchain for ARM9 based SOCs. > +TOOLCHAIN_BRAND ?= "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" I don't feel this belongs in the arago.conf - as the comment above says, this is supposed to be set in the local.conf anyways, here it just offers a default fall back... -- Denys > TOOLCHAIN_TYPE ?= "external" > > require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}-${TOOLCHAIN_BRAND}.inc > -- > 1.7.0.4 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 21:31 ` Denys Dmytriyenko @ 2013-05-06 21:56 ` Cooper Jr., Franklin 2013-05-06 22:30 ` Denys Dmytriyenko 0 siblings, 1 reply; 8+ messages in thread From: Cooper Jr., Franklin @ 2013-05-06 21:56 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Monday, May 06, 2013 4:32 PM > To: Cooper Jr., Franklin > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > ARM9 SOCs > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > > * Linaro toolchain does not support ARM9 architecture. > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > > --- > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > b/meta-arago-distro/conf/distro/arago.conf > > index 3954360..048c480 100644 > > --- a/meta-arago-distro/conf/distro/arago.conf > > +++ b/meta-arago-distro/conf/distro/arago.conf > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda > > largefile pcmcia usbgadget usbh > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > local.conf # Set some sane defaults, in case someone forgets to set > > them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > +# ARM9 is not supported by the Linaro toolchain so default back to > > +the Arago # toolchain for ARM9 based SOCs. > > +TOOLCHAIN_BRAND ?= > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > I don't feel this belongs in the arago.conf - as the comment above says, this is > supposed to be set in the local.conf anyways, here it just offers a default fall > back... I don't see what harm is done by tweaking the variable to insure an optimal and safe default fall back is provided for all platforms we support. This patch changes nothing except fixes a broken use case. > > -- > Denys > > > > TOOLCHAIN_TYPE ?= "external" > > > > require conf/distro/include/toolchain-${TOOLCHAIN_TYPE}- > ${TOOLCHAIN_BRAND}.inc > > -- > > 1.7.0.4 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 21:56 ` Cooper Jr., Franklin @ 2013-05-06 22:30 ` Denys Dmytriyenko 2013-05-06 23:03 ` Cooper Jr., Franklin 0 siblings, 1 reply; 8+ messages in thread From: Denys Dmytriyenko @ 2013-05-06 22:30 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, May 06, 2013 4:32 PM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > > ARM9 SOCs > > > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > > > * Linaro toolchain does not support ARM9 architecture. > > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > > > --- > > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > b/meta-arago-distro/conf/distro/arago.conf > > > index 3954360..048c480 100644 > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda > > > largefile pcmcia usbgadget usbh > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > local.conf # Set some sane defaults, in case someone forgets to set > > > them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > +# ARM9 is not supported by the Linaro toolchain so default back to > > > +the Arago # toolchain for ARM9 based SOCs. > > > +TOOLCHAIN_BRAND ?= > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > I don't feel this belongs in the arago.conf - as the comment above says, this is > > supposed to be set in the local.conf anyways, here it just offers a default fall > > back... > > I don't see what harm is done by tweaking the variable to insure an optimal > and safe default fall back is provided for all platforms we support. This > patch changes nothing except fixes a broken use case. Overhead - it calls that Python function every time you evaluate TOOLCHAIN_BRAND variable... I might be more lenient with something like this though: TC_SANEDEFAULT := "${@...}" TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" Although, that would no longer work in local.conf, only arago.conf... -- Denys ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 22:30 ` Denys Dmytriyenko @ 2013-05-06 23:03 ` Cooper Jr., Franklin 2013-05-06 23:05 ` Denys Dmytriyenko 0 siblings, 1 reply; 8+ messages in thread From: Cooper Jr., Franklin @ 2013-05-06 23:03 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Monday, May 06, 2013 5:31 PM > To: Cooper Jr., Franklin > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > ARM9 SOCs > > On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote: > > > > > > > -----Original Message----- > > > From: Dmytriyenko, Denys > > > Sent: Monday, May 06, 2013 4:32 PM > > > To: Cooper Jr., Franklin > > > Cc: meta-arago@arago-project.org > > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct > > > TOOLCHAIN_BRAND for > > > ARM9 SOCs > > > > > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > > > > * Linaro toolchain does not support ARM9 architecture. > > > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > > > > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > > > > --- > > > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > > b/meta-arago-distro/conf/distro/arago.conf > > > > index 3954360..048c480 100644 > > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda > > > > largefile pcmcia usbgadget usbh > > > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > > local.conf # Set some sane defaults, in case someone forgets to > > > > set them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > > +# ARM9 is not supported by the Linaro toolchain so default back > > > > +to the Arago # toolchain for ARM9 based SOCs. > > > > +TOOLCHAIN_BRAND ?= > > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > > > I don't feel this belongs in the arago.conf - as the comment above > > > says, this is supposed to be set in the local.conf anyways, here it > > > just offers a default fall back... > > > > I don't see what harm is done by tweaking the variable to insure an > > optimal and safe default fall back is provided for all platforms we > > support. This patch changes nothing except fixes a broken use case. > > Overhead - it calls that Python function every time you evaluate > TOOLCHAIN_BRAND variable... > > I might be more lenient with something like this though: > > TC_SANEDEFAULT := "${@...}" > TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" > > Although, that would no longer work in local.conf, only arago.conf... If you have no objection with me putting my suggested change to TOOLCHAIN_BRAND in oe-layersetup local.conf.sample then I am fine with dropping this patch. > > -- > Denys ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 23:03 ` Cooper Jr., Franklin @ 2013-05-06 23:05 ` Denys Dmytriyenko 2013-05-07 0:07 ` Cooper Jr., Franklin 0 siblings, 1 reply; 8+ messages in thread From: Denys Dmytriyenko @ 2013-05-06 23:05 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Mon, May 06, 2013 at 07:03:15PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, May 06, 2013 5:31 PM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > > ARM9 SOCs > > > > On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote: > > > > > > > > > > -----Original Message----- > > > > From: Dmytriyenko, Denys > > > > Sent: Monday, May 06, 2013 4:32 PM > > > > To: Cooper Jr., Franklin > > > > Cc: meta-arago@arago-project.org > > > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct > > > > TOOLCHAIN_BRAND for > > > > ARM9 SOCs > > > > > > > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote: > > > > > * Linaro toolchain does not support ARM9 architecture. > > > > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > > > > > > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > > > > > --- > > > > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > > > b/meta-arago-distro/conf/distro/arago.conf > > > > > index 3954360..048c480 100644 > > > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda > > > > > largefile pcmcia usbgadget usbh > > > > > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > > > local.conf # Set some sane defaults, in case someone forgets to > > > > > set them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > > > +# ARM9 is not supported by the Linaro toolchain so default back > > > > > +to the Arago # toolchain for ARM9 based SOCs. > > > > > +TOOLCHAIN_BRAND ?= > > > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > > > > > I don't feel this belongs in the arago.conf - as the comment above > > > > says, this is supposed to be set in the local.conf anyways, here it > > > > just offers a default fall back... > > > > > > I don't see what harm is done by tweaking the variable to insure an > > > optimal and safe default fall back is provided for all platforms we > > > support. This patch changes nothing except fixes a broken use case. > > > > Overhead - it calls that Python function every time you evaluate > > TOOLCHAIN_BRAND variable... > > > > I might be more lenient with something like this though: > > > > TC_SANEDEFAULT := "${@...}" > > TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" > > > > Although, that would no longer work in local.conf, only arago.conf... > > If you have no objection with me putting my suggested change to > TOOLCHAIN_BRAND in oe-layersetup local.conf.sample then I am fine with > dropping this patch. Either way is fine. You didn't like to split it in 2 lines like above? -- Denys ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-06 23:05 ` Denys Dmytriyenko @ 2013-05-07 0:07 ` Cooper Jr., Franklin 2013-05-07 3:08 ` Denys Dmytriyenko 0 siblings, 1 reply; 8+ messages in thread From: Cooper Jr., Franklin @ 2013-05-07 0:07 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Monday, May 06, 2013 6:06 PM > To: Cooper Jr., Franklin > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for > ARM9 SOCs > > On Mon, May 06, 2013 at 07:03:15PM -0400, Cooper Jr., Franklin wrote: > > > > > > > -----Original Message----- > > > From: Dmytriyenko, Denys > > > Sent: Monday, May 06, 2013 5:31 PM > > > To: Cooper Jr., Franklin > > > Cc: meta-arago@arago-project.org > > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct > > > TOOLCHAIN_BRAND for > > > ARM9 SOCs > > > > > > On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Dmytriyenko, Denys > > > > > Sent: Monday, May 06, 2013 4:32 PM > > > > > To: Cooper Jr., Franklin > > > > > Cc: meta-arago@arago-project.org > > > > > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct > > > > > TOOLCHAIN_BRAND for > > > > > ARM9 SOCs > > > > > > > > > > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr > wrote: > > > > > > * Linaro toolchain does not support ARM9 architecture. > > > > > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built. > > > > > > > > > > > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com> > > > > > > --- > > > > > > meta-arago-distro/conf/distro/arago.conf | 4 +++- > > > > > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > > > > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > > > > b/meta-arago-distro/conf/distro/arago.conf > > > > > > index 3954360..048c480 100644 > > > > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 > > > > > > irda largefile pcmcia usbgadget usbh > > > > > > > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > > > > local.conf # Set some sane defaults, in case someone forgets > > > > > > to set them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > > > > +# ARM9 is not supported by the Linaro toolchain so default > > > > > > +back to the Arago # toolchain for ARM9 based SOCs. > > > > > > +TOOLCHAIN_BRAND ?= > > > > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > > > > > > > I don't feel this belongs in the arago.conf - as the comment > > > > > above says, this is supposed to be set in the local.conf > > > > > anyways, here it just offers a default fall back... > > > > > > > > I don't see what harm is done by tweaking the variable to insure > > > > an optimal and safe default fall back is provided for all > > > > platforms we support. This patch changes nothing except fixes a broken > use case. > > > > > > Overhead - it calls that Python function every time you evaluate > > > TOOLCHAIN_BRAND variable... > > > > > > I might be more lenient with something like this though: > > > > > > TC_SANEDEFAULT := "${@...}" > > > TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" > > > > > > Although, that would no longer work in local.conf, only arago.conf... > > > > If you have no objection with me putting my suggested change to > > TOOLCHAIN_BRAND in oe-layersetup local.conf.sample then I am fine with > > dropping this patch. > > Either way is fine. You didn't like to split it in 2 lines like above? I did like your suggestion but I was confused by the statement "Although, that would no longer work in local.conf, only arago.conf...". TOOLCHAIN_BRAND could still be overridden in local.conf but TC_SANEDEFAULT couldn't. Is that really a problem since originally the expectation was that someone should be overriding TOOLCHAIN_BRAND anyway? If your fine with the below then I'll send a v2 TC_SANEDEFAULT := "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" > > -- > Denys ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs 2013-05-07 0:07 ` Cooper Jr., Franklin @ 2013-05-07 3:08 ` Denys Dmytriyenko 0 siblings, 0 replies; 8+ messages in thread From: Denys Dmytriyenko @ 2013-05-07 3:08 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Mon, May 06, 2013 at 08:07:19PM -0400, Cooper Jr., Franklin wrote: > > > > > > > diff --git a/meta-arago-distro/conf/distro/arago.conf > > > > > > > b/meta-arago-distro/conf/distro/arago.conf > > > > > > > index 3954360..048c480 100644 > > > > > > > --- a/meta-arago-distro/conf/distro/arago.conf > > > > > > > +++ b/meta-arago-distro/conf/distro/arago.conf > > > > > > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 > > > > > > > irda largefile pcmcia usbgadget usbh > > > > > > > > > > > > > > # Toolchain should be selected by setting TOOLCHAIN_BRAND in > > > > > > > local.conf # Set some sane defaults, in case someone forgets > > > > > > > to set them in local.conf -TOOLCHAIN_BRAND ?= "linaro" > > > > > > > +# ARM9 is not supported by the Linaro toolchain so default > > > > > > > +back to the Arago # toolchain for ARM9 based SOCs. > > > > > > > +TOOLCHAIN_BRAND ?= > > > > > > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > > > > > > > > > > > > I don't feel this belongs in the arago.conf - as the comment > > > > > > above says, this is supposed to be set in the local.conf > > > > > > anyways, here it just offers a default fall back... > > > > > > > > > > I don't see what harm is done by tweaking the variable to insure > > > > > an optimal and safe default fall back is provided for all > > > > > platforms we support. This patch changes nothing except fixes a broken > > use case. > > > > > > > > Overhead - it calls that Python function every time you evaluate > > > > TOOLCHAIN_BRAND variable... > > > > > > > > I might be more lenient with something like this though: > > > > > > > > TC_SANEDEFAULT := "${@...}" > > > > TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" > > > > > > > > Although, that would no longer work in local.conf, only arago.conf... > > > > > > If you have no objection with me putting my suggested change to > > > TOOLCHAIN_BRAND in oe-layersetup local.conf.sample then I am fine with > > > dropping this patch. > > > > Either way is fine. You didn't like to split it in 2 lines like above? > > I did like your suggestion but I was confused by the statement "Although, > that would no longer work in local.conf, only arago.conf...". > TOOLCHAIN_BRAND could still be overridden in local.conf but TC_SANEDEFAULT > couldn't. Is that really a problem since originally the expectation was that > someone should be overriding TOOLCHAIN_BRAND anyway? Correct - I meant setting TC_SANEDEFAULT like that (immediate assignment with Python code) won't work in local.conf. Which is fine, as TOOLCHAIN_BRAND can be overriden from local.conf anyway. > If your fine with the below then I'll send a v2 > TC_SANEDEFAULT := "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}" > TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}" Yes, please. -- Denys ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-05-07 3:08 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-06 21:30 [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs Franklin S. Cooper Jr 2013-05-06 21:31 ` Denys Dmytriyenko 2013-05-06 21:56 ` Cooper Jr., Franklin 2013-05-06 22:30 ` Denys Dmytriyenko 2013-05-06 23:03 ` Cooper Jr., Franklin 2013-05-06 23:05 ` Denys Dmytriyenko 2013-05-07 0:07 ` Cooper Jr., Franklin 2013-05-07 3:08 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.