All of lore.kernel.org
 help / color / mirror / Atom feed
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/14] bus: mvebu-mbus: Add static window allocation to the DT binding
Date: Sun, 9 Jun 2013 11:34:24 -0300	[thread overview]
Message-ID: <20130609143422.GA2353@localhost> (raw)
In-Reply-To: <1695243.lt6nZouziV@wuerfel>

On Sun, Jun 09, 2013 at 03:42:24PM +0200, Arnd Bergmann wrote:
> On Saturday 08 June 2013 15:38:52 Ezequiel Garcia wrote:
> > On Fri, Jun 07, 2013 at 02:00:54PM -0600, Jason Gunthorpe wrote:
> 
> > Right. I think we have two options here for laying the DT ranges.
> > 
> > 1) This is the proposal implied in the patchset I sent:
> > 
> > mbus {
> > 	ranges = < we only put the internal-reg translation here>
> > 	devbus-bootcs {
> > 		ranges = <0 {target_id/attribute} {window_physical_base} {size}>
> > 	}
> > }
> 
> As Jason explained, you cannot have the window_physical_base in the child
> device, that just wouldn't work. I don't know if that's a typo or a thinko ;-)
> 

I'm not sure what you mean by "that just wouldn't work". I understand it
may be a crappy DT layout, but it definitely works.

The proposal I've sent in this patchset has been fully tested and works
in A370 and AXP, with NOR, and PCIe devices. 
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Maen Suleiman <maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 04/14] bus: mvebu-mbus: Add static window allocation to the DT binding
Date: Sun, 9 Jun 2013 11:34:24 -0300	[thread overview]
Message-ID: <20130609143422.GA2353@localhost> (raw)
In-Reply-To: <1695243.lt6nZouziV@wuerfel>

On Sun, Jun 09, 2013 at 03:42:24PM +0200, Arnd Bergmann wrote:
> On Saturday 08 June 2013 15:38:52 Ezequiel Garcia wrote:
> > On Fri, Jun 07, 2013 at 02:00:54PM -0600, Jason Gunthorpe wrote:
> 
> > Right. I think we have two options here for laying the DT ranges.
> > 
> > 1) This is the proposal implied in the patchset I sent:
> > 
> > mbus {
> > 	ranges = < we only put the internal-reg translation here>
> > 	devbus-bootcs {
> > 		ranges = <0 {target_id/attribute} {window_physical_base} {size}>
> > 	}
> > }
> 
> As Jason explained, you cannot have the window_physical_base in the child
> device, that just wouldn't work. I don't know if that's a typo or a thinko ;-)
> 

I'm not sure what you mean by "that just wouldn't work". I understand it
may be a crappy DT layout, but it definitely works.

The proposal I've sent in this patchset has been fully tested and works
in A370 and AXP, with NOR, and PCIe devices. 
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

  reply	other threads:[~2013-06-09 14:34 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 16:47 [PATCH 00/14] MBus device tree binding Ezequiel Garcia
2013-06-07 16:47 ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 01/14] bus: mvebu-mbus: Use pr_fmt Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:56   ` Thomas Petazzoni
2013-06-07 16:56     ` Thomas Petazzoni
2013-06-08 14:15   ` Jason Cooper
2013-06-08 14:15     ` Jason Cooper
2013-06-07 16:47 ` [PATCH 02/14] bus: mvebu-mbus: Factor out initialization details Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 03/14] bus: mvebu-mbus: Introduce device tree binding Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 19:10   ` Arnd Bergmann
2013-06-07 19:10     ` Arnd Bergmann
2013-06-07 19:44     ` Jason Gunthorpe
2013-06-07 19:44       ` Jason Gunthorpe
2013-06-07 19:53       ` Arnd Bergmann
2013-06-07 19:53         ` Arnd Bergmann
2013-06-07 20:09         ` Jason Gunthorpe
2013-06-07 20:09           ` Jason Gunthorpe
2013-06-07 21:15           ` Arnd Bergmann
2013-06-07 21:15             ` Arnd Bergmann
2013-06-08  0:26             ` Jason Gunthorpe
2013-06-08  0:26               ` Jason Gunthorpe
2013-06-08 17:29       ` Ezequiel Garcia
2013-06-08 17:29         ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 04/14] bus: mvebu-mbus: Add static window allocation to the DT binding Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 19:01   ` Arnd Bergmann
2013-06-07 19:01     ` Arnd Bergmann
2013-06-07 20:00     ` Jason Gunthorpe
2013-06-07 20:00       ` Jason Gunthorpe
2013-06-07 21:07       ` Arnd Bergmann
2013-06-07 21:07         ` Arnd Bergmann
2013-06-08 18:38       ` Ezequiel Garcia
2013-06-08 18:38         ` Ezequiel Garcia
2013-06-09  1:45         ` Jason Gunthorpe
2013-06-09  1:45           ` Jason Gunthorpe
2013-06-09 14:39           ` Ezequiel Garcia
2013-06-09 14:39             ` Ezequiel Garcia
2013-06-11 13:57           ` Ezequiel Garcia
2013-06-11 13:57             ` Ezequiel Garcia
2013-06-11 15:26             ` Arnd Bergmann
2013-06-11 15:26               ` Arnd Bergmann
2013-06-11 21:50               ` Jason Gunthorpe
2013-06-11 21:50                 ` Jason Gunthorpe
2013-06-11 22:22                 ` Sebastian Hesselbarth
2013-06-11 22:22                   ` Sebastian Hesselbarth
2013-06-11 23:02                   ` Arnd Bergmann
2013-06-11 23:02                     ` Arnd Bergmann
2013-06-11 23:08                   ` Jason Gunthorpe
2013-06-11 23:08                     ` Jason Gunthorpe
2013-06-12  7:37                     ` Sebastian Hesselbarth
2013-06-12  7:37                       ` Sebastian Hesselbarth
2013-06-11 22:34                 ` Arnd Bergmann
2013-06-11 22:34                   ` Arnd Bergmann
2013-06-11 22:58                   ` Jason Gunthorpe
2013-06-11 22:58                     ` Jason Gunthorpe
2013-06-11 23:10                     ` Arnd Bergmann
2013-06-11 23:10                       ` Arnd Bergmann
2013-06-12 11:14                   ` Grant Likely
2013-06-12 11:14                     ` Grant Likely
2013-06-12 20:45                     ` Arnd Bergmann
2013-06-12 20:45                       ` Arnd Bergmann
2013-06-12 21:12                       ` Ezequiel Garcia
2013-06-12 21:12                         ` Ezequiel Garcia
2013-06-12 21:26                         ` Jason Gunthorpe
2013-06-12 21:26                           ` Jason Gunthorpe
2013-06-12 21:36                           ` Ezequiel Garcia
2013-06-12 21:36                             ` Ezequiel Garcia
2013-06-12 21:52                             ` Arnd Bergmann
2013-06-12 21:52                               ` Arnd Bergmann
2013-06-12 22:02                               ` Jason Gunthorpe
2013-06-12 22:02                                 ` Jason Gunthorpe
2013-06-12 22:20                                 ` Arnd Bergmann
2013-06-12 22:20                                   ` Arnd Bergmann
2013-06-12 22:24                                   ` Arnd Bergmann
2013-06-12 22:24                                     ` Arnd Bergmann
2013-06-15 16:03                           ` Grant Likely
2013-06-15 16:03                             ` Grant Likely
2013-06-12 20:02                 ` Ezequiel Garcia
2013-06-12 20:02                   ` Ezequiel Garcia
2013-06-12 20:12                   ` Jason Gunthorpe
2013-06-12 20:12                     ` Jason Gunthorpe
2013-06-12 21:50                   ` Arnd Bergmann
2013-06-12 21:50                     ` Arnd Bergmann
2013-06-12 11:07               ` Grant Likely
2013-06-12 11:07                 ` Grant Likely
2013-06-12 11:43                 ` Arnd Bergmann
2013-06-12 11:43                   ` Arnd Bergmann
2013-06-12 11:54                   ` Grant Likely
2013-06-12 11:54                     ` Grant Likely
2013-06-12 11:58                     ` Arnd Bergmann
2013-06-12 11:58                       ` Arnd Bergmann
2013-06-12 10:52           ` Grant Likely
2013-06-12 10:52             ` Grant Likely
2013-06-09 13:42         ` Arnd Bergmann
2013-06-09 13:42           ` Arnd Bergmann
2013-06-09 14:34           ` Ezequiel Garcia [this message]
2013-06-09 14:34             ` Ezequiel Garcia
2013-06-09 15:37             ` Arnd Bergmann
2013-06-09 15:37               ` Arnd Bergmann
2013-06-12 10:48         ` Grant Likely
2013-06-12 10:48           ` Grant Likely
2013-06-11 13:31     ` Ezequiel Garcia
2013-06-11 13:31       ` Ezequiel Garcia
2013-06-11 15:02       ` Arnd Bergmann
2013-06-11 15:02         ` Arnd Bergmann
2013-06-07 16:47 ` [PATCH 05/14] bus: mvebu-mbus: Update the mbus-compatible node's ranges property Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-12 10:25   ` Grant Likely
2013-06-12 10:25     ` Grant Likely
2013-06-07 16:47 ` [PATCH 06/14] ARM: mvebu: Initialize MBus using the DT binding Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 07/14] ARM: mvebu: Remove the harcoded BootROM window allocation Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 08/14] memory: mvebu-devbus: Remove address decoding window workaround Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 09/14] ARM: mvebu: Add MBus to Armada 370/XP device tree Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 10/14] ARM: mvebu: Add BootROM " Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 11/14] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 19:18   ` Arnd Bergmann
2013-06-07 19:18     ` Arnd Bergmann
2013-06-07 16:47 ` [PATCH 12/14] ARM: mvebu: Remove device tree unused properties on A370 Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:56   ` Thomas Petazzoni
2013-06-07 16:56     ` Thomas Petazzoni
2013-06-08 14:18   ` Jason Cooper
2013-06-08 14:18     ` Jason Cooper
2013-06-07 16:47 ` [PATCH 13/14] ARM: mvebu: Relocate Armada 370 PCIe device tree nodes Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia
2013-06-07 16:47 ` [PATCH 14/14] ARM: mvebu: Relocate Armada XP " Ezequiel Garcia
2013-06-07 16:47   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130609143422.GA2353@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.