From: Guenter Roeck <linux@roeck-us.net>
To: Tang Yuantian-B29983 <B29983@freescale.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor
Date: Thu, 20 Jun 2013 02:40:18 +0000 [thread overview]
Message-ID: <20130620024018.GA835@roeck-us.net> (raw)
In-Reply-To: <D07C73A334FF604B95B3CBD2A545D07B0B20DC69@039-SN2MPN1-011.039d.mgd.msft.net>
T24gVGh1LCBKdW4gMjAsIDIwMTMgYXQgMDI6Mjc6MThBTSArMDAwMCwgVGFuZyBZdWFudGlhbi1C
Mjk5ODMgd3JvdGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJv
bTogR3VlbnRlciBSb2VjayBbbWFpbHRvOmxpbnV4QHJvZWNrLXVzLm5ldF0KPiA+IFNlbnQ6IDIw
MTPlubQ25pyIMTnml6Ug5pif5pyf5LiJIDIzOjQzCj4gPiBUbzogVGFuZyBZdWFudGlhbi1CMjk5
ODMKPiA+IENjOiBraGFsaUBsaW51eC1mci5vcmc7IGxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmc7
IGRldmljZXRyZWUtCj4gPiBkaXNjdXNzQGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWRvY0B2Z2Vy
Lmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGh3bW9uOiAoaW5hMnh4KSBB
ZGQgZGV2aWNlIHRyZWUgc3VwcG9ydCB0byBwYXNzCj4gPiB0aGUgc2h1bnQgcmVzaXN0b3IKPiA+
IAo+ID4gT24gV2VkLCBKdW4gMTksIDIwMTMgYXQgMDI6NTA6MjBQTSArMDgwMCwgWXVhbnRpYW4u
VGFuZ0BmcmVlc2NhbGUuY29tCj4gPiB3cm90ZToKPiA+ID4gRnJvbTogVGFuZyBZdWFudGlhbiA8
eXVhbnRpYW4udGFuZ0BmcmVlc2NhbGUuY29tPgo+ID4gPgo+ID4gPiBBZGRpbmcgYW5vdGhlciB3
YXkgdGhhdCBpcyBkZXZpY2UgdHJlZSB0byBwYXNzIHRoZSBzaHVudCByZXNpc3Rvcgo+ID4gPiB2
YWx1ZSB0byBkcml2ZXIgZXhjZXB0IGZvciBwbGF0Zm9ybSBkYXRhLgo+ID4gPgo+ID4gPiBTaWdu
ZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxZdWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+Cj4g
PiAKPiA+IEkgbm90aWNlZCB0aGF0IG9mLmggaW5jbHVkZSB3YXMgbWlzc2luZy4gTm8gbmVlZCB0
byByZS1zZW5kOyBJIGFkZGVkIGl0Cj4gPiBteXNlbGYuCj4gPiBBcHBsaWVkIHRvIC1uZXh0Lgo+
ID4gCj4gCj4gVGhhbmtzIGZvciB5b3VyIGhlbHAuIE9mLmggaXMgYWxyZWFkeSBpbmNsdWRlZCBp
biBpMmMuaC4KPiBJZiBpdCBpcyByZWFsbHkgbmVlZGVkLCBJIHNob3VsZCBoYXZlIHNlZW4gdGhl
IHdhcm5pbmcgb3IgZXJyb3Igd2hlbiBjb21waWxlLgo+IEluY2x1ZGluZyBpdCBleHBsaWNpdGx5
IGlzIGFsc28gYSBnb29kIHBvaW50Lgo+IApDb21tb24gcnVsZSBpcyB0byBpbmNsdWRlIGEgZmls
ZSBpZiBpdHMgZGVmaW5pdGlvbnMgYXJlIHVzZWQuIFdlIGNhbiBub3QgcmVseQpvbiBzb21lIG90
aGVyIGZpbGUgaW5jbHVkaW5nIGl0IGZvciB1cywgc2luY2UgaXQgaXMgbm90IGd1YXJhbnRlZWQg
dGhhdCB0aGlzCndpbGwgYWx3YXlzIGJlIHRoZSBjYXNlLgoKVGhhbmtzLApHdWVudGVyCgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1h
aWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5z
b3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Tang Yuantian-B29983 <B29983@freescale.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor
Date: Wed, 19 Jun 2013 19:40:18 -0700 [thread overview]
Message-ID: <20130620024018.GA835@roeck-us.net> (raw)
In-Reply-To: <D07C73A334FF604B95B3CBD2A545D07B0B20DC69@039-SN2MPN1-011.039d.mgd.msft.net>
On Thu, Jun 20, 2013 at 02:27:18AM +0000, Tang Yuantian-B29983 wrote:
>
>
> > -----Original Message-----
> > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > Sent: 2013年6月19日 星期三 23:43
> > To: Tang Yuantian-B29983
> > Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> > discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> > Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass
> > the shunt resistor
> >
> > On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com
> > wrote:
> > > From: Tang Yuantian <yuantian.tang@freescale.com>
> > >
> > > Adding another way that is device tree to pass the shunt resistor
> > > value to driver except for platform data.
> > >
> > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> >
> > I noticed that of.h include was missing. No need to re-send; I added it
> > myself.
> > Applied to -next.
> >
>
> Thanks for your help. Of.h is already included in i2c.h.
> If it is really needed, I should have seen the warning or error when compile.
> Including it explicitly is also a good point.
>
Common rule is to include a file if its definitions are used. We can not rely
on some other file including it for us, since it is not guaranteed that this
will always be the case.
Thanks,
Guenter
next prev parent reply other threads:[~2013-06-20 2:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 6:50 [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor Yuantian.Tang
2013-06-19 6:50 ` Yuantian.Tang
2013-06-19 15:43 ` [lm-sensors] " Guenter Roeck
2013-06-19 15:43 ` Guenter Roeck
2013-06-20 2:27 ` [lm-sensors] " Tang Yuantian-B29983
2013-06-20 2:27 ` Tang Yuantian-B29983
2013-06-20 2:40 ` Guenter Roeck [this message]
2013-06-20 2:40 ` Guenter Roeck
2013-06-20 2:45 ` [lm-sensors] " Tang Yuantian-B29983
2013-06-20 2:45 ` Tang Yuantian-B29983
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620024018.GA835@roeck-us.net \
--to=linux@roeck-us.net \
--cc=B29983@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.