[lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Yuantian.Tang]

From: Tang Yuantian <yuantian.tang@freescale.com>

Adding another way that is device tree to pass the shunt resistor
value to driver except for platform data.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
v2:
	- add device tree bindings file
	- refine the code per Guenter's suggestion

 Documentation/devicetree/bindings/i2c/ina2xx.txt | 22 ++++++++++++++++++++++
 Documentation/hwmon/ina2xx                       |  4 +++-
 drivers/hwmon/ina2xx.c                           |  4 ++++
 3 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/i2c/ina2xx.txt

diff --git a/Documentation/devicetree/bindings/i2c/ina2xx.txt b/Documentation/devicetree/bindings/i2c/ina2xx.txt
new file mode 100644
index 0000000..a2ad85d
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/ina2xx.txt
@@ -0,0 +1,22 @@
+ina2xx properties
+
+Required properties:
+- compatible: Must be one of the following:
+	- "ti,ina219" for ina219
+	- "ti,ina220" for ina220
+	- "ti,ina226" for ina226
+	- "ti,ina230" for ina230
+- reg: I2C address
+
+Optional properties:
+
+- shunt-resistor
+	Shunt resistor value in micro-Ohm
+
+Example:
+
+ina220@44 {
+	compatible = "ti,ina220";
+	reg = <0x44>;
+	shunt-resistor = <1000>;
+};
diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx
index 03444f9..4223c2d 100644
--- a/Documentation/hwmon/ina2xx
+++ b/Documentation/hwmon/ina2xx
@@ -44,4 +44,6 @@ The INA226 monitors both a shunt voltage drop and bus supply voltage.
 The INA230 is a high or low side current shunt and power monitor with an I2C
 interface. The INA230 monitors both a shunt voltage drop and bus supply voltage.
 
-The shunt value in micro-ohms can be set via platform data.
+The shunt value in micro-ohms can be set via platform data or device tree.
+Please refer to the Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings
+if the device tree is used.
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index 4958b2f..a52d5f0 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -221,6 +221,7 @@ static int ina2xx_probe(struct i2c_client *client,
 	struct ina2xx_data *data;
 	struct ina2xx_platform_data *pdata;
 	int ret;
+	u32 val;
 	long shunt = 10000; /* default shunt value 10mOhms */
 
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA))
@@ -234,6 +235,9 @@ static int ina2xx_probe(struct i2c_client *client,
 		pdata  		  (struct ina2xx_platform_data *)client->dev.platform_data;
 		shunt = pdata->shunt_uohms;
+	} else if (!of_property_read_u32(client->dev.of_node,
+				"shunt-resistor", &val)) {
+			shunt = val;
 	}
 
 	if (shunt <= 0)
-- 
1.8.0



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Yuantian.Tang]

From: Tang Yuantian <yuantian.tang@freescale.com>

Adding another way that is device tree to pass the shunt resistor
value to driver except for platform data.

Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
v2:
	- add device tree bindings file
	- refine the code per Guenter's suggestion

 Documentation/devicetree/bindings/i2c/ina2xx.txt | 22 ++++++++++++++++++++++
 Documentation/hwmon/ina2xx                       |  4 +++-
 drivers/hwmon/ina2xx.c                           |  4 ++++
 3 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/i2c/ina2xx.txt

diff --git a/Documentation/devicetree/bindings/i2c/ina2xx.txt b/Documentation/devicetree/bindings/i2c/ina2xx.txt
new file mode 100644
index 0000000..a2ad85d
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/ina2xx.txt
@@ -0,0 +1,22 @@
+ina2xx properties
+
+Required properties:
+- compatible: Must be one of the following:
+	- "ti,ina219" for ina219
+	- "ti,ina220" for ina220
+	- "ti,ina226" for ina226
+	- "ti,ina230" for ina230
+- reg: I2C address
+
+Optional properties:
+
+- shunt-resistor
+	Shunt resistor value in micro-Ohm
+
+Example:
+
+ina220@44 {
+	compatible = "ti,ina220";
+	reg = <0x44>;
+	shunt-resistor = <1000>;
+};
diff --git a/Documentation/hwmon/ina2xx b/Documentation/hwmon/ina2xx
index 03444f9..4223c2d 100644
--- a/Documentation/hwmon/ina2xx
+++ b/Documentation/hwmon/ina2xx
@@ -44,4 +44,6 @@ The INA226 monitors both a shunt voltage drop and bus supply voltage.
 The INA230 is a high or low side current shunt and power monitor with an I2C
 interface. The INA230 monitors both a shunt voltage drop and bus supply voltage.
 
-The shunt value in micro-ohms can be set via platform data.
+The shunt value in micro-ohms can be set via platform data or device tree.
+Please refer to the Documentation/devicetree/bindings/i2c/ina2xx.txt for bindings
+if the device tree is used.
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index 4958b2f..a52d5f0 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -221,6 +221,7 @@ static int ina2xx_probe(struct i2c_client *client,
 	struct ina2xx_data *data;
 	struct ina2xx_platform_data *pdata;
 	int ret;
+	u32 val;
 	long shunt = 10000; /* default shunt value 10mOhms */
 
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA))
@@ -234,6 +235,9 @@ static int ina2xx_probe(struct i2c_client *client,
 		pdata =
 		  (struct ina2xx_platform_data *)client->dev.platform_data;
 		shunt = pdata->shunt_uohms;
+	} else if (!of_property_read_u32(client->dev.of_node,
+				"shunt-resistor", &val)) {
+			shunt = val;
 	}
 
 	if (shunt <= 0)
-- 
1.8.0



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Guenter Roeck]

On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com wrote:
> From: Tang Yuantian <yuantian.tang@freescale.com>
> 
> Adding another way that is device tree to pass the shunt resistor
> value to driver except for platform data.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>

I noticed that of.h include was missing. No need to re-send; I added it myself.
Applied to -next.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Guenter Roeck]

On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com wrote:
> From: Tang Yuantian <yuantian.tang@freescale.com>
> 
> Adding another way that is device tree to pass the shunt resistor
> value to driver except for platform data.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>

I noticed that of.h include was missing. No need to re-send; I added it myself.
Applied to -next.

Thanks,
Guenter

Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Tang Yuantian-B29983]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogR3VlbnRlciBSb2VjayBb
bWFpbHRvOmxpbnV4QHJvZWNrLXVzLm5ldF0NCj4gU2VudDogMjAxM8TqNtTCMTnI1SDQx8bayP0g
MjM6NDMNCj4gVG86IFRhbmcgWXVhbnRpYW4tQjI5OTgzDQo+IENjOiBraGFsaUBsaW51eC1mci5v
cmc7IGxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmc7IGRldmljZXRyZWUtDQo+IGRpc2N1c3NAbGlz
dHMub3psYWJzLm9yZzsgbGludXgtZG9jQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0OiBSZTog
W1BBVENIIHYyXSBod21vbjogKGluYTJ4eCkgQWRkIGRldmljZSB0cmVlIHN1cHBvcnQgdG8gcGFz
cw0KPiB0aGUgc2h1bnQgcmVzaXN0b3INCj4gDQo+IE9uIFdlZCwgSnVuIDE5LCAyMDEzIGF0IDAy
OjUwOjIwUE0gKzA4MDAsIFl1YW50aWFuLlRhbmdAZnJlZXNjYWxlLmNvbQ0KPiB3cm90ZToNCj4g
PiBGcm9tOiBUYW5nIFl1YW50aWFuIDx5dWFudGlhbi50YW5nQGZyZWVzY2FsZS5jb20+DQo+ID4N
Cj4gPiBBZGRpbmcgYW5vdGhlciB3YXkgdGhhdCBpcyBkZXZpY2UgdHJlZSB0byBwYXNzIHRoZSBz
aHVudCByZXNpc3Rvcg0KPiA+IHZhbHVlIHRvIGRyaXZlciBleGNlcHQgZm9yIHBsYXRmb3JtIGRh
dGEuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxZdWFudGlhbi5UYW5n
QGZyZWVzY2FsZS5jb20+DQo+IA0KPiBJIG5vdGljZWQgdGhhdCBvZi5oIGluY2x1ZGUgd2FzIG1p
c3NpbmcuIE5vIG5lZWQgdG8gcmUtc2VuZDsgSSBhZGRlZCBpdA0KPiBteXNlbGYuDQo+IEFwcGxp
ZWQgdG8gLW5leHQuDQo+IA0KDQpUaGFua3MgZm9yIHlvdXIgaGVscC4gT2YuaCBpcyBhbHJlYWR5
IGluY2x1ZGVkIGluIGkyYy5oLg0KSWYgaXQgaXMgcmVhbGx5IG5lZWRlZCwgSSBzaG91bGQgaGF2
ZSBzZWVuIHRoZSB3YXJuaW5nIG9yIGVycm9yIHdoZW4gY29tcGlsZS4NCkluY2x1ZGluZyBpdCBl
eHBsaWNpdGx5IGlzIGFsc28gYSBnb29kIHBvaW50Lg0KDQpSZWdhcmRzLA0KWXVhbnRpYW4NCg0K
PiBUaGFua3MsDQo+IEd1ZW50ZXINCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5z
b3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1z
ZW5zb3Jz

RE: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Tang Yuantian-B29983]

> -----Original Message-----
> From: Guenter Roeck [mailto:linux@roeck-us.net]
> Sent: 2013年6月19日 星期三 23:43
> To: Tang Yuantian-B29983
> Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass
> the shunt resistor
> 
> On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com
> wrote:
> > From: Tang Yuantian <yuantian.tang@freescale.com>
> >
> > Adding another way that is device tree to pass the shunt resistor
> > value to driver except for platform data.
> >
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> 
> I noticed that of.h include was missing. No need to re-send; I added it
> myself.
> Applied to -next.
> 

Thanks for your help. Of.h is already included in i2c.h.
If it is really needed, I should have seen the warning or error when compile.
Including it explicitly is also a good point.

Regards,
Yuantian

> Thanks,
> Guenter

Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Guenter Roeck]

T24gVGh1LCBKdW4gMjAsIDIwMTMgYXQgMDI6Mjc6MThBTSArMDAwMCwgVGFuZyBZdWFudGlhbi1C
Mjk5ODMgd3JvdGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJv
bTogR3VlbnRlciBSb2VjayBbbWFpbHRvOmxpbnV4QHJvZWNrLXVzLm5ldF0KPiA+IFNlbnQ6IDIw
MTPlubQ25pyIMTnml6Ug5pif5pyf5LiJIDIzOjQzCj4gPiBUbzogVGFuZyBZdWFudGlhbi1CMjk5
ODMKPiA+IENjOiBraGFsaUBsaW51eC1mci5vcmc7IGxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmc7
IGRldmljZXRyZWUtCj4gPiBkaXNjdXNzQGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWRvY0B2Z2Vy
Lmtlcm5lbC5vcmcKPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGh3bW9uOiAoaW5hMnh4KSBB
ZGQgZGV2aWNlIHRyZWUgc3VwcG9ydCB0byBwYXNzCj4gPiB0aGUgc2h1bnQgcmVzaXN0b3IKPiA+
IAo+ID4gT24gV2VkLCBKdW4gMTksIDIwMTMgYXQgMDI6NTA6MjBQTSArMDgwMCwgWXVhbnRpYW4u
VGFuZ0BmcmVlc2NhbGUuY29tCj4gPiB3cm90ZToKPiA+ID4gRnJvbTogVGFuZyBZdWFudGlhbiA8
eXVhbnRpYW4udGFuZ0BmcmVlc2NhbGUuY29tPgo+ID4gPgo+ID4gPiBBZGRpbmcgYW5vdGhlciB3
YXkgdGhhdCBpcyBkZXZpY2UgdHJlZSB0byBwYXNzIHRoZSBzaHVudCByZXNpc3Rvcgo+ID4gPiB2
YWx1ZSB0byBkcml2ZXIgZXhjZXB0IGZvciBwbGF0Zm9ybSBkYXRhLgo+ID4gPgo+ID4gPiBTaWdu
ZWQtb2ZmLWJ5OiBUYW5nIFl1YW50aWFuIDxZdWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+Cj4g
PiAKPiA+IEkgbm90aWNlZCB0aGF0IG9mLmggaW5jbHVkZSB3YXMgbWlzc2luZy4gTm8gbmVlZCB0
byByZS1zZW5kOyBJIGFkZGVkIGl0Cj4gPiBteXNlbGYuCj4gPiBBcHBsaWVkIHRvIC1uZXh0Lgo+
ID4gCj4gCj4gVGhhbmtzIGZvciB5b3VyIGhlbHAuIE9mLmggaXMgYWxyZWFkeSBpbmNsdWRlZCBp
biBpMmMuaC4KPiBJZiBpdCBpcyByZWFsbHkgbmVlZGVkLCBJIHNob3VsZCBoYXZlIHNlZW4gdGhl
IHdhcm5pbmcgb3IgZXJyb3Igd2hlbiBjb21waWxlLgo+IEluY2x1ZGluZyBpdCBleHBsaWNpdGx5
IGlzIGFsc28gYSBnb29kIHBvaW50Lgo+IApDb21tb24gcnVsZSBpcyB0byBpbmNsdWRlIGEgZmls
ZSBpZiBpdHMgZGVmaW5pdGlvbnMgYXJlIHVzZWQuIFdlIGNhbiBub3QgcmVseQpvbiBzb21lIG90
aGVyIGZpbGUgaW5jbHVkaW5nIGl0IGZvciB1cywgc2luY2UgaXQgaXMgbm90IGd1YXJhbnRlZWQg
dGhhdCB0aGlzCndpbGwgYWx3YXlzIGJlIHRoZSBjYXNlLgoKVGhhbmtzLApHdWVudGVyCgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1h
aWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5z
b3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Guenter Roeck]

On Thu, Jun 20, 2013 at 02:27:18AM +0000, Tang Yuantian-B29983 wrote:
> 
> 
> > -----Original Message-----
> > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > Sent: 2013年6月19日 星期三 23:43
> > To: Tang Yuantian-B29983
> > Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> > discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> > Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass
> > the shunt resistor
> > 
> > On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com
> > wrote:
> > > From: Tang Yuantian <yuantian.tang@freescale.com>
> > >
> > > Adding another way that is device tree to pass the shunt resistor
> > > value to driver except for platform data.
> > >
> > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > 
> > I noticed that of.h include was missing. No need to re-send; I added it
> > myself.
> > Applied to -next.
> > 
> 
> Thanks for your help. Of.h is already included in i2c.h.
> If it is really needed, I should have seen the warning or error when compile.
> Including it explicitly is also a good point.
> 
Common rule is to include a file if its definitions are used. We can not rely
on some other file including it for us, since it is not guaranteed that this
will always be the case.

Thanks,
Guenter

Re: [lm-sensors] [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Tang Yuantian-B29983]

DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEd1ZW50ZXIgUm9lY2sgW21h
aWx0bzpsaW51eEByb2Vjay11cy5uZXRdDQo+IFNlbnQ6IDIwMTPlubQ25pyIMjDml6Ug5pif5pyf
5ZubIDEwOjQwDQo+IFRvOiBUYW5nIFl1YW50aWFuLUIyOTk4Mw0KPiBDYzoga2hhbGlAbGludXgt
ZnIub3JnOyBsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnOyBkZXZpY2V0cmVlLQ0KPiBkaXNjdXNz
QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDog
UmU6IFtQQVRDSCB2Ml0gaHdtb246IChpbmEyeHgpIEFkZCBkZXZpY2UgdHJlZSBzdXBwb3J0IHRv
IHBhc3MNCj4gdGhlIHNodW50IHJlc2lzdG9yDQo+IA0KPiBPbiBUaHUsIEp1biAyMCwgMjAxMyBh
dCAwMjoyNzoxOEFNICswMDAwLCBUYW5nIFl1YW50aWFuLUIyOTk4MyB3cm90ZToNCj4gPg0KPiA+
DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogR3VlbnRlciBS
b2VjayBbbWFpbHRvOmxpbnV4QHJvZWNrLXVzLm5ldF0NCj4gPiA+IFNlbnQ6IDIwMTPlubQ25pyI
MTnml6Ug5pif5pyf5LiJIDIzOjQzDQo+ID4gPiBUbzogVGFuZyBZdWFudGlhbi1CMjk5ODMNCj4g
PiA+IENjOiBraGFsaUBsaW51eC1mci5vcmc7IGxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmc7IGRl
dmljZXRyZWUtDQo+ID4gPiBkaXNjdXNzQGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWRvY0B2Z2Vy
Lmtlcm5lbC5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjJdIGh3bW9uOiAoaW5hMnh4
KSBBZGQgZGV2aWNlIHRyZWUgc3VwcG9ydCB0bw0KPiA+ID4gcGFzcyB0aGUgc2h1bnQgcmVzaXN0
b3INCj4gPiA+DQo+ID4gPiBPbiBXZWQsIEp1biAxOSwgMjAxMyBhdCAwMjo1MDoyMFBNICswODAw
LA0KPiA+ID4gWXVhbnRpYW4uVGFuZ0BmcmVlc2NhbGUuY29tDQo+ID4gPiB3cm90ZToNCj4gPiA+
ID4gRnJvbTogVGFuZyBZdWFudGlhbiA8eXVhbnRpYW4udGFuZ0BmcmVlc2NhbGUuY29tPg0KPiA+
ID4gPg0KPiA+ID4gPiBBZGRpbmcgYW5vdGhlciB3YXkgdGhhdCBpcyBkZXZpY2UgdHJlZSB0byBw
YXNzIHRoZSBzaHVudCByZXNpc3Rvcg0KPiA+ID4gPiB2YWx1ZSB0byBkcml2ZXIgZXhjZXB0IGZv
ciBwbGF0Zm9ybSBkYXRhLg0KPiA+ID4gPg0KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBUYW5nIFl1
YW50aWFuIDxZdWFudGlhbi5UYW5nQGZyZWVzY2FsZS5jb20+DQo+ID4gPg0KPiA+ID4gSSBub3Rp
Y2VkIHRoYXQgb2YuaCBpbmNsdWRlIHdhcyBtaXNzaW5nLiBObyBuZWVkIHRvIHJlLXNlbmQ7IEkg
YWRkZWQNCj4gPiA+IGl0IG15c2VsZi4NCj4gPiA+IEFwcGxpZWQgdG8gLW5leHQuDQo+ID4gPg0K
PiA+DQo+ID4gVGhhbmtzIGZvciB5b3VyIGhlbHAuIE9mLmggaXMgYWxyZWFkeSBpbmNsdWRlZCBp
biBpMmMuaC4NCj4gPiBJZiBpdCBpcyByZWFsbHkgbmVlZGVkLCBJIHNob3VsZCBoYXZlIHNlZW4g
dGhlIHdhcm5pbmcgb3IgZXJyb3Igd2hlbg0KPiBjb21waWxlLg0KPiA+IEluY2x1ZGluZyBpdCBl
eHBsaWNpdGx5IGlzIGFsc28gYSBnb29kIHBvaW50Lg0KPiA+DQo+IENvbW1vbiBydWxlIGlzIHRv
IGluY2x1ZGUgYSBmaWxlIGlmIGl0cyBkZWZpbml0aW9ucyBhcmUgdXNlZC4gV2UgY2FuIG5vdA0K
PiByZWx5IG9uIHNvbWUgb3RoZXIgZmlsZSBpbmNsdWRpbmcgaXQgZm9yIHVzLCBzaW5jZSBpdCBp
cyBub3QgZ3VhcmFudGVlZA0KPiB0aGF0IHRoaXMgd2lsbCBhbHdheXMgYmUgdGhlIGNhc2UuDQo+
IA0KR29vZCBwb2ludCwgSSB3aWxsIGZvbGxvdyB0aGlzIHJ1bGUuIFRoYW5rcywNCg0KVGhhbmtz
LA0KWXVhbnRpYW4NCg0KPiBUaGFua3MsDQo+IEd1ZW50ZXINCg0KX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0t
c2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1h
bi9saXN0aW5mby9sbS1zZW5zb3Jz

RE: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Tang Yuantian-B29983]

> -----Original Message-----
> From: Guenter Roeck [mailto:linux@roeck-us.net]
> Sent: 2013年6月20日 星期四 10:40
> To: Tang Yuantian-B29983
> Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass
> the shunt resistor
> 
> On Thu, Jun 20, 2013 at 02:27:18AM +0000, Tang Yuantian-B29983 wrote:
> >
> >
> > > -----Original Message-----
> > > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > > Sent: 2013年6月19日 星期三 23:43
> > > To: Tang Yuantian-B29983
> > > Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> > > discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> > > Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to
> > > pass the shunt resistor
> > >
> > > On Wed, Jun 19, 2013 at 02:50:20PM +0800,
> > > Yuantian.Tang@freescale.com
> > > wrote:
> > > > From: Tang Yuantian <yuantian.tang@freescale.com>
> > > >
> > > > Adding another way that is device tree to pass the shunt resistor
> > > > value to driver except for platform data.
> > > >
> > > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > >
> > > I noticed that of.h include was missing. No need to re-send; I added
> > > it myself.
> > > Applied to -next.
> > >
> >
> > Thanks for your help. Of.h is already included in i2c.h.
> > If it is really needed, I should have seen the warning or error when
> compile.
> > Including it explicitly is also a good point.
> >
> Common rule is to include a file if its definitions are used. We can not
> rely on some other file including it for us, since it is not guaranteed
> that this will always be the case.
> 
Good point, I will follow this rule. Thanks,

Thanks,
Yuantian

> Thanks,
> Guenter