From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup
Date: Thu, 20 Jun 2013 17:42:51 +0200 [thread overview]
Message-ID: <20130620154251.GC8219@s25.your-server.de> (raw)
In-Reply-To: <CAOMZO5AaZSAsvNUCOqTuqx7UGCrGH6Cm-Uz9wN3nO1e1XU_usw@mail.gmail.com>
On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote:
> On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
> >> task for the clock devices easier.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> [Markus Pargmann: Add gpio clocks]
> >> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> >> ---
> >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> >> index 0695264..48c263c 100644
> >> --- a/arch/arm/boot/dts/imx27.dtsi
> >> +++ b/arch/arm/boot/dts/imx27.dtsi
> >> @@ -208,6 +208,8 @@
> >> #gpio-cells = <2>;
> >> interrupt-controller;
> >> #interrupt-cells = <2>;
> >> + clocks = <&clks 47>;
> >> + clock-names = "ipg";
> >
> > Clock is not used in the gpio driver, so I doubt the usefulness of this patch.
>
> I think you meant "this hunk", right?
>
> My original patch did not have this part. It was added by Markus as
> mentioned in the commit log, and I agree we should go with the
> original version that did not add the gpio clock.
I somehow missed that your patch was applied in march. gpio clocks are
not mentioned in the binding documentation, so I drop this one
completely.
Thanks,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup
Date: Thu, 20 Jun 2013 17:42:51 +0200 [thread overview]
Message-ID: <20130620154251.GC8219@s25.your-server.de> (raw)
In-Reply-To: <CAOMZO5AaZSAsvNUCOqTuqx7UGCrGH6Cm-Uz9wN3nO1e1XU_usw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote:
> On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
> >> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >>
> >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
> >> task for the clock devices easier.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >> [Markus Pargmann: Add gpio clocks]
> >> Signed-off-by: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >> ---
> >> arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> >> index 0695264..48c263c 100644
> >> --- a/arch/arm/boot/dts/imx27.dtsi
> >> +++ b/arch/arm/boot/dts/imx27.dtsi
> >> @@ -208,6 +208,8 @@
> >> #gpio-cells = <2>;
> >> interrupt-controller;
> >> #interrupt-cells = <2>;
> >> + clocks = <&clks 47>;
> >> + clock-names = "ipg";
> >
> > Clock is not used in the gpio driver, so I doubt the usefulness of this patch.
>
> I think you meant "this hunk", right?
>
> My original patch did not have this part. It was added by Markus as
> mentioned in the commit log, and I agree we should go with the
> original version that did not add the gpio clock.
I somehow missed that your patch was applied in march. gpio clocks are
not mentioned in the binding documentation, so I drop this one
completely.
Thanks,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-06-20 15:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 14:50 [PATCH 0/6] ARM: dts: imx27 Phytec PhyCARD-S Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 15:28 ` Alexander Shiyan
2013-06-20 15:28 ` Alexander Shiyan
2013-06-20 15:35 ` Fabio Estevam
2013-06-20 15:35 ` Fabio Estevam
2013-06-20 15:41 ` Fabio Estevam
2013-06-20 15:41 ` Fabio Estevam
2013-06-20 15:42 ` Markus Pargmann [this message]
2013-06-20 15:42 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 2/6] ARM: imx27: Use 'AITC' for the interrupt controller name Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 3/6] ARM: dts: imx27: Add imx framebuffer device Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 4/6] ARM: dts: imx27: Add 1-wire Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 15:17 ` Alexander Shiyan
2013-06-20 15:17 ` Alexander Shiyan
2013-06-20 15:44 ` Markus Pargmann
2013-06-20 15:44 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-21 2:44 ` Shawn Guo
2013-06-21 2:44 ` Shawn Guo
2013-06-21 4:54 ` Re[2]: " Alexander Shiyan
2013-06-21 4:54 ` Alexander Shiyan
2013-06-21 5:23 ` Shawn Guo
2013-06-21 5:23 ` Shawn Guo
2013-06-21 8:47 ` Lorenzo Pieralisi
2013-06-21 8:47 ` Lorenzo Pieralisi
2013-06-23 8:22 ` Markus Pargmann
2013-06-23 8:22 ` Markus Pargmann
2013-06-20 14:50 ` [PATCH 6/6] ARM: dts: Add device tree support for phycard pca100 Markus Pargmann
2013-06-20 14:50 ` Markus Pargmann
2013-06-20 15:15 ` Markus Pargmann
2013-06-20 15:15 ` Markus Pargmann
2013-06-20 15:21 ` Alexander Shiyan
2013-06-20 15:21 ` Alexander Shiyan
2013-06-20 15:45 ` Markus Pargmann
2013-06-20 15:45 ` Markus Pargmann
2013-06-21 3:46 ` Shawn Guo
2013-06-21 3:46 ` Shawn Guo
2013-06-23 8:17 ` Markus Pargmann
2013-06-23 8:17 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620154251.GC8219@s25.your-server.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.