All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton@enomsg.org>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.cz,
	kmpark@infradead.org, hyunhee.kim@samsung.com
Subject: Re: [PATCH v2] vmpressure: implement strict mode
Date: Fri, 28 Jun 2013 11:55:47 -0700	[thread overview]
Message-ID: <20130628185547.GA14520@teo> (raw)
In-Reply-To: <20130628144507.37d28ed9@redhat.com>

On Fri, Jun 28, 2013 at 02:45:07PM -0400, Luiz Capitulino wrote:
> On Fri, 28 Jun 2013 10:09:17 -0700
> Anton Vorontsov <anton@enomsg.org> wrote:
> 
> > So, I would now argue that the current scheme is perfectly OK and can do
> > everything you can do with the "strict" one,
> 
> I forgot commenting this bit. This is not true, because I don't want a
> low fd to be notified on critical level. The current interface just
> can't do that.

Why can't you use poll() and demultiplex the events? Check if there is an
event in the crit fd, and if there is, then just ignore all the rest.

> However, it *is* possible to make non-strict work on strict if we make
> strict default _and_ make reads on memory.pressure_level return
> available events. Just do this on app initialization:
> 
> for each event in memory.pressure_level; do
> 	/* register eventfd to be notified on "event" */
> done

This scheme registers "all" events. Here is more complicated case:

Old kernels, pressure_level reads:

  low, med, crit

The app just wants to listen for med level.

New kernels, pressure_level reads:

  low, FOO, med, BAR, crit

How would application decide which of FOO and BAR are ex-med levels?

Anton

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <anton@enomsg.org>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.cz,
	kmpark@infradead.org, hyunhee.kim@samsung.com
Subject: Re: [PATCH v2] vmpressure: implement strict mode
Date: Fri, 28 Jun 2013 11:55:47 -0700	[thread overview]
Message-ID: <20130628185547.GA14520@teo> (raw)
In-Reply-To: <20130628144507.37d28ed9@redhat.com>

On Fri, Jun 28, 2013 at 02:45:07PM -0400, Luiz Capitulino wrote:
> On Fri, 28 Jun 2013 10:09:17 -0700
> Anton Vorontsov <anton@enomsg.org> wrote:
> 
> > So, I would now argue that the current scheme is perfectly OK and can do
> > everything you can do with the "strict" one,
> 
> I forgot commenting this bit. This is not true, because I don't want a
> low fd to be notified on critical level. The current interface just
> can't do that.

Why can't you use poll() and demultiplex the events? Check if there is an
event in the crit fd, and if there is, then just ignore all the rest.

> However, it *is* possible to make non-strict work on strict if we make
> strict default _and_ make reads on memory.pressure_level return
> available events. Just do this on app initialization:
> 
> for each event in memory.pressure_level; do
> 	/* register eventfd to be notified on "event" */
> done

This scheme registers "all" events. Here is more complicated case:

Old kernels, pressure_level reads:

  low, med, crit

The app just wants to listen for med level.

New kernels, pressure_level reads:

  low, FOO, med, BAR, crit

How would application decide which of FOO and BAR are ex-med levels?

Anton

  reply	other threads:[~2013-06-28 18:55 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27  3:17 [PATCH v2] vmpressure: implement strict mode Luiz Capitulino
2013-06-27  3:17 ` Luiz Capitulino
2013-06-27  9:26 ` Michal Hocko
2013-06-27  9:26   ` Michal Hocko
2013-06-27 13:34   ` Luiz Capitulino
2013-06-27 13:34     ` Luiz Capitulino
2013-06-27 14:59     ` Michal Hocko
2013-06-27 14:59       ` Michal Hocko
2013-06-27 15:53   ` Minchan Kim
2013-06-27 15:53     ` Minchan Kim
2013-06-27 17:42     ` Michal Hocko
2013-06-27 17:42       ` Michal Hocko
2013-06-27 15:44 ` Minchan Kim
2013-06-27 15:44   ` Minchan Kim
2013-06-27 22:02 ` Andrew Morton
2013-06-27 22:02   ` Andrew Morton
2013-06-28  0:02   ` Minchan Kim
2013-06-28  0:02     ` Minchan Kim
2013-06-28  0:34     ` Andrew Morton
2013-06-28  0:34       ` Andrew Morton
2013-06-28  0:58       ` Anton Vorontsov
2013-06-28  0:58         ` Anton Vorontsov
2013-06-28  1:13         ` Andrew Morton
2013-06-28  1:13           ` Andrew Morton
2013-06-28  4:34           ` Anton Vorontsov
2013-06-28  4:34             ` Anton Vorontsov
2013-06-28  5:07             ` Anton Vorontsov
2013-06-28  5:07               ` Anton Vorontsov
2013-06-28 14:00               ` Luiz Capitulino
2013-06-28 14:00                 ` Luiz Capitulino
2013-06-28 16:57                 ` Anton Vorontsov
2013-06-28 16:57                   ` Anton Vorontsov
2013-06-28 17:09                   ` Anton Vorontsov
2013-06-28 17:09                     ` Anton Vorontsov
2013-06-28 18:25                     ` Luiz Capitulino
2013-06-28 18:25                       ` Luiz Capitulino
2013-06-28 18:45                       ` Anton Vorontsov
2013-06-28 18:45                         ` Anton Vorontsov
2013-06-28 18:58                         ` Luiz Capitulino
2013-06-28 18:58                           ` Luiz Capitulino
2013-06-28 18:45                     ` Luiz Capitulino
2013-06-28 18:45                       ` Luiz Capitulino
2013-06-28 18:55                       ` Anton Vorontsov [this message]
2013-06-28 18:55                         ` Anton Vorontsov
2013-06-28 19:44                         ` Luiz Capitulino
2013-06-28 19:44                           ` Luiz Capitulino
2013-06-29  0:56                           ` Anton Vorontsov
2013-06-29  0:56                             ` Anton Vorontsov
2013-07-01  8:22                             ` Hyunhee Kim
2013-07-01  8:22                               ` Hyunhee Kim
2013-07-02  4:32                               ` Anton Vorontsov
2013-07-02  4:32                                 ` Anton Vorontsov
2013-07-02  8:29                                 ` Hyunhee Kim
2013-07-02  8:29                                   ` Hyunhee Kim
2013-07-02 13:29                             ` Michal Hocko
2013-07-02 13:29                               ` Michal Hocko
2013-07-02 14:59                             ` Luiz Capitulino
2013-07-02 14:59                               ` Luiz Capitulino
2013-07-02 17:24                               ` Anton Vorontsov
2013-07-02 17:24                                 ` Anton Vorontsov
2013-07-02 18:38                                 ` Luiz Capitulino
2013-07-02 18:38                                   ` Luiz Capitulino
2013-06-28  5:24             ` Andrew Morton
2013-06-28  5:24               ` Andrew Morton
2013-06-28 13:43             ` Luiz Capitulino
2013-06-28 13:43               ` Luiz Capitulino
2013-06-28  9:04           ` Minchan Kim
2013-06-28  9:04             ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628185547.GA14520@teo \
    --to=anton@enomsg.org \
    --cc=akpm@linux-foundation.org \
    --cc=hyunhee.kim@samsung.com \
    --cc=kmpark@infradead.org \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.