From: Gleb Natapov <gleb@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Avoid zapping mmio sptes twice for generation wraparound
Date: Wed, 3 Jul 2013 12:10:57 +0300 [thread overview]
Message-ID: <20130703091057.GG18508@redhat.com> (raw)
In-Reply-To: <51D3EA02.2010008@redhat.com>
On Wed, Jul 03, 2013 at 11:08:18AM +0200, Paolo Bonzini wrote:
> Il 03/07/2013 11:05, Gleb Natapov ha scritto:
> >>> Yes, the actual operation would be the same as this patch. You can
> >>> rename kvm_mmu_invalidate_mmio_sptes to kvm_arch_memslots_installed, or
> >>> something like that. But it would have to touch all architectures.
> >>
> >> I tried to avoid introducing x86-centric code into the generic one.
> >>
> >> If another arch can gain something by such function, I'm willing to
> >> touch all arch code.
> >>
> > Please do. X86 is the most optimized one so it does things other arches
> > do not yet. Slot generation update hook sounds generic enough.
>
> Yes, makes sense. However, this patch is still an improvement because
> the current code is too easily mistaken for an off-by-one bug.
>
> Any improvements to the API can go on top.
>
If Takuya will send the proper fix shortly I do not see any reason to
apply this one. It does not fix any bug.
--
Gleb.
next prev parent reply other threads:[~2013-07-03 9:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:18 [PATCH] KVM: x86: Avoid zapping mmio sptes twice for generation wraparound Takuya Yoshikawa
2013-07-03 8:28 ` Paolo Bonzini
2013-07-03 8:39 ` Xiao Guangrong
2013-07-03 8:50 ` Takuya Yoshikawa
2013-07-03 8:50 ` Xiao Guangrong
2013-07-03 8:50 ` Paolo Bonzini
2013-07-03 9:00 ` Xiao Guangrong
2013-07-03 8:50 ` Xiao Guangrong
2013-07-03 8:53 ` Gleb Natapov
2013-07-03 8:57 ` Paolo Bonzini
2013-07-03 9:03 ` Gleb Natapov
2013-07-03 8:53 ` Paolo Bonzini
2013-07-03 9:05 ` Takuya Yoshikawa
2013-07-03 9:05 ` Gleb Natapov
2013-07-03 9:08 ` Paolo Bonzini
2013-07-03 9:10 ` Gleb Natapov [this message]
2013-07-03 9:17 ` Takuya Yoshikawa
2013-07-03 9:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703091057.GG18508@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.