From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
gleb@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Avoid zapping mmio sptes twice for generation wraparound
Date: Wed, 03 Jul 2013 16:50:10 +0800 [thread overview]
Message-ID: <51D3E5C2.7000007@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130703175005.8e02a5d4.yoshikawa_takuya_b1@lab.ntt.co.jp>
On 07/03/2013 04:50 PM, Takuya Yoshikawa wrote:
> On Wed, 03 Jul 2013 16:39:25 +0800
> Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
>
>> Please wait a while. I can not understand it very clearly.
>>
>> This conditional check will cause caching a overflow value into mmio spte.
>> The simple case is that kvm adds new slots for many times, the mmio-gen is easily
>> more than MMIO_MAX_GEN.
>
> Unconditional checking in commit_memory_region() is still there
> to treat such cases.
WHY?
next prev parent reply other threads:[~2013-07-03 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:18 [PATCH] KVM: x86: Avoid zapping mmio sptes twice for generation wraparound Takuya Yoshikawa
2013-07-03 8:28 ` Paolo Bonzini
2013-07-03 8:39 ` Xiao Guangrong
2013-07-03 8:50 ` Takuya Yoshikawa
2013-07-03 8:50 ` Xiao Guangrong [this message]
2013-07-03 8:50 ` Paolo Bonzini
2013-07-03 9:00 ` Xiao Guangrong
2013-07-03 8:50 ` Xiao Guangrong
2013-07-03 8:53 ` Gleb Natapov
2013-07-03 8:57 ` Paolo Bonzini
2013-07-03 9:03 ` Gleb Natapov
2013-07-03 8:53 ` Paolo Bonzini
2013-07-03 9:05 ` Takuya Yoshikawa
2013-07-03 9:05 ` Gleb Natapov
2013-07-03 9:08 ` Paolo Bonzini
2013-07-03 9:10 ` Gleb Natapov
2013-07-03 9:17 ` Takuya Yoshikawa
2013-07-03 9:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D3E5C2.7000007@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.