All of lore.kernel.org
 help / color / mirror / Atom feed
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC
Date: Sun, 7 Jul 2013 12:22:07 +0200	[thread overview]
Message-ID: <20130707102207.GI16871@s25.your-server.de> (raw)
In-Reply-To: <1373100718.107651915@f159.i.mail.ru>

On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote:
> > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> > "ARM: dts: Add device tree support for phycard pca100".
> > 
> > Remove wrong I2C RTC node.
> > 
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> > 
> > Thanks, Alexander, you are right. I2C2 has no RTC.
> ...
> 
> There are a couple of comments on this file.
> 
> I think that the OWIRE should be moved to the RDK.

I moved OWIRE and i2c1 to RDK. Both are not used on the SOM.

> ioexpander must contain "gpio-controller" at least, and for use it further,
> it is necessary to define the label for this node.

I checked all I2C devices in the board schematics. There is actually no
ioexpander. I don't know why it was added. I will send some I2C patches
later.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
Cc: Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC
Date: Sun, 7 Jul 2013 12:22:07 +0200	[thread overview]
Message-ID: <20130707102207.GI16871@s25.your-server.de> (raw)
In-Reply-To: <1373100718.107651915-6Vbm0Rv2S45sdVUOrk1QfQ@public.gmane.org>

On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote:
> > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> > "ARM: dts: Add device tree support for phycard pca100".
> > 
> > Remove wrong I2C RTC node.
> > 
> > Signed-off-by: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> > 
> > Thanks, Alexander, you are right. I2C2 has no RTC.
> ...
> 
> There are a couple of comments on this file.
> 
> I think that the OWIRE should be moved to the RDK.

I moved OWIRE and i2c1 to RDK. Both are not used on the SOM.

> ioexpander must contain "gpio-controller" at least, and for use it further,
> it is necessary to define the label for this node.

I checked all I2C devices in the board schematics. There is actually no
ioexpander. I don't know why it was added. I will send some I2C patches
later.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-07-07 10:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 14:50 [PATCH v3 0/5] ARM: dts: imx27 Phytec phyCARD-S Markus Pargmann
2013-06-28 14:50 ` Markus Pargmann
2013-06-28 14:50 ` [PATCH v3 1/5] ARM: imx27: Use 'AITC' for the interrupt controller name Markus Pargmann
2013-06-28 14:50   ` Markus Pargmann
2013-06-28 14:50 ` [PATCH v3 2/5] ARM: dts: imx27: Add imx framebuffer device Markus Pargmann
2013-06-28 14:50   ` Markus Pargmann
2013-06-28 15:10   ` Alexander Shiyan
2013-06-28 15:10     ` Alexander Shiyan
2013-07-01  9:30     ` Shawn Guo
2013-07-01  9:30       ` Shawn Guo
2013-07-02  4:30       ` Re[2]: " Alexander Shiyan
2013-06-28 14:50 ` [PATCH v3 3/5] ARM: dts: imx27: Add 1-wire Markus Pargmann
2013-06-28 14:50   ` Markus Pargmann
2013-06-28 14:50 ` [PATCH v3 4/5] ARM: dts: imx27 cpufreq-cpu0 frequencies Markus Pargmann
2013-06-28 14:50   ` Markus Pargmann
2013-06-28 14:50 ` [PATCH v3 5/5] ARM: dts: Add device tree support for phycard pca100 Markus Pargmann
2013-06-28 14:50   ` Markus Pargmann
2013-07-02 16:27   ` Alexander Shiyan
2013-07-02 16:27     ` Alexander Shiyan
2013-07-05 13:45     ` [PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC Markus Pargmann
2013-07-05 13:45       ` Markus Pargmann
2013-07-06  3:15       ` Shawn Guo
2013-07-06  3:15         ` Shawn Guo
2013-07-06  8:51       ` Alexander Shiyan
2013-07-06  8:51         ` Alexander Shiyan
2013-07-07 10:22         ` Markus Pargmann [this message]
2013-07-07 10:22           ` Markus Pargmann
2013-07-07 10:31           ` Re[2]: " Alexander Shiyan
2013-07-07 10:31             ` Alexander Shiyan
2013-07-07 10:44             ` Markus Pargmann
2013-07-07 10:44               ` Markus Pargmann
2013-06-29  8:38 ` [PATCH v3 0/5] ARM: dts: imx27 Phytec phyCARD-S Sascha Hauer
2013-06-29  8:38   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130707102207.GI16871@s25.your-server.de \
    --to=mpa@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.