From: Minchan Kim <minchan@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, xemul@parallels.com,
akpm@linux-foundation.org, mpm@selenic.com,
xiaoguangrong@linux.vnet.ibm.com, mtosatti@redhat.com,
kosaki.motohiro@gmail.com, sfr@canb.auug.org.au,
peterz@infradead.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages
Date: Thu, 1 Aug 2013 15:37:06 +0900 [thread overview]
Message-ID: <20130801063706.GF19540@bbox> (raw)
In-Reply-To: <20130801062814.GB1764@moon>
On Thu, Aug 01, 2013 at 10:28:14AM +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 01, 2013 at 03:16:32PM +0900, Minchan Kim wrote:
> >
> > I don't get it. Could you correct me with below example?
> >
> > Process A context
> > try_to_unmap
> > swp_pte = swp_entry_to_pte /* change generic swp into arch swap */
> > swp_pte = pte_swp_mksoft_dirty(swp_pte);
> > set_pte_at(, swp_pte);
> >
> > Process A context
> > ..
> > mincore_pte_range
> pte_t pte = *ptep; <-- local copy of the pte value, in memory it remains the same
> with swap softdirty bit set
Argh, I missed that. Thank you!
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, xemul@parallels.com,
akpm@linux-foundation.org, mpm@selenic.com,
xiaoguangrong@linux.vnet.ibm.com, mtosatti@redhat.com,
kosaki.motohiro@gmail.com, sfr@canb.auug.org.au,
peterz@infradead.org, aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages
Date: Thu, 1 Aug 2013 15:37:06 +0900 [thread overview]
Message-ID: <20130801063706.GF19540@bbox> (raw)
In-Reply-To: <20130801062814.GB1764@moon>
On Thu, Aug 01, 2013 at 10:28:14AM +0400, Cyrill Gorcunov wrote:
> On Thu, Aug 01, 2013 at 03:16:32PM +0900, Minchan Kim wrote:
> >
> > I don't get it. Could you correct me with below example?
> >
> > Process A context
> > try_to_unmap
> > swp_pte = swp_entry_to_pte /* change generic swp into arch swap */
> > swp_pte = pte_swp_mksoft_dirty(swp_pte);
> > set_pte_at(, swp_pte);
> >
> > Process A context
> > ..
> > mincore_pte_range
> pte_t pte = *ptep; <-- local copy of the pte value, in memory it remains the same
> with swap softdirty bit set
Argh, I missed that. Thank you!
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2013-08-01 6:36 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 20:41 [patch 0/2] Soft-dirty page tracker improvemens Cyrill Gorcunov
2013-07-30 20:41 ` Cyrill Gorcunov
2013-07-30 20:41 ` [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages Cyrill Gorcunov
2013-07-30 20:41 ` Cyrill Gorcunov
2013-07-31 8:16 ` Pavel Emelyanov
2013-07-31 8:16 ` Pavel Emelyanov
2013-08-01 0:51 ` Minchan Kim
2013-08-01 0:51 ` Minchan Kim
2013-08-01 5:53 ` Cyrill Gorcunov
2013-08-01 5:53 ` Cyrill Gorcunov
2013-08-01 6:16 ` Minchan Kim
2013-08-01 6:16 ` Minchan Kim
2013-08-01 6:28 ` Cyrill Gorcunov
2013-08-01 6:28 ` Cyrill Gorcunov
2013-08-01 6:37 ` Minchan Kim [this message]
2013-08-01 6:37 ` Minchan Kim
2013-08-01 6:38 ` Cyrill Gorcunov
2013-08-01 6:38 ` Cyrill Gorcunov
2013-08-05 1:48 ` Wanpeng Li
2013-08-05 1:48 ` Wanpeng Li
[not found] ` <51ff047d.2768310a.2fc4.340fSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 2:17 ` Minchan Kim
2013-08-05 2:17 ` Minchan Kim
2013-08-05 2:38 ` Wanpeng Li
2013-08-05 2:38 ` Wanpeng Li
[not found] ` <51ff1053.ab47310a.5d3f.566cSMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 2:54 ` Minchan Kim
2013-08-05 2:54 ` Minchan Kim
2013-08-05 2:58 ` Wanpeng Li
2013-08-05 2:58 ` Wanpeng Li
[not found] ` <51ff14e9.87ef440a.1424.ffffe470SMTPIN_ADDED_BROKEN@mx.google.com>
2013-08-05 5:43 ` Cyrill Gorcunov
2013-08-05 5:43 ` Cyrill Gorcunov
2013-08-07 20:21 ` Andrew Morton
2013-08-07 20:21 ` Andrew Morton
2013-08-07 20:29 ` Cyrill Gorcunov
2013-08-07 20:29 ` Cyrill Gorcunov
2013-08-10 17:48 ` James Bottomley
2013-08-10 17:48 ` James Bottomley
2013-07-30 20:41 ` [patch 2/2] [PATCH] mm: Save soft-dirty bits on file pages Cyrill Gorcunov
2013-07-30 20:41 ` Cyrill Gorcunov
2013-07-31 8:16 ` Pavel Emelyanov
2013-07-31 8:16 ` Pavel Emelyanov
2013-08-07 20:28 ` Andrew Morton
2013-08-07 20:28 ` Andrew Morton
2013-08-07 20:31 ` Cyrill Gorcunov
2013-08-07 20:31 ` Cyrill Gorcunov
2013-08-08 14:51 ` Cyrill Gorcunov
2013-08-12 21:57 ` Andrew Morton
2013-08-12 21:57 ` Andrew Morton
2013-08-12 22:28 ` Andy Lutomirski
2013-08-12 22:28 ` Andy Lutomirski
2013-08-12 22:37 ` Andrew Morton
2013-08-12 22:37 ` Andrew Morton
2013-08-13 5:02 ` Cyrill Gorcunov
2013-08-13 5:02 ` Cyrill Gorcunov
2013-08-13 15:14 ` H. Peter Anvin
2013-08-13 15:14 ` H. Peter Anvin
2013-08-13 15:37 ` Cyrill Gorcunov
2013-08-13 15:37 ` Cyrill Gorcunov
2013-08-13 16:43 ` H. Peter Anvin
2013-08-13 16:43 ` H. Peter Anvin
2013-08-13 21:28 ` Cyrill Gorcunov
2013-08-13 21:28 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801063706.GF19540@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gorcunov@gmail.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mpm@selenic.com \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=xemul@parallels.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.