From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: jic23@cam.ac.uk, linux-arm-kernel@lists.infradead.org,
linux-iio@vger.kernel.org, plagnioj@jcrosoft.com,
nicolas.ferre@atmel.com, thomas.petazzoni@free-electrons.com,
mark.rutland@arm.com, b.brezillon@overkiz.com
Subject: Re: [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP
Date: Thu, 15 Aug 2013 21:20:44 +0200 [thread overview]
Message-ID: <20130815192044.GD12162@lukather> (raw)
In-Reply-To: <1376219071-29946-3-git-send-email-josh.wu@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi Josh,
On Sun, Aug 11, 2013 at 07:04:29PM +0800, Josh Wu wrote:
> For at91 boards, there are different IPs for adc. Different IPs has
> different STARTUP & PRESCAL mask in ADC_MR.
>
> This patch introduce the multiple compatible string for those
> different IPs.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
Overall it looks like the right ways, but I think we can take it a step
further.
I'd drop at least the atmel,adc-drdy-mask, atmel,adc-num-channels,
atmel,adc-status-register, atmel,adc-trigger-register properties (and
probably the triggers as well description as well).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP
Date: Thu, 15 Aug 2013 21:20:44 +0200 [thread overview]
Message-ID: <20130815192044.GD12162@lukather> (raw)
In-Reply-To: <1376219071-29946-3-git-send-email-josh.wu@atmel.com>
Hi Josh,
On Sun, Aug 11, 2013 at 07:04:29PM +0800, Josh Wu wrote:
> For at91 boards, there are different IPs for adc. Different IPs has
> different STARTUP & PRESCAL mask in ADC_MR.
>
> This patch introduce the multiple compatible string for those
> different IPs.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
Overall it looks like the right ways, but I think we can take it a step
further.
I'd drop at least the atmel,adc-drdy-mask, atmel,adc-num-channels,
atmel,adc-status-register, atmel,adc-trigger-register properties (and
probably the triggers as well description as well).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130815/5a870082/attachment.sig>
next prev parent reply other threads:[~2013-08-15 19:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 11:04 [PATCH v2 0/4] iio: at91: Add touch screen support in at91 adc Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 1/4] iio: at91: fix adc_clk overflow Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:20 ` Maxime Ripard [this message]
2013-08-15 19:20 ` Maxime Ripard
2013-08-22 9:51 ` Josh Wu
2013-08-22 9:51 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-23 15:46 ` Desroches, Ludovic
2013-08-23 16:59 ` Maxime Ripard
2013-08-23 16:59 ` Maxime Ripard
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 10:03 ` Josh Wu
2013-08-26 10:03 ` Josh Wu
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:47 ` Maxime Ripard
2013-08-27 9:47 ` Maxime Ripard
2013-08-11 11:04 ` [PATCH v2 3/4] iio: at91: ADC start-up time calculation changed since at91sam9x5 Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:27 ` Maxime Ripard
2013-08-15 19:27 ` Maxime Ripard
2013-08-22 9:54 ` Josh Wu
2013-08-22 9:54 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 4/4] iio: at91: introduce touch screen support in iio adc driver Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-15 10:27 ` Jonathan Cameron
2013-08-15 10:27 ` Jonathan Cameron
2013-08-22 10:02 ` Josh Wu
2013-08-22 10:02 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815192044.GD12162@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=b.brezillon@overkiz.com \
--cc=jic23@cam.ac.uk \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.