From: Josh Wu <josh.wu@atmel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <maxime.ripard@free-electrons.com>,
<plagnioj@jcrosoft.com>, <nicolas.ferre@atmel.com>,
<thomas.petazzoni@free-electrons.com>, <mark.rutland@arm.com>,
<b.brezillon@overkiz.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH v2 4/4] iio: at91: introduce touch screen support in iio adc driver
Date: Thu, 22 Aug 2013 18:02:59 +0800 [thread overview]
Message-ID: <5215E1D3.5090905@atmel.com> (raw)
In-Reply-To: <520CAD07.1080709@kernel.org>
Hi, Jonathan
On 8/15/2013 6:27 PM, Jonathan Cameron wrote:
>
> On 08/12/13 18:24, Dmitry Torokhov wrote:
>> Hi Josh,
> Hi Dmitry,
>
> As you haven't raised it here, I am guessing you are fine with having this
> chunk of input related code in an IIO driver? I wonder if it would be
> better to break this into an mfd core and child input and iio drivers.
> The two parts look fairly separable to me.
> Clearly that means adding some overhead, but the gain is that the input
> code ends up in input and the IIO code in IIO.
>
> What are your views on this? I'm fairly flexible if you think it simply
> isn't worth the hassle of breaking this up. I'm more worried about setting
> a precident than anything else.
>
> Jonathan
Since Dmitry has no feedback yet. I am not sure is it a right time to
send out the next version for the IIO ad91 touch patch?
[snip...]
Best Regards,
Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] iio: at91: introduce touch screen support in iio adc driver
Date: Thu, 22 Aug 2013 18:02:59 +0800 [thread overview]
Message-ID: <5215E1D3.5090905@atmel.com> (raw)
In-Reply-To: <520CAD07.1080709@kernel.org>
Hi, Jonathan
On 8/15/2013 6:27 PM, Jonathan Cameron wrote:
>
> On 08/12/13 18:24, Dmitry Torokhov wrote:
>> Hi Josh,
> Hi Dmitry,
>
> As you haven't raised it here, I am guessing you are fine with having this
> chunk of input related code in an IIO driver? I wonder if it would be
> better to break this into an mfd core and child input and iio drivers.
> The two parts look fairly separable to me.
> Clearly that means adding some overhead, but the gain is that the input
> code ends up in input and the IIO code in IIO.
>
> What are your views on this? I'm fairly flexible if you think it simply
> isn't worth the hassle of breaking this up. I'm more worried about setting
> a precident than anything else.
>
> Jonathan
Since Dmitry has no feedback yet. I am not sure is it a right time to
send out the next version for the IIO ad91 touch patch?
[snip...]
Best Regards,
Josh Wu
next prev parent reply other threads:[~2013-08-22 10:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 11:04 [PATCH v2 0/4] iio: at91: Add touch screen support in at91 adc Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 1/4] iio: at91: fix adc_clk overflow Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:20 ` Maxime Ripard
2013-08-15 19:20 ` Maxime Ripard
2013-08-22 9:51 ` Josh Wu
2013-08-22 9:51 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-23 15:46 ` Desroches, Ludovic
2013-08-23 16:59 ` Maxime Ripard
2013-08-23 16:59 ` Maxime Ripard
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 10:03 ` Josh Wu
2013-08-26 10:03 ` Josh Wu
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:47 ` Maxime Ripard
2013-08-27 9:47 ` Maxime Ripard
2013-08-11 11:04 ` [PATCH v2 3/4] iio: at91: ADC start-up time calculation changed since at91sam9x5 Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:27 ` Maxime Ripard
2013-08-15 19:27 ` Maxime Ripard
2013-08-22 9:54 ` Josh Wu
2013-08-22 9:54 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 4/4] iio: at91: introduce touch screen support in iio adc driver Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-15 10:27 ` Jonathan Cameron
2013-08-15 10:27 ` Jonathan Cameron
2013-08-22 10:02 ` Josh Wu [this message]
2013-08-22 10:02 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215E1D3.5090905@atmel.com \
--to=josh.wu@atmel.com \
--cc=b.brezillon@overkiz.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.