From: Josh Wu <josh.wu@atmel.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: <jic23@cam.ac.uk>, <linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <plagnioj@jcrosoft.com>,
<nicolas.ferre@atmel.com>, <thomas.petazzoni@free-electrons.com>,
<mark.rutland@arm.com>, <b.brezillon@overkiz.com>
Subject: Re: [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP
Date: Thu, 22 Aug 2013 17:51:40 +0800 [thread overview]
Message-ID: <5215DF2C.3050502@atmel.com> (raw)
In-Reply-To: <20130815192044.GD12162@lukather>
Hi, Maxime
On 8/16/2013 3:20 AM, Maxime Ripard wrote:
> Hi Josh,
>
> On Sun, Aug 11, 2013 at 07:04:29PM +0800, Josh Wu wrote:
>> For at91 boards, there are different IPs for adc. Different IPs has
>> different STARTUP & PRESCAL mask in ADC_MR.
>>
>> This patch introduce the multiple compatible string for those
>> different IPs.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Overall it looks like the right ways, but I think we can take it a step
> further.
>
> I'd drop at least the atmel,adc-drdy-mask, atmel,adc-num-channels,
> atmel,adc-status-register, atmel,adc-trigger-register properties (and
> probably the triggers as well description as well).
yeah, right. Currently I want to drop following:
atmel,adc-drdy-mask, atmel,adc-status-register, atmel,adc-trigger-register, atmel,adc-channel-base
For the adc-num-channels, I'd like to leave it in dt parameters. It is a
description for an adc capablity.
For the triggers, I am not decided. An obvious benifit to remove trigger
in dt will save many lines of code.
>
> Maxime
>
Best Regards,
Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP
Date: Thu, 22 Aug 2013 17:51:40 +0800 [thread overview]
Message-ID: <5215DF2C.3050502@atmel.com> (raw)
In-Reply-To: <20130815192044.GD12162@lukather>
Hi, Maxime
On 8/16/2013 3:20 AM, Maxime Ripard wrote:
> Hi Josh,
>
> On Sun, Aug 11, 2013 at 07:04:29PM +0800, Josh Wu wrote:
>> For at91 boards, there are different IPs for adc. Different IPs has
>> different STARTUP & PRESCAL mask in ADC_MR.
>>
>> This patch introduce the multiple compatible string for those
>> different IPs.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> Overall it looks like the right ways, but I think we can take it a step
> further.
>
> I'd drop at least the atmel,adc-drdy-mask, atmel,adc-num-channels,
> atmel,adc-status-register, atmel,adc-trigger-register properties (and
> probably the triggers as well description as well).
yeah, right. Currently I want to drop following:
atmel,adc-drdy-mask, atmel,adc-status-register, atmel,adc-trigger-register, atmel,adc-channel-base
For the adc-num-channels, I'd like to leave it in dt parameters. It is a
description for an adc capablity.
For the triggers, I am not decided. An obvious benifit to remove trigger
in dt will save many lines of code.
>
> Maxime
>
Best Regards,
Josh Wu
next prev parent reply other threads:[~2013-08-22 9:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 11:04 [PATCH v2 0/4] iio: at91: Add touch screen support in at91 adc Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 1/4] iio: at91: fix adc_clk overflow Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:20 ` Maxime Ripard
2013-08-15 19:20 ` Maxime Ripard
2013-08-22 9:51 ` Josh Wu [this message]
2013-08-22 9:51 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-22 9:53 ` Josh Wu
2013-08-23 15:46 ` Desroches, Ludovic
2013-08-23 16:59 ` Maxime Ripard
2013-08-23 16:59 ` Maxime Ripard
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 8:32 ` Ludovic Desroches
2013-08-26 10:03 ` Josh Wu
2013-08-26 10:03 ` Josh Wu
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 8:15 ` Maxime Ripard
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:05 ` Nicolas Ferre
2013-08-27 9:47 ` Maxime Ripard
2013-08-27 9:47 ` Maxime Ripard
2013-08-11 11:04 ` [PATCH v2 3/4] iio: at91: ADC start-up time calculation changed since at91sam9x5 Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-15 19:27 ` Maxime Ripard
2013-08-15 19:27 ` Maxime Ripard
2013-08-22 9:54 ` Josh Wu
2013-08-22 9:54 ` Josh Wu
2013-08-11 11:04 ` [PATCH v2 4/4] iio: at91: introduce touch screen support in iio adc driver Josh Wu
2013-08-11 11:04 ` Josh Wu
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-12 17:24 ` Dmitry Torokhov
2013-08-15 10:27 ` Jonathan Cameron
2013-08-15 10:27 ` Jonathan Cameron
2013-08-22 10:02 ` Josh Wu
2013-08-22 10:02 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
2013-08-20 9:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215DF2C.3050502@atmel.com \
--to=josh.wu@atmel.com \
--cc=b.brezillon@overkiz.com \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.