From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Jürgen Beisert" <jbe@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
Marek Vasut <marex@denx.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
linux-iio@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver
Date: Thu, 5 Sep 2013 13:42:56 +0300 [thread overview]
Message-ID: <20130905104256.GK6329@mwanda> (raw)
In-Reply-To: <201309051216.18305.jbe@pengutronix.de>
On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote:
> I like this simplification, but all the other drivers for the MXS series of
> SoCs don't use such a method. Do you think this "new style" will be accepted?
>
My lradc_plate_mask() is basically the same idea as what Marek said
about putting the logic into the define.
LRADC....IRQ_MASK(id) (((id) == MX23) ? 0x1ff : 0x1fff)
I don't know why Marek is complaining about churn though. This is
linux! We love churn! And especially in staging, it's our favorite
thing. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver
Date: Thu, 5 Sep 2013 13:42:56 +0300 [thread overview]
Message-ID: <20130905104256.GK6329@mwanda> (raw)
In-Reply-To: <201309051216.18305.jbe@pengutronix.de>
On Thu, Sep 05, 2013 at 12:16:18PM +0200, J?rgen Beisert wrote:
> I like this simplification, but all the other drivers for the MXS series of
> SoCs don't use such a method. Do you think this "new style" will be accepted?
>
My lradc_plate_mask() is basically the same idea as what Marek said
about putting the logic into the define.
LRADC....IRQ_MASK(id) (((id) == MX23) ? 0x1ff : 0x1fff)
I don't know why Marek is complaining about churn though. This is
linux! We love churn! And especially in staging, it's our favorite
thing. :P
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-05 10:42 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 13:01 [RFC] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-04 13:01 ` [PATCH 1/5] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
2013-09-04 13:01 ` [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
2013-09-04 14:06 ` Marek Vasut
2013-09-04 14:06 ` Marek Vasut
2013-09-05 7:12 ` Jürgen Beisert
2013-09-05 7:12 ` Jürgen Beisert
2013-09-04 14:36 ` Dan Carpenter
2013-09-04 14:36 ` Dan Carpenter
2013-09-05 7:13 ` Jürgen Beisert
2013-09-05 7:13 ` Jürgen Beisert
2013-09-04 13:01 ` [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
2013-09-04 14:27 ` Dan Carpenter
2013-09-04 14:27 ` Dan Carpenter
2013-09-05 10:16 ` Jürgen Beisert
2013-09-05 10:16 ` Jürgen Beisert
2013-09-05 10:42 ` Dan Carpenter [this message]
2013-09-05 10:42 ` Dan Carpenter
2013-09-05 10:51 ` Marek Vasut
2013-09-05 10:51 ` Marek Vasut
2013-09-05 18:15 ` Dan Carpenter
2013-09-05 18:15 ` Dan Carpenter
2013-09-05 18:16 ` [patch] iio: mxs-lradc: use helper functions to simplify the code Dan Carpenter
2013-09-05 18:16 ` Dan Carpenter
2013-09-05 20:15 ` Fabio Estevam
2013-09-05 20:15 ` Fabio Estevam
2013-09-05 20:29 ` Marek Vasut
2013-09-05 20:29 ` Marek Vasut
2013-09-06 8:39 ` Russell King - ARM Linux
2013-09-06 8:39 ` Russell King - ARM Linux
2013-09-06 7:01 ` Jürgen Beisert
2013-09-06 7:01 ` Jürgen Beisert
2013-09-06 7:29 ` Dan Carpenter
2013-09-06 7:29 ` Dan Carpenter
2013-09-04 13:01 ` [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
2013-09-04 13:01 ` [PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
2013-09-04 14:37 ` Dan Carpenter
2013-09-04 14:37 ` Dan Carpenter
2013-09-05 7:10 ` Jürgen Beisert
2013-09-05 7:10 ` Jürgen Beisert
-- strict thread matches above, loose matches on Subject: below --
2013-09-06 10:08 [RFCv2] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-06 10:08 ` [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-09 8:03 [RFCv3] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-09 8:03 ` [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver Juergen Beisert
2013-09-09 8:03 ` Juergen Beisert
2013-09-09 16:04 ` Marek Vasut
2013-09-09 16:04 ` Marek Vasut
2013-09-10 7:36 ` Jürgen Beisert
2013-09-10 7:36 ` Jürgen Beisert
2013-09-10 8:22 ` Marek Vasut
2013-09-10 8:22 ` Marek Vasut
2013-09-10 12:58 ` Jürgen Beisert
2013-09-10 12:58 ` Jürgen Beisert
2013-09-10 13:43 ` Marek Vasut
2013-09-10 13:43 ` Marek Vasut
2013-09-10 20:54 ` Dan Carpenter
2013-09-10 20:54 ` Dan Carpenter
2013-09-10 21:21 ` Marek Vasut
2013-09-10 21:21 ` Marek Vasut
2013-09-11 7:07 ` Jürgen Beisert
2013-09-11 7:07 ` Jürgen Beisert
2013-09-11 7:06 ` Jürgen Beisert
2013-09-11 7:06 ` Jürgen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905104256.GK6329@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=jbe@pengutronix.de \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.