All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: "Zhu Richard-R65037" <r65037@freescale.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"tharvey@gateworks.com" <tharvey@gateworks.com>,
	Frank Li <lznuaa@gmail.com>, Sean Cross <xobs@kosagi.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v7 0/2] Add PCIe support for i.MX6q
Date: Thu, 10 Oct 2013 12:25:10 +0200	[thread overview]
Message-ID: <201310101225.10455.marex@denx.de> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D401869@039-SN2MPN1-011.039d.mgd.msft.net>

Hi Richard,

> Hi Marek:
> Thanks for your kindly tests.
> 
> Regarding to my experience on 3.0.35 kernel, besides the programming the
> RdWr0 vs. RdWr1 mode into the iATU. The INTx should be configured
> properly, for example, like the following one:
> 
> static int __init imx_pcie_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
> {
>        switch (pin) {
>        case 1: return MXC_INT_PCIE_3;
>        case 2: return MXC_INT_PCIE_2;
>        case 3: return MXC_INT_PCIE_1;
>        case 4: return MXC_INT_PCIE_0;
>        default: return -1;
>        }
> }
> 
> static struct hw_pci imx_pci __initdata = {
>         .nr_controllers = 1,
>         .swizzle        = pci_std_swizzle,
>         .setup          = imx_pcie_setup,
>         .scan           = imx_pcie_scan_bus,
>         .map_irq        = imx_pcie_map_irq,
> };
> Best Regards
> Richard Zhu

Thanks for pointing this out, I'll check this. Are there plans to implement the 
PCIe switch support already so I won't step into someone else's work?

In the meantime, this is what I see upon probe with V6 of the patches:

Linux version 3.12.0-rc2-next-20130927+
[...]
imx6q-pcie 1ffc000.pcie: phy link never came up
PCI host bridge to bus 0000:00
pci_bus 0000:00: root bus resource [io  0x1000-0x10000]
pci_bus 0000:00: root bus resource [mem 0x01000000-0x01efffff]
pci_bus 0000:00: No busn resource found for root bus, will use [bus 00-ff]
PCI: bus0: Fast back to back transfers disabled
PCI: bus1: Fast back to back transfers enabled
PCI: Device 0000:00:00.0 not available because of resource collisions
pcieport: probe of 0000:00:00.0 failed with error -22
pci 0000:00:00.0: BAR 0: assigned [mem 0x01000000-0x010fffff]
pci 0000:00:00.0: BAR 6: assigned [mem 0x01100000-0x0110ffff pref]
pci 0000:00:00.0: PCI bridge to [bus 01]
pci 0000:00:00.0: PCI bridge to [bus 01]

Is this line normal/expected? Is this related to the PCIe switch I have there?
pcieport: probe of 0000:00:00.0 failed with error -22

Thank you for your help!

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/2] Add PCIe support for i.MX6q
Date: Thu, 10 Oct 2013 12:25:10 +0200	[thread overview]
Message-ID: <201310101225.10455.marex@denx.de> (raw)
In-Reply-To: <0E83723C55F66F43A6041464FE31119D401869@039-SN2MPN1-011.039d.mgd.msft.net>

Hi Richard,

> Hi Marek:
> Thanks for your kindly tests.
> 
> Regarding to my experience on 3.0.35 kernel, besides the programming the
> RdWr0 vs. RdWr1 mode into the iATU. The INTx should be configured
> properly, for example, like the following one:
> 
> static int __init imx_pcie_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
> {
>        switch (pin) {
>        case 1: return MXC_INT_PCIE_3;
>        case 2: return MXC_INT_PCIE_2;
>        case 3: return MXC_INT_PCIE_1;
>        case 4: return MXC_INT_PCIE_0;
>        default: return -1;
>        }
> }
> 
> static struct hw_pci imx_pci __initdata = {
>         .nr_controllers = 1,
>         .swizzle        = pci_std_swizzle,
>         .setup          = imx_pcie_setup,
>         .scan           = imx_pcie_scan_bus,
>         .map_irq        = imx_pcie_map_irq,
> };
> Best Regards
> Richard Zhu

Thanks for pointing this out, I'll check this. Are there plans to implement the 
PCIe switch support already so I won't step into someone else's work?

In the meantime, this is what I see upon probe with V6 of the patches:

Linux version 3.12.0-rc2-next-20130927+
[...]
imx6q-pcie 1ffc000.pcie: phy link never came up
PCI host bridge to bus 0000:00
pci_bus 0000:00: root bus resource [io  0x1000-0x10000]
pci_bus 0000:00: root bus resource [mem 0x01000000-0x01efffff]
pci_bus 0000:00: No busn resource found for root bus, will use [bus 00-ff]
PCI: bus0: Fast back to back transfers disabled
PCI: bus1: Fast back to back transfers enabled
PCI: Device 0000:00:00.0 not available because of resource collisions
pcieport: probe of 0000:00:00.0 failed with error -22
pci 0000:00:00.0: BAR 0: assigned [mem 0x01000000-0x010fffff]
pci 0000:00:00.0: BAR 6: assigned [mem 0x01100000-0x0110ffff pref]
pci 0000:00:00.0: PCI bridge to [bus 01]
pci 0000:00:00.0: PCI bridge to [bus 01]

Is this line normal/expected? Is this related to the PCIe switch I have there?
pcieport: probe of 0000:00:00.0 failed with error -22

Thank you for your help!

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-10 10:25 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  3:24 [PATCH v7 0/2] Add PCIe support for i.MX6q Shawn Guo
2013-09-26  3:24 ` Shawn Guo
2013-09-26  3:24 ` [PATCH v7 1/2] ARM: imx6q: Add PCIe bits to GPR syscon definition Shawn Guo
2013-09-26  3:24   ` Shawn Guo
2013-09-26  3:24 ` [PATCH v7 2/2] PCI: imx6: Add support for i.MX6 PCIe controller Shawn Guo
2013-09-26  3:24   ` Shawn Guo
2013-09-27 19:24 ` [PATCH v7 0/2] Add PCIe support for i.MX6q Bjorn Helgaas
2013-09-27 19:24   ` Bjorn Helgaas
2013-09-28  6:56   ` Shawn Guo
2013-09-28  6:56     ` Shawn Guo
2013-10-08 20:56   ` Marek Vasut
2013-10-08 20:56     ` Marek Vasut
2013-10-09  5:23     ` Zhu Richard-R65037
2013-10-09  5:23       ` Zhu Richard-R65037
2013-10-10 10:25       ` Marek Vasut [this message]
2013-10-10 10:25         ` Marek Vasut
2013-10-10 10:40         ` Zhu Richard-R65037
2013-10-10 10:40           ` Zhu Richard-R65037
2013-10-10 12:59           ` Marek Vasut
2013-10-10 12:59             ` Marek Vasut
2013-10-10 20:33           ` Tim Harvey
2013-10-10 20:33             ` Tim Harvey
2013-10-10 20:40             ` Marek Vasut
2013-10-10 20:40               ` Marek Vasut
2013-10-10 13:27         ` Bjorn Helgaas
2013-10-10 13:27           ` Bjorn Helgaas
2013-10-10 13:43           ` Marek Vasut
2013-10-10 13:43             ` Marek Vasut
2013-10-10 15:58           ` Marek Vasut
2013-10-10 15:58             ` Marek Vasut
2013-10-10 17:17             ` Bjorn Helgaas
2013-10-10 17:17               ` Bjorn Helgaas
2013-10-10 17:39               ` Marek Vasut
2013-10-10 17:39                 ` Marek Vasut
2013-10-10 17:56                 ` Bjorn Helgaas
2013-10-10 17:56                   ` Bjorn Helgaas
2013-10-11  2:12                   ` [PATCH 1/2] PCI: imx6: Make reset-gpio optional Marek Vasut
2013-10-11  2:12                     ` Marek Vasut
2013-10-11  2:12                     ` [PATCH 2/2] PCI: imx6: Fix the clock for PCIe Marek Vasut
2013-10-11  2:12                       ` Marek Vasut
2013-10-11  7:20                       ` Jingoo Han
2013-10-11  7:20                         ` Jingoo Han
2013-10-11 11:55                         ` Marek Vasut
2013-10-11 11:55                           ` Marek Vasut
2013-10-12  7:13                           ` Shawn Guo
2013-10-12  7:13                             ` Shawn Guo
2013-10-11  7:09                     ` [PATCH 1/2] PCI: imx6: Make reset-gpio optional Jingoo Han
2013-10-11  7:09                       ` Jingoo Han
2013-10-12  7:20                     ` Shawn Guo
2013-10-12  7:20                       ` Shawn Guo
2013-10-12  9:28                       ` Marek Vasut
2013-10-12  9:28                         ` Marek Vasut
2013-10-14  0:02                         ` Jingoo Han
2013-10-14  0:02                           ` Jingoo Han
2013-10-14  0:44                           ` Marek Vasut
2013-10-14  0:44                             ` Marek Vasut
2013-10-14  1:17                             ` Marek Vasut
2013-10-14  1:17                               ` Marek Vasut
2013-10-14  2:33                               ` Jingoo Han
2013-10-14  2:33                                 ` Jingoo Han
2013-10-14  3:23                                 ` Marek Vasut
2013-10-14  3:23                                   ` Marek Vasut
2013-10-11  2:13                   ` [PATCH v7 0/2] Add PCIe support for i.MX6q Marek Vasut
2013-10-11  2:13                     ` Marek Vasut
2013-10-11  2:18                     ` Marek Vasut
2013-10-11  2:18                       ` Marek Vasut
2013-10-11  2:29                       ` Zhu Richard-R65037
2013-10-11  2:29                         ` Zhu Richard-R65037
2013-10-11  4:44                       ` Yinghai Lu
2013-10-11  4:44                         ` Yinghai Lu
2013-10-11 14:44                         ` Marek Vasut
2013-10-11 14:44                           ` Marek Vasut
2013-10-11 15:24                           ` Tim Harvey
2013-10-11 15:24                             ` Tim Harvey
2013-10-11 20:13                             ` Marek Vasut
2013-10-11 20:13                               ` Marek Vasut
2013-10-12  2:16                             ` Zhu Richard-R65037
2013-10-12  2:16                               ` Zhu Richard-R65037
2013-10-12  2:30                               ` Marek Vasut
2013-10-12  2:30                                 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310101225.10455.marex@denx.de \
    --to=marex@denx.de \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lznuaa@gmail.com \
    --cc=r65037@freescale.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    --cc=tharvey@gateworks.com \
    --cc=xobs@kosagi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.