All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-mtd@lists.infradead.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Mon, 25 Nov 2013 09:03:36 -0300	[thread overview]
Message-ID: <20131125120335.GD2408@localhost> (raw)
In-Reply-To: <87d2lp28pd.fsf@natisbad.org>

Hi Arnaud,

On Sun, Nov 24, 2013 at 03:08:46PM +0100, Arnaud Ebalard wrote:
> 
> As ReadyNAS 102, 104 and 2120 all depend on your driver, I decided to
> give v4 a change on a 102. As a side note, all those device have the
> same NAND chip, i.e. a 128 MB hynix H27U1G8F2BTR. Additionally, this is
> also the chip found on ReadyNAS Duo v2, which is perfectly handled by
> orion-nand driver.
> 
> With your 31 patches in my quilt set against current linus tree (w/
> 2 to 4 of 31 disabled as they are already in Linus tree), I modified
> my .dts in the following way:
> 
>  nand@d0000 {
>          status = "okay";
>          num-cs = <1>;
>          marvell,nand-keep-config;
>          marvell,nand-enable-arbiter;
>          nand-on-flash-bbt;
> 

Great! Thanks for giving NAND a chance :-)

Could you try using the devicetree snippet below?

nand@d0000 {
	/* HACK: Use legacy compatible to handle smaller pages */
	compatible = "marvell,pxa3xx-nand";
	status = "okay";
	num-cs = <1>;
	marvell,nand-keep-config;
	marvell,nand-enable-arbiter;
	nand-on-flash-bbt;

	/* partitions */
};

Please check if your device is detected and try to do some reading
first. If that works, you can try to mount the filesystem, or write
a new kernel.

If the above works, I'll prepare a proper patch.

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Mon, 25 Nov 2013 09:03:36 -0300	[thread overview]
Message-ID: <20131125120335.GD2408@localhost> (raw)
In-Reply-To: <87d2lp28pd.fsf@natisbad.org>

Hi Arnaud,

On Sun, Nov 24, 2013 at 03:08:46PM +0100, Arnaud Ebalard wrote:
> 
> As ReadyNAS 102, 104 and 2120 all depend on your driver, I decided to
> give v4 a change on a 102. As a side note, all those device have the
> same NAND chip, i.e. a 128 MB hynix H27U1G8F2BTR. Additionally, this is
> also the chip found on ReadyNAS Duo v2, which is perfectly handled by
> orion-nand driver.
> 
> With your 31 patches in my quilt set against current linus tree (w/
> 2 to 4 of 31 disabled as they are already in Linus tree), I modified
> my .dts in the following way:
> 
>  nand at d0000 {
>          status = "okay";
>          num-cs = <1>;
>          marvell,nand-keep-config;
>          marvell,nand-enable-arbiter;
>          nand-on-flash-bbt;
> 

Great! Thanks for giving NAND a chance :-)

Could you try using the devicetree snippet below?

nand at d0000 {
	/* HACK: Use legacy compatible to handle smaller pages */
	compatible = "marvell,pxa3xx-nand";
	status = "okay";
	num-cs = <1>;
	marvell,nand-keep-config;
	marvell,nand-enable-arbiter;
	nand-on-flash-bbt;

	/* partitions */
};

Please check if your device is detected and try to do some reading
first. If that works, you can try to mount the filesystem, or write
a new kernel.

If the above works, I'll prepare a proper patch.

Thanks!
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  parent reply	other threads:[~2013-11-25 12:03 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 21:25 [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-11-14 21:25 ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 01/14] mtd: nand: pxa3xx: Use a completion to signal device ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 02/14] mtd: nand: pxa3xx: Use waitfunc() to wait for the device to be ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 03/14] mtd: nand: pxa3xx: Add bad block handling Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:12   ` Brian Norris
2013-11-14 22:12     ` Brian Norris
2013-11-14 22:37     ` Ezequiel Garcia
2013-11-14 22:37       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 04/14] mtd: nand: pxa3xx: Add driver-specific ECC BCH support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 05/14] mtd: nand: pxa3xx: Clear cmd buffer #3 (NDCB3) on command start Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:18   ` Brian Norris
2013-11-14 22:18     ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 06/14] mtd: nand: pxa3xx: Add helper function to set page address Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 07/14] mtd: nand: pxa3xx: Remove READ0 switch/case falltrough Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 08/14] mtd: nand: pxa3xx: Split prepare_command_pool() in two stages Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 09/14] mtd: nand: pxa3xx: Move the data buffer clean to prepare_start_command() Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:25   ` Brian Norris
2013-11-14 22:25     ` Brian Norris
2013-11-14 22:45     ` Ezequiel Garcia
2013-11-14 22:45       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 10/14] mtd: nand: pxa3xx: Fix SEQIN column address set Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 11/14] mtd: nand: pxa3xx: Add a read/write buffers markers Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 12/14] mtd: nand: pxa3xx: Introduce multiple page I/O support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:40   ` Brian Norris
2013-11-14 22:40     ` Brian Norris
2013-11-14 23:02     ` Ezequiel Garcia
2013-11-14 23:02       ` Ezequiel Garcia
2013-11-14 23:07       ` Brian Norris
2013-11-14 23:07         ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 13/14] mtd: nand: pxa3xx: Add multiple chunk write support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 14/14] mtd: nand: pxa3xx: Add ECC BCH correctable errors detection Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 23:04 ` [PATCH v5 00/14] Armada 370/XP NAND support Brian Norris
2013-11-14 23:04   ` Brian Norris
2013-11-14 23:05   ` Brian Norris
2013-11-14 23:05     ` Brian Norris
2013-11-14 23:15     ` Ezequiel Garcia
2013-11-14 23:15       ` Ezequiel Garcia
2013-11-14 23:17       ` Brian Norris
2013-11-14 23:17         ` Brian Norris
2013-11-15  7:59       ` Daniel Mack
2013-11-15  7:59         ` Daniel Mack
2013-11-15 13:07         ` Ezequiel Garcia
2013-11-15 13:07           ` Ezequiel Garcia
2013-11-15 13:47           ` Daniel Mack
2013-11-15 13:47             ` Daniel Mack
2013-11-15 14:27             ` Ezequiel Garcia
2013-11-15 14:27               ` Ezequiel Garcia
2013-11-15 14:30               ` Daniel Mack
2013-11-15 14:30                 ` Daniel Mack
2013-11-15 18:05                 ` Brian Norris
2013-11-15 18:05                   ` Brian Norris
2013-11-15 18:35                   ` Ezequiel Garcia
2013-11-15 18:35                     ` Ezequiel Garcia
2013-11-24 14:08 ` Arnaud Ebalard
2013-11-24 14:08   ` Arnaud Ebalard
2013-11-24 14:22   ` Thomas Petazzoni
2013-11-24 14:22     ` Thomas Petazzoni
2013-11-25 12:03   ` Ezequiel Garcia [this message]
2013-11-25 12:03     ` Ezequiel Garcia
2013-11-25 23:04     ` Arnaud Ebalard
2013-11-25 23:04       ` Arnaud Ebalard
2013-11-26 12:40       ` Ezequiel Garcia
2013-11-26 12:40         ` Ezequiel Garcia
2013-11-27 20:24         ` Arnaud Ebalard
2013-11-27 20:24           ` Arnaud Ebalard
2013-11-27 20:52           ` Arnaud Ebalard
2013-11-27 20:52             ` Arnaud Ebalard
2013-11-28  7:48             ` Ricard Wanderlof
2013-11-28  7:48               ` Ricard Wanderlof
2013-11-28 18:50             ` Ezequiel Garcia
2013-11-28 18:50               ` Ezequiel Garcia
2013-11-29 23:25               ` Arnaud Ebalard
2013-11-29 23:25                 ` Arnaud Ebalard
2013-12-02 10:33                 ` Ezequiel Garcia
2013-12-02 10:33                   ` Ezequiel Garcia
2013-12-02 21:05                   ` Arnaud Ebalard
2013-12-02 21:05                     ` Arnaud Ebalard
2013-12-03  0:22                     ` Ezequiel Garcia
2013-12-03  0:22                       ` Ezequiel Garcia
2013-12-03 20:21                       ` Arnaud Ebalard
2013-12-03 20:21                         ` Arnaud Ebalard
2013-12-03 21:25                         ` Arnaud Ebalard
2013-12-03 21:25                           ` Arnaud Ebalard
2013-12-04 14:20                           ` Ezequiel Garcia
2013-12-04 14:20                             ` Ezequiel Garcia
2013-12-04 14:41                             ` Ezequiel Garcia
2013-12-04 14:41                               ` Ezequiel Garcia
2013-12-04 20:48                             ` Arnaud Ebalard
2013-12-04 20:48                               ` Arnaud Ebalard
2013-12-05 20:42                               ` Arnaud Ebalard
2013-12-05 20:42                                 ` Arnaud Ebalard
2013-12-05 22:24                                 ` [PATCH v5 00/14] Armada 370/XP NAND supportg Ezequiel Garcia
2013-12-05 22:24                                   ` Ezequiel Garcia
2013-12-06 12:56                                 ` [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-12-06 12:56                                   ` Ezequiel Garcia
2013-12-06 21:41                                   ` Arnaud Ebalard
2013-12-06 21:41                                     ` Arnaud Ebalard
2013-12-06 22:05                                     ` Ezequiel Garcia
2013-12-06 22:05                                       ` Ezequiel Garcia
2013-12-05 21:32                               ` Brian Norris
2013-12-05 21:32                                 ` Brian Norris
2013-12-05 21:23                       ` Brian Norris
2013-12-05 21:23                         ` Brian Norris
2013-12-05 22:23                         ` Ezequiel Garcia
2013-12-05 22:23                           ` Ezequiel Garcia
2013-12-05 22:45                           ` Brian Norris
2013-12-05 22:45                             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125120335.GD2408@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=alior@marvell.com \
    --cc=arno@natisbad.org \
    --cc=computersforpeace@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.