All of lore.kernel.org
 help / color / mirror / Atom feed
From: arno@natisbad.org (Arnaud Ebalard)
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-mtd@lists.infradead.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Wed, 27 Nov 2013 21:52:52 +0100	[thread overview]
Message-ID: <87wqjtbm8r.fsf@natisbad.org> (raw)
In-Reply-To: <87zjopd240.fsf@natisbad.org> (Arnaud Ebalard's message of "Wed, 27 Nov 2013 21:24:47 +0100")

Hi,

arno@natisbad.org (Arnaud Ebalard) writes:

> Well, I guess the bad block the driver put in the bbt are not that bad
> in practice, i.e. they were mistakenly marked that way. I also
> guess^Whope there is a some low level command I could use to simply
> clear the bbt (the NAND had no bad block prior to the test). Any help
> would be appreciated on that point.

Replying to myself w/ the solution: just in case it happens to someone
else, it's as simple as using flash_erase w/ -N option on a kernel
modified (in drivers/mtd/nand/nand_base.c) to allow write to a bad
block w/ the following patch:

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index bd39f7b..e70ef60 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2591,6 +2591,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
        instr->state = MTD_ERASING;
 
        while (len) {
+#if 0
                /* Check if we have a bad block, we do not erase bad blocks! */
                if (nand_block_checkbad(mtd, ((loff_t) page) <<
                                        chip->page_shift, 0, allowbbt)) {
@@ -2599,6 +2600,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
                        instr->state = MTD_ERASE_FAILED;
                        goto erase_exit;
                }
+#endif
 
                /*
                 * Invalidate the page cache, if we erase the block which


After a reboot on that modified kernel, a simple call to flash_erase
using -N option will erase the badblocks:

 # flash_erase -N /dev/mtd4 0 0 

Then, at next reboot an empty bad block table is recreated.

NAND:  (ID 0xf1ad)      128 MiB
Bad block table not found for chip 0
Bad block table not found for chip 0
Bad block table written to 0x000007fe0000, version 0x01
Bad block table written to 0x000007fc0000, version 0x01
FPU not initialized
USB 0: Host Mode
USB 1: Host Mode

Ezequiel, I am back in business to test a v2 ;-)

Cheers,

a+

ps: primary source: http://lists.infradead.org/pipermail/linux-mtd/2012-June/041969.html

WARNING: multiple messages have this Message-ID (diff)
From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Wed, 27 Nov 2013 21:52:52 +0100	[thread overview]
Message-ID: <87wqjtbm8r.fsf@natisbad.org> (raw)
In-Reply-To: <87zjopd240.fsf@natisbad.org> (Arnaud Ebalard's message of "Wed, 27 Nov 2013 21:24:47 +0100")

Hi,

arno at natisbad.org (Arnaud Ebalard) writes:

> Well, I guess the bad block the driver put in the bbt are not that bad
> in practice, i.e. they were mistakenly marked that way. I also
> guess^Whope there is a some low level command I could use to simply
> clear the bbt (the NAND had no bad block prior to the test). Any help
> would be appreciated on that point.

Replying to myself w/ the solution: just in case it happens to someone
else, it's as simple as using flash_erase w/ -N option on a kernel
modified (in drivers/mtd/nand/nand_base.c) to allow write to a bad
block w/ the following patch:

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index bd39f7b..e70ef60 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2591,6 +2591,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
        instr->state = MTD_ERASING;
 
        while (len) {
+#if 0
                /* Check if we have a bad block, we do not erase bad blocks! */
                if (nand_block_checkbad(mtd, ((loff_t) page) <<
                                        chip->page_shift, 0, allowbbt)) {
@@ -2599,6 +2600,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
                        instr->state = MTD_ERASE_FAILED;
                        goto erase_exit;
                }
+#endif
 
                /*
                 * Invalidate the page cache, if we erase the block which


After a reboot on that modified kernel, a simple call to flash_erase
using -N option will erase the badblocks:

 # flash_erase -N /dev/mtd4 0 0 

Then, at next reboot an empty bad block table is recreated.

NAND:  (ID 0xf1ad)      128 MiB
Bad block table not found for chip 0
Bad block table not found for chip 0
Bad block table written to 0x000007fe0000, version 0x01
Bad block table written to 0x000007fc0000, version 0x01
FPU not initialized
USB 0: Host Mode
USB 1: Host Mode

Ezequiel, I am back in business to test a v2 ;-)

Cheers,

a+

ps: primary source: http://lists.infradead.org/pipermail/linux-mtd/2012-June/041969.html

  reply	other threads:[~2013-11-27 20:52 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 21:25 [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-11-14 21:25 ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 01/14] mtd: nand: pxa3xx: Use a completion to signal device ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 02/14] mtd: nand: pxa3xx: Use waitfunc() to wait for the device to be ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 03/14] mtd: nand: pxa3xx: Add bad block handling Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:12   ` Brian Norris
2013-11-14 22:12     ` Brian Norris
2013-11-14 22:37     ` Ezequiel Garcia
2013-11-14 22:37       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 04/14] mtd: nand: pxa3xx: Add driver-specific ECC BCH support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 05/14] mtd: nand: pxa3xx: Clear cmd buffer #3 (NDCB3) on command start Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:18   ` Brian Norris
2013-11-14 22:18     ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 06/14] mtd: nand: pxa3xx: Add helper function to set page address Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 07/14] mtd: nand: pxa3xx: Remove READ0 switch/case falltrough Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 08/14] mtd: nand: pxa3xx: Split prepare_command_pool() in two stages Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 09/14] mtd: nand: pxa3xx: Move the data buffer clean to prepare_start_command() Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:25   ` Brian Norris
2013-11-14 22:25     ` Brian Norris
2013-11-14 22:45     ` Ezequiel Garcia
2013-11-14 22:45       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 10/14] mtd: nand: pxa3xx: Fix SEQIN column address set Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 11/14] mtd: nand: pxa3xx: Add a read/write buffers markers Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 12/14] mtd: nand: pxa3xx: Introduce multiple page I/O support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:40   ` Brian Norris
2013-11-14 22:40     ` Brian Norris
2013-11-14 23:02     ` Ezequiel Garcia
2013-11-14 23:02       ` Ezequiel Garcia
2013-11-14 23:07       ` Brian Norris
2013-11-14 23:07         ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 13/14] mtd: nand: pxa3xx: Add multiple chunk write support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 14/14] mtd: nand: pxa3xx: Add ECC BCH correctable errors detection Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 23:04 ` [PATCH v5 00/14] Armada 370/XP NAND support Brian Norris
2013-11-14 23:04   ` Brian Norris
2013-11-14 23:05   ` Brian Norris
2013-11-14 23:05     ` Brian Norris
2013-11-14 23:15     ` Ezequiel Garcia
2013-11-14 23:15       ` Ezequiel Garcia
2013-11-14 23:17       ` Brian Norris
2013-11-14 23:17         ` Brian Norris
2013-11-15  7:59       ` Daniel Mack
2013-11-15  7:59         ` Daniel Mack
2013-11-15 13:07         ` Ezequiel Garcia
2013-11-15 13:07           ` Ezequiel Garcia
2013-11-15 13:47           ` Daniel Mack
2013-11-15 13:47             ` Daniel Mack
2013-11-15 14:27             ` Ezequiel Garcia
2013-11-15 14:27               ` Ezequiel Garcia
2013-11-15 14:30               ` Daniel Mack
2013-11-15 14:30                 ` Daniel Mack
2013-11-15 18:05                 ` Brian Norris
2013-11-15 18:05                   ` Brian Norris
2013-11-15 18:35                   ` Ezequiel Garcia
2013-11-15 18:35                     ` Ezequiel Garcia
2013-11-24 14:08 ` Arnaud Ebalard
2013-11-24 14:08   ` Arnaud Ebalard
2013-11-24 14:22   ` Thomas Petazzoni
2013-11-24 14:22     ` Thomas Petazzoni
2013-11-25 12:03   ` Ezequiel Garcia
2013-11-25 12:03     ` Ezequiel Garcia
2013-11-25 23:04     ` Arnaud Ebalard
2013-11-25 23:04       ` Arnaud Ebalard
2013-11-26 12:40       ` Ezequiel Garcia
2013-11-26 12:40         ` Ezequiel Garcia
2013-11-27 20:24         ` Arnaud Ebalard
2013-11-27 20:24           ` Arnaud Ebalard
2013-11-27 20:52           ` Arnaud Ebalard [this message]
2013-11-27 20:52             ` Arnaud Ebalard
2013-11-28  7:48             ` Ricard Wanderlof
2013-11-28  7:48               ` Ricard Wanderlof
2013-11-28 18:50             ` Ezequiel Garcia
2013-11-28 18:50               ` Ezequiel Garcia
2013-11-29 23:25               ` Arnaud Ebalard
2013-11-29 23:25                 ` Arnaud Ebalard
2013-12-02 10:33                 ` Ezequiel Garcia
2013-12-02 10:33                   ` Ezequiel Garcia
2013-12-02 21:05                   ` Arnaud Ebalard
2013-12-02 21:05                     ` Arnaud Ebalard
2013-12-03  0:22                     ` Ezequiel Garcia
2013-12-03  0:22                       ` Ezequiel Garcia
2013-12-03 20:21                       ` Arnaud Ebalard
2013-12-03 20:21                         ` Arnaud Ebalard
2013-12-03 21:25                         ` Arnaud Ebalard
2013-12-03 21:25                           ` Arnaud Ebalard
2013-12-04 14:20                           ` Ezequiel Garcia
2013-12-04 14:20                             ` Ezequiel Garcia
2013-12-04 14:41                             ` Ezequiel Garcia
2013-12-04 14:41                               ` Ezequiel Garcia
2013-12-04 20:48                             ` Arnaud Ebalard
2013-12-04 20:48                               ` Arnaud Ebalard
2013-12-05 20:42                               ` Arnaud Ebalard
2013-12-05 20:42                                 ` Arnaud Ebalard
2013-12-05 22:24                                 ` [PATCH v5 00/14] Armada 370/XP NAND supportg Ezequiel Garcia
2013-12-05 22:24                                   ` Ezequiel Garcia
2013-12-06 12:56                                 ` [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-12-06 12:56                                   ` Ezequiel Garcia
2013-12-06 21:41                                   ` Arnaud Ebalard
2013-12-06 21:41                                     ` Arnaud Ebalard
2013-12-06 22:05                                     ` Ezequiel Garcia
2013-12-06 22:05                                       ` Ezequiel Garcia
2013-12-05 21:32                               ` Brian Norris
2013-12-05 21:32                                 ` Brian Norris
2013-12-05 21:23                       ` Brian Norris
2013-12-05 21:23                         ` Brian Norris
2013-12-05 22:23                         ` Ezequiel Garcia
2013-12-05 22:23                           ` Ezequiel Garcia
2013-12-05 22:45                           ` Brian Norris
2013-12-05 22:45                             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqjtbm8r.fsf@natisbad.org \
    --to=arno@natisbad.org \
    --cc=alior@marvell.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.