All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-mtd@lists.infradead.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Fri, 15 Nov 2013 14:47:22 +0100	[thread overview]
Message-ID: <528625EA.8060406@gmail.com> (raw)
In-Reply-To: <20131115130711.GA2496@localhost>

On 11/15/2013 02:07 PM, Ezequiel Garcia wrote:
> On Fri, Nov 15, 2013 at 08:59:08AM +0100, Daniel Mack wrote:
>> On 11/15/2013 12:15 AM, Ezequiel Garcia wrote:
>>> On Thu, Nov 14, 2013 at 03:05:40PM -0800, Brian Norris wrote:
>>>> + Daniel (missed the CC)
>>>>
>>>> On Thu, Nov 14, 2013 at 03:04:36PM -0800, Brian Norris wrote:
>>>>> On Thu, Nov 14, 2013 at 06:25:25PM -0300, Ezequiel Garcia wrote:
>>>>>> * Changes from v4
>>>>>>
>>>>>>   * Rebased on top of l2-mtd.git origin/next branch
>>>>>>
>>>>>>   * Fixed is_ready flag reset, renamed by a more descriptive
>>>>>>     and readble "need_wait".
>>>>>>
>>>>>
>>>>> ...
>>>>>
>>>>> I think this series is now good as-is. Pushing to l2-mtd.git/next.
>>>>> Thanks for the efforts! I can submit my extra diff from patch 12 as a
>>>>> separate patch for review.
>>>>>
>>>>> Do you have any available regression tests? Or was there somebody else
>>>>> we could run this by for some Tested-by's? Daniel Mack, perhaps?
>>>>
>>>> Brian
>>>
>>> Yes, if Daniel (or anybody else) can push a Tested-by, that's better because
>>> he's a "third-party" tester.
>>
>> Yes. Sorry, I could only partially follow all the discussions around
>> these patch sets, but I can certainly do a quick regression test on my
>> pxa3xx platform.
>>
>> Ezequiel, could you maybe point me to a repository where I can pull
>> everything from you want me to have a look at?
>>
> 
> Latest work is at the next branch in l2-mtd.git:
> 
> http://git.infradead.org/l2-mtd.git/shortlog/refs/heads/next
> 
> You could try that, with Brian's latest patch:
> 
> http://patchwork.ozlabs.org/patch/291408/

Thanks Ezequiel! Tested with and without DMA on my PXA3xx platform and
it seems to work just well. Awesome work :)

[    2.675715] NAND device: Manufacturer ID: 0x20, Chip ID: 0xa1 (ST
Micro NAND01GR3B2CZA6)
[    2.683965] NAND device: 128MiB, SLC, page size: 2048, OOB size: 64
[    2.690867] Scanning device for bad blocks
[    2.977987] Bad eraseblock 528 at 0x000004200000
[    2.983394] Bad eraseblock 529 at 0x000004220000
[    3.251150] 4 ofpart partitions found on MTD device pxa3xx_nand-0
[    3.257313] Creating 4 MTD partitions on "pxa3xx_nand-0":
[    3.263051] 0x000000000000-0x0000000a0000 : "Bootloader"
[    3.278845] 0x0000000a0000-0x0000000c0000 : "BootloaderEnvironment"
[    3.296388] 0x0000000c0000-0x000000120000 : "BootloaderSplashScreen"
[    3.314704] 0x000000120000-0x000008000000 : "UBI"



Best regards,
Daniel

WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/14] Armada 370/XP NAND support
Date: Fri, 15 Nov 2013 14:47:22 +0100	[thread overview]
Message-ID: <528625EA.8060406@gmail.com> (raw)
In-Reply-To: <20131115130711.GA2496@localhost>

On 11/15/2013 02:07 PM, Ezequiel Garcia wrote:
> On Fri, Nov 15, 2013 at 08:59:08AM +0100, Daniel Mack wrote:
>> On 11/15/2013 12:15 AM, Ezequiel Garcia wrote:
>>> On Thu, Nov 14, 2013 at 03:05:40PM -0800, Brian Norris wrote:
>>>> + Daniel (missed the CC)
>>>>
>>>> On Thu, Nov 14, 2013 at 03:04:36PM -0800, Brian Norris wrote:
>>>>> On Thu, Nov 14, 2013 at 06:25:25PM -0300, Ezequiel Garcia wrote:
>>>>>> * Changes from v4
>>>>>>
>>>>>>   * Rebased on top of l2-mtd.git origin/next branch
>>>>>>
>>>>>>   * Fixed is_ready flag reset, renamed by a more descriptive
>>>>>>     and readble "need_wait".
>>>>>>
>>>>>
>>>>> ...
>>>>>
>>>>> I think this series is now good as-is. Pushing to l2-mtd.git/next.
>>>>> Thanks for the efforts! I can submit my extra diff from patch 12 as a
>>>>> separate patch for review.
>>>>>
>>>>> Do you have any available regression tests? Or was there somebody else
>>>>> we could run this by for some Tested-by's? Daniel Mack, perhaps?
>>>>
>>>> Brian
>>>
>>> Yes, if Daniel (or anybody else) can push a Tested-by, that's better because
>>> he's a "third-party" tester.
>>
>> Yes. Sorry, I could only partially follow all the discussions around
>> these patch sets, but I can certainly do a quick regression test on my
>> pxa3xx platform.
>>
>> Ezequiel, could you maybe point me to a repository where I can pull
>> everything from you want me to have a look at?
>>
> 
> Latest work is at the next branch in l2-mtd.git:
> 
> http://git.infradead.org/l2-mtd.git/shortlog/refs/heads/next
> 
> You could try that, with Brian's latest patch:
> 
> http://patchwork.ozlabs.org/patch/291408/

Thanks Ezequiel! Tested with and without DMA on my PXA3xx platform and
it seems to work just well. Awesome work :)

[    2.675715] NAND device: Manufacturer ID: 0x20, Chip ID: 0xa1 (ST
Micro NAND01GR3B2CZA6)
[    2.683965] NAND device: 128MiB, SLC, page size: 2048, OOB size: 64
[    2.690867] Scanning device for bad blocks
[    2.977987] Bad eraseblock 528 at 0x000004200000
[    2.983394] Bad eraseblock 529 at 0x000004220000
[    3.251150] 4 ofpart partitions found on MTD device pxa3xx_nand-0
[    3.257313] Creating 4 MTD partitions on "pxa3xx_nand-0":
[    3.263051] 0x000000000000-0x0000000a0000 : "Bootloader"
[    3.278845] 0x0000000a0000-0x0000000c0000 : "BootloaderEnvironment"
[    3.296388] 0x0000000c0000-0x000000120000 : "BootloaderSplashScreen"
[    3.314704] 0x000000120000-0x000008000000 : "UBI"



Best regards,
Daniel

  reply	other threads:[~2013-11-15 13:47 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 21:25 [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-11-14 21:25 ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 01/14] mtd: nand: pxa3xx: Use a completion to signal device ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 02/14] mtd: nand: pxa3xx: Use waitfunc() to wait for the device to be ready Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 03/14] mtd: nand: pxa3xx: Add bad block handling Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:12   ` Brian Norris
2013-11-14 22:12     ` Brian Norris
2013-11-14 22:37     ` Ezequiel Garcia
2013-11-14 22:37       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 04/14] mtd: nand: pxa3xx: Add driver-specific ECC BCH support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 05/14] mtd: nand: pxa3xx: Clear cmd buffer #3 (NDCB3) on command start Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:18   ` Brian Norris
2013-11-14 22:18     ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 06/14] mtd: nand: pxa3xx: Add helper function to set page address Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 07/14] mtd: nand: pxa3xx: Remove READ0 switch/case falltrough Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 08/14] mtd: nand: pxa3xx: Split prepare_command_pool() in two stages Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 09/14] mtd: nand: pxa3xx: Move the data buffer clean to prepare_start_command() Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:25   ` Brian Norris
2013-11-14 22:25     ` Brian Norris
2013-11-14 22:45     ` Ezequiel Garcia
2013-11-14 22:45       ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 10/14] mtd: nand: pxa3xx: Fix SEQIN column address set Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 11/14] mtd: nand: pxa3xx: Add a read/write buffers markers Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 12/14] mtd: nand: pxa3xx: Introduce multiple page I/O support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 22:40   ` Brian Norris
2013-11-14 22:40     ` Brian Norris
2013-11-14 23:02     ` Ezequiel Garcia
2013-11-14 23:02       ` Ezequiel Garcia
2013-11-14 23:07       ` Brian Norris
2013-11-14 23:07         ` Brian Norris
2013-11-14 21:25 ` [PATCH v5 13/14] mtd: nand: pxa3xx: Add multiple chunk write support Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 21:25 ` [PATCH v5 14/14] mtd: nand: pxa3xx: Add ECC BCH correctable errors detection Ezequiel Garcia
2013-11-14 21:25   ` Ezequiel Garcia
2013-11-14 23:04 ` [PATCH v5 00/14] Armada 370/XP NAND support Brian Norris
2013-11-14 23:04   ` Brian Norris
2013-11-14 23:05   ` Brian Norris
2013-11-14 23:05     ` Brian Norris
2013-11-14 23:15     ` Ezequiel Garcia
2013-11-14 23:15       ` Ezequiel Garcia
2013-11-14 23:17       ` Brian Norris
2013-11-14 23:17         ` Brian Norris
2013-11-15  7:59       ` Daniel Mack
2013-11-15  7:59         ` Daniel Mack
2013-11-15 13:07         ` Ezequiel Garcia
2013-11-15 13:07           ` Ezequiel Garcia
2013-11-15 13:47           ` Daniel Mack [this message]
2013-11-15 13:47             ` Daniel Mack
2013-11-15 14:27             ` Ezequiel Garcia
2013-11-15 14:27               ` Ezequiel Garcia
2013-11-15 14:30               ` Daniel Mack
2013-11-15 14:30                 ` Daniel Mack
2013-11-15 18:05                 ` Brian Norris
2013-11-15 18:05                   ` Brian Norris
2013-11-15 18:35                   ` Ezequiel Garcia
2013-11-15 18:35                     ` Ezequiel Garcia
2013-11-24 14:08 ` Arnaud Ebalard
2013-11-24 14:08   ` Arnaud Ebalard
2013-11-24 14:22   ` Thomas Petazzoni
2013-11-24 14:22     ` Thomas Petazzoni
2013-11-25 12:03   ` Ezequiel Garcia
2013-11-25 12:03     ` Ezequiel Garcia
2013-11-25 23:04     ` Arnaud Ebalard
2013-11-25 23:04       ` Arnaud Ebalard
2013-11-26 12:40       ` Ezequiel Garcia
2013-11-26 12:40         ` Ezequiel Garcia
2013-11-27 20:24         ` Arnaud Ebalard
2013-11-27 20:24           ` Arnaud Ebalard
2013-11-27 20:52           ` Arnaud Ebalard
2013-11-27 20:52             ` Arnaud Ebalard
2013-11-28  7:48             ` Ricard Wanderlof
2013-11-28  7:48               ` Ricard Wanderlof
2013-11-28 18:50             ` Ezequiel Garcia
2013-11-28 18:50               ` Ezequiel Garcia
2013-11-29 23:25               ` Arnaud Ebalard
2013-11-29 23:25                 ` Arnaud Ebalard
2013-12-02 10:33                 ` Ezequiel Garcia
2013-12-02 10:33                   ` Ezequiel Garcia
2013-12-02 21:05                   ` Arnaud Ebalard
2013-12-02 21:05                     ` Arnaud Ebalard
2013-12-03  0:22                     ` Ezequiel Garcia
2013-12-03  0:22                       ` Ezequiel Garcia
2013-12-03 20:21                       ` Arnaud Ebalard
2013-12-03 20:21                         ` Arnaud Ebalard
2013-12-03 21:25                         ` Arnaud Ebalard
2013-12-03 21:25                           ` Arnaud Ebalard
2013-12-04 14:20                           ` Ezequiel Garcia
2013-12-04 14:20                             ` Ezequiel Garcia
2013-12-04 14:41                             ` Ezequiel Garcia
2013-12-04 14:41                               ` Ezequiel Garcia
2013-12-04 20:48                             ` Arnaud Ebalard
2013-12-04 20:48                               ` Arnaud Ebalard
2013-12-05 20:42                               ` Arnaud Ebalard
2013-12-05 20:42                                 ` Arnaud Ebalard
2013-12-05 22:24                                 ` [PATCH v5 00/14] Armada 370/XP NAND supportg Ezequiel Garcia
2013-12-05 22:24                                   ` Ezequiel Garcia
2013-12-06 12:56                                 ` [PATCH v5 00/14] Armada 370/XP NAND support Ezequiel Garcia
2013-12-06 12:56                                   ` Ezequiel Garcia
2013-12-06 21:41                                   ` Arnaud Ebalard
2013-12-06 21:41                                     ` Arnaud Ebalard
2013-12-06 22:05                                     ` Ezequiel Garcia
2013-12-06 22:05                                       ` Ezequiel Garcia
2013-12-05 21:32                               ` Brian Norris
2013-12-05 21:32                                 ` Brian Norris
2013-12-05 21:23                       ` Brian Norris
2013-12-05 21:23                         ` Brian Norris
2013-12-05 22:23                         ` Ezequiel Garcia
2013-12-05 22:23                           ` Ezequiel Garcia
2013-12-05 22:45                           ` Brian Norris
2013-12-05 22:45                             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528625EA.8060406@gmail.com \
    --to=zonque@gmail.com \
    --cc=alior@marvell.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.