From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Namhyung Kim <namhyung@kernel.org>, Gaurav Jain <gjain@fb.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf tools: Fix JIT profiling on heap
Date: Tue, 21 Jan 2014 15:16:21 +0100 [thread overview]
Message-ID: <20140121141621.GC4559@gmail.com> (raw)
In-Reply-To: <20140121135552.GD18027@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> > Right. But in this case we cannot determine whether a symbol in
> > the /tmp/perf-... file is a function or variable.
>
> That is why we would then need to have separate /tmp/perf-... files,
> disambiguated by an extension, one for text addresses, another for
> data ones.
>
> Or change the format to match /proc/kallsyms, which probably is what
> we should've done from day one...
Yeah. Using the same format would be lovely. The parser could try to
detect the new one and could fall back to the old format?
> Detecting the format change would be trivial, as we would find 3
> tokens in the new format, instead of the current 2.
Yeah!
Thanks,
Ingo
next prev parent reply other threads:[~2014-01-21 14:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 1:49 [PATCH] perf tools: Fix JIT profiling on heap Namhyung Kim
2014-01-16 14:37 ` Arnaldo Carvalho de Melo
2014-01-16 20:23 ` Gaurav Jain
2014-01-17 7:44 ` Namhyung Kim
2014-01-17 14:34 ` Arnaldo Carvalho de Melo
2014-01-21 5:54 ` Namhyung Kim
2014-01-21 13:55 ` Arnaldo Carvalho de Melo
2014-01-21 14:16 ` Ingo Molnar [this message]
2014-01-22 23:43 ` Gaurav Jain
2014-01-22 23:50 ` Namhyung Kim
2014-01-23 17:04 ` [tip:perf/urgent] perf symbols: Fix JIT symbol resolution " tip-bot for Namhyung Kim
2014-01-31 11:50 ` [PATCH] perf tools: Fix JIT profiling " Pekka Enberg
2014-01-31 15:04 ` Arnaldo Carvalho de Melo
2014-01-31 20:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121141621.GC4559@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=gjain@fb.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.