All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaurav Jain <gjain@fb.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] perf tools: Fix JIT profiling on heap
Date: Thu, 16 Jan 2014 20:23:27 +0000	[thread overview]
Message-ID: <CEFDA8E4.2D359%gjain@fb.com> (raw)
In-Reply-To: <20140116143749.GA21526@ghostprotocols.net>

On 1/16/14, 9:37 AM, "Arnaldo Carvalho de Melo" <acme@ghostprotocols.net>
wrote:

>Em Thu, Jan 16, 2014 at 10:49:31AM +0900, Namhyung Kim escreveu:
>> Gaurav reported that perf cannot profile JIT program if it executes
>> the code on heap.  This was because current map__new() only handle JIT
>> on anon mappings - extends it to handle no_dso (heap, stack) case too.
>> 
>> This patch assumes JIT profiling only provides dynamic function
>> symbols so check the mapping type to distinguish the case.  It'd
>> provide no symbols for data mapping - if we need to support symbols on
>> data mappings later it should be changed.
>
>But we do support symbols in data mappings, that is why we have
>MAP__VARIABLE, etc, can you elaborate?

Does perf support data mappings from perf map files? Could you please
share an example of how I may be able to use this.

>Gaurav, do this fixes the problem you reported? Can I have your
>Tested-by: tag?

Yep, I¹ve tested this version of the patch and it works great for me.

Thanks,

Gaurav


  reply	other threads:[~2014-01-16 20:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16  1:49 [PATCH] perf tools: Fix JIT profiling on heap Namhyung Kim
2014-01-16 14:37 ` Arnaldo Carvalho de Melo
2014-01-16 20:23   ` Gaurav Jain [this message]
2014-01-17  7:44     ` Namhyung Kim
2014-01-17 14:34       ` Arnaldo Carvalho de Melo
2014-01-21  5:54         ` Namhyung Kim
2014-01-21 13:55           ` Arnaldo Carvalho de Melo
2014-01-21 14:16             ` Ingo Molnar
2014-01-22 23:43       ` Gaurav Jain
2014-01-22 23:50         ` Namhyung Kim
2014-01-23 17:04 ` [tip:perf/urgent] perf symbols: Fix JIT symbol resolution " tip-bot for Namhyung Kim
2014-01-31 11:50 ` [PATCH] perf tools: Fix JIT profiling " Pekka Enberg
2014-01-31 15:04   ` Arnaldo Carvalho de Melo
2014-01-31 20:29     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CEFDA8E4.2D359%gjain@fb.com \
    --to=gjain@fb.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.