Re: [PATCH] perf tools: Fix JIT profiling on heap

[Pekka Enberg <penberg@iki.fi>]

On 01/31/2014 05:04 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 31, 2014 at 01:50:27PM +0200, Pekka Enberg escreveu:
>> On 01/16/2014 03:49 AM, Namhyung Kim wrote:
>>> Gaurav reported that perf cannot profile JIT program if it executes
>>> the code on heap.  This was because current map__new() only handle JIT
>>> on anon mappings - extends it to handle no_dso (heap, stack) case too.
>>>
>>> This patch assumes JIT profiling only provides dynamic function
>>> symbols so check the mapping type to distinguish the case.  It'd
>>> provide no symbols for data mapping - if we need to support symbols on
>>> data mappings later it should be changed.
>>>
>>> Reported-by: Gaurav Jain <gjain@fb.com>
>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>> Looks OK to me.  Gaurav, does this fix your problem?
> Yes, he tested it, etc, its already in Linus' tree:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/tools/perf/util/map.c?id=578c03c86fadcc6fd7319ddf41dd4d1d88aab77a

Oh, great! I was going through my inbox and didn't notice it because I 
got dropped from the CC list. :-)

Thanks Arnaldo!

                             Pekka