Re: [PATCH] perf tools: Fix JIT profiling on heap

[Arnaldo Carvalho de Melo <acme@ghostprotocols.net>]

Em Fri, Jan 31, 2014 at 01:50:27PM +0200, Pekka Enberg escreveu:
> On 01/16/2014 03:49 AM, Namhyung Kim wrote:
> >Gaurav reported that perf cannot profile JIT program if it executes
> >the code on heap.  This was because current map__new() only handle JIT
> >on anon mappings - extends it to handle no_dso (heap, stack) case too.
> >
> >This patch assumes JIT profiling only provides dynamic function
> >symbols so check the mapping type to distinguish the case.  It'd
> >provide no symbols for data mapping - if we need to support symbols on
> >data mappings later it should be changed.
> >
> >Reported-by: Gaurav Jain <gjain@fb.com>
> >Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> 
> Looks OK to me.  Gaurav, does this fix your problem?

Yes, he tested it, etc, its already in Linus' tree:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/tools/perf/util/map.c?id=578c03c86fadcc6fd7319ddf41dd4d1d88aab77a

- Arnaldo
 
> >---
> >  tools/perf/util/map.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> >index 9b9bd719aa19..ee1dd687a262 100644
> >--- a/tools/perf/util/map.c
> >+++ b/tools/perf/util/map.c
> >@@ -69,7 +69,7 @@ struct map *map__new(struct list_head *dsos__list, u64 start, u64 len,
> >  		map->ino = ino;
> >  		map->ino_generation = ino_gen;
> >-		if (anon) {
> >+		if ((anon || no_dso) && type == MAP__FUNCTION) {
> >  			snprintf(newfilename, sizeof(newfilename), "/tmp/perf-%d.map", pid);
> >  			filename = newfilename;
> >  		}
> >@@ -93,7 +93,7 @@ struct map *map__new(struct list_head *dsos__list, u64 start, u64 len,
> >  			 * functions still return NULL, and we avoid the
> >  			 * unnecessary map__load warning.
> >  			 */
> >-			if (no_dso)
> >+			if (type != MAP__FUNCTION)
> >  				dso__set_loaded(dso, map->type);
> >  		}
> >  	}