From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>, Steve French <sfrench@samba.org>,
Sage Weil <sage@inktank.com>, Dave Kleikamp <shaggy@kernel.org>,
Mark Fasheh <mfasheh@suse.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
Joel Becker <jlbec@evilplan.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Anton Altaparmakov <anton@tuxera.com>
Subject: Re: [RFC] unifying write variants for filesystems
Date: Sun, 2 Feb 2014 02:02:38 +0000 [thread overview]
Message-ID: <20140202020238.GT10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFxtfMZ82CUmxFKb1zqB2Qy9JAztpPYXgimzya653NY3Og@mail.gmail.com>
On Sat, Feb 01, 2014 at 04:13:36PM -0800, Linus Torvalds wrote:
> On Sat, Feb 1, 2014 at 2:43 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > BTW, Linus, when did you comment on that patchset? I've found an iteration
> > of that patchset circa last October (v9, apparently the latest posted),
> > but it looks like your comments had either got lost or had been on the
> > earlier iteration of that thing...
>
> I commented on the pull request in November. Something like this:
>
> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/02278.html
>
> and then I have a follow-up in a reply to that that at least outlines
> a few things that could be done to make it less barfy.
>
> But judging from your email, you actually went through that
> patch-series with a finer comb, I don't think there is anything in
> that commentary of mine that adds anything to yours, apart on a
> comment on the naming that I hated.
Heh... You've actually been a lot more polite than what I started to
write on that particular topic. Mine had started with "folks, identifiers
should be possible to read aloud, without the people around getting nervous.
I mean, ai,ai-ai,owwie-...?" and then got so nasty that I decided to leave
the whole thing alone.
But yes, references to the importance of remembering the safeword aside,
the naming is really atrocious.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Mark Fasheh <mfasheh@suse.com>,
Joel Becker <jlbec@evilplan.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
xfs@oss.sgi.com, Sage Weil <sage@inktank.com>,
Steve French <sfrench@samba.org>,
Dave Kleikamp <shaggy@kernel.org>,
Anton Altaparmakov <anton@tuxera.com>
Subject: Re: [RFC] unifying write variants for filesystems
Date: Sun, 2 Feb 2014 02:02:38 +0000 [thread overview]
Message-ID: <20140202020238.GT10323@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFxtfMZ82CUmxFKb1zqB2Qy9JAztpPYXgimzya653NY3Og@mail.gmail.com>
On Sat, Feb 01, 2014 at 04:13:36PM -0800, Linus Torvalds wrote:
> On Sat, Feb 1, 2014 at 2:43 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > BTW, Linus, when did you comment on that patchset? I've found an iteration
> > of that patchset circa last October (v9, apparently the latest posted),
> > but it looks like your comments had either got lost or had been on the
> > earlier iteration of that thing...
>
> I commented on the pull request in November. Something like this:
>
> http://lkml.indiana.edu/hypermail/linux/kernel/1311.2/02278.html
>
> and then I have a follow-up in a reply to that that at least outlines
> a few things that could be done to make it less barfy.
>
> But judging from your email, you actually went through that
> patch-series with a finer comb, I don't think there is anything in
> that commentary of mine that adds anything to yours, apart on a
> comment on the naming that I hated.
Heh... You've actually been a lot more polite than what I started to
write on that particular topic. Mine had started with "folks, identifiers
should be possible to read aloud, without the people around getting nervous.
I mean, ai,ai-ai,owwie-...?" and then got so nasty that I decided to leave
the whole thing alone.
But yes, references to the importance of remembering the safeword aside,
the naming is really atrocious.
next prev parent reply other threads:[~2014-02-02 2:02 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 18:14 [PATCH 0/5] splice: locking changes and code refactoring Christoph Hellwig
2013-12-12 18:14 ` Christoph Hellwig
2013-12-12 18:15 ` [PATCH 1/5] splice: move balance_dirty_pages_ratelimited into pipe_to_file Christoph Hellwig
2013-12-12 18:15 ` Christoph Hellwig
2013-12-12 18:15 ` [PATCH 2/5] splice: nest i_mutex outside pipe_lock Christoph Hellwig
2013-12-12 18:15 ` Christoph Hellwig
2013-12-12 18:15 ` [PATCH 3/5] splice: use splice_from_pipe in generic_file_splice_write Christoph Hellwig
2013-12-12 18:15 ` Christoph Hellwig
2013-12-12 18:15 ` [PATCH 4/5] xfs: fix splice_write locking Christoph Hellwig
2013-12-12 18:15 ` Christoph Hellwig
2013-12-12 18:15 ` [PATCH 5/5] splice: stop exporting splice_from_pipe implementation details Christoph Hellwig
2013-12-12 18:15 ` Christoph Hellwig
2014-01-13 14:14 ` [PATCH 0/5] splice: locking changes and code refactoring Christoph Hellwig
2014-01-13 14:14 ` Christoph Hellwig
2014-01-13 23:56 ` Al Viro
2014-01-13 23:56 ` Al Viro
2014-01-14 13:22 ` Christoph Hellwig
2014-01-14 13:22 ` Christoph Hellwig
2014-01-14 17:20 ` Al Viro
2014-01-14 17:20 ` Al Viro
2014-01-15 18:10 ` Al Viro
2014-01-15 18:10 ` Al Viro
2014-01-18 6:40 ` Al Viro
2014-01-18 7:22 ` Linus Torvalds
2014-01-18 7:22 ` Linus Torvalds
2014-01-18 7:46 ` Al Viro
2014-01-18 7:56 ` Al Viro
2014-01-18 7:56 ` Al Viro
2014-01-18 8:27 ` Al Viro
2014-01-18 8:44 ` David Miller
2014-01-18 8:44 ` David Miller
2014-02-07 17:10 ` Al Viro
2014-02-07 17:10 ` Al Viro
2014-01-18 19:59 ` Linus Torvalds
2014-01-18 20:10 ` Al Viro
2014-01-18 20:27 ` Al Viro
2014-01-18 20:27 ` Al Viro
2014-01-18 20:30 ` Al Viro
2014-01-18 20:30 ` Al Viro
2014-01-19 5:13 ` [RFC] unifying write variants for filesystems Al Viro
2014-01-19 5:13 ` Al Viro
2014-01-20 13:55 ` Christoph Hellwig
2014-01-20 13:55 ` Christoph Hellwig
2014-01-20 20:32 ` Linus Torvalds
2014-01-20 20:32 ` Linus Torvalds
2014-02-01 22:43 ` Al Viro
2014-02-01 22:43 ` Al Viro
2014-02-02 0:13 ` Linus Torvalds
2014-02-02 2:02 ` Al Viro [this message]
2014-02-02 2:02 ` Al Viro
2014-02-02 19:21 ` Al Viro
2014-02-02 19:21 ` Al Viro
2014-02-02 19:23 ` Al Viro
2014-02-02 19:23 ` Al Viro
2014-02-03 14:41 ` Miklos Szeredi
2014-02-03 14:41 ` Miklos Szeredi
2014-02-03 15:33 ` Al Viro
2014-02-03 15:33 ` Al Viro
2014-02-02 23:16 ` Anton Altaparmakov
2014-02-02 23:16 ` Anton Altaparmakov
2014-02-03 15:12 ` Christoph Hellwig
2014-02-03 16:24 ` Al Viro
2014-02-03 16:50 ` Dave Kleikamp
2014-02-03 16:23 ` Dave Kleikamp
2014-02-04 12:44 ` Al Viro
2014-02-04 12:44 ` Al Viro
2014-02-04 12:52 ` Kent Overstreet
2014-02-04 12:52 ` Kent Overstreet
2014-02-04 15:17 ` Al Viro
2014-02-04 15:17 ` Al Viro
2014-02-04 17:27 ` Zach Brown
2014-02-04 17:35 ` Kent Overstreet
2014-02-04 18:08 ` Al Viro
2014-02-04 18:08 ` Al Viro
2014-02-04 18:00 ` Al Viro
2014-02-04 18:00 ` Al Viro
2014-02-04 18:33 ` Zach Brown
2014-02-04 18:36 ` Al Viro
2014-02-04 18:36 ` Al Viro
2014-02-05 19:58 ` Al Viro
2014-02-05 20:42 ` Zach Brown
2014-02-06 9:08 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202020238.GT10323@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton@tuxera.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=sage@inktank.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.