All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform
Date: Wed, 12 Feb 2014 15:56:13 +0100	[thread overview]
Message-ID: <20140212145613.GA9812@lukather> (raw)
In-Reply-To: <52FA4118.2030100@redhat.com>

On Tue, Feb 11, 2014 at 04:26:16PM +0100, Hans de Goede wrote:
> > I'm even OK with removing "usb-ehci" and "usb-ohci" compatibles
> > from all OMAP dts files since they aren't really compatible with
> > the original PPC driver.
> 
> I don't think that is necessary, as your grep has shown there are a
> lot of dts files using compatible = "foo", "usb-?hci"; and some may
> even have the dts in firmware, so we should simply make sure not to
> break such dts.

For these devices, we can't do much, but at least for the DT that are
in Linux, relying on the fact that there is no driver having a
compatible of "usb-ehci" to work looks very fragile. I'd be in favour
of removing it from the OMAP DTs, and every affected DTs.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140212/bac7bc59/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
	Florian Fainelli
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: Re: [PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform
Date: Wed, 12 Feb 2014 15:56:13 +0100	[thread overview]
Message-ID: <20140212145613.GA9812@lukather> (raw)
In-Reply-To: <52FA4118.2030100-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Tue, Feb 11, 2014 at 04:26:16PM +0100, Hans de Goede wrote:
> > I'm even OK with removing "usb-ehci" and "usb-ohci" compatibles
> > from all OMAP dts files since they aren't really compatible with
> > the original PPC driver.
> 
> I don't think that is necessary, as your grep has shown there are a
> lot of dts files using compatible = "foo", "usb-?hci"; and some may
> even have the dts in firmware, so we should simply make sure not to
> break such dts.

For these devices, we can't do much, but at least for the DT that are
in Linux, relying on the fact that there is no driver having a
compatible of "usb-ehci" to work looks very fragile. I'd be in favour
of removing it from the OMAP DTs, and every affected DTs.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-02-12 14:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 14:10 ohci-/ehci-platform: Change compatible string to ?hci-platform Hans de Goede
2014-02-11 14:10 ` Hans de Goede
2014-02-11 14:10 ` [PATCH 1/2] ohci-platform: Change compatible string from usb-ohci to ohci-platform Hans de Goede
2014-02-11 14:10   ` Hans de Goede
2014-02-11 15:06   ` Kumar Gala
2014-02-11 15:06     ` Kumar Gala
2014-02-11 15:21     ` Hans de Goede
2014-02-11 15:21       ` Hans de Goede
2014-02-11 15:34       ` Kumar Gala
2014-02-11 15:34         ` Kumar Gala
2014-02-11 14:10 ` [PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform Hans de Goede
2014-02-11 14:10   ` Hans de Goede
2014-02-11 15:00   ` Roger Quadros
2014-02-11 15:00     ` Roger Quadros
2014-02-11 15:26     ` Hans de Goede
2014-02-11 15:26       ` Hans de Goede
2014-02-12 14:56       ` Maxime Ripard [this message]
2014-02-12 14:56         ` Maxime Ripard
2014-02-11 15:27 ` ohci-/ehci-platform: Change compatible string to ?hci-platform Alan Stern
2014-02-11 15:27   ` Alan Stern
2014-02-11 15:43   ` Arnd Bergmann
2014-02-11 15:43     ` Arnd Bergmann
2014-02-11 15:54     ` Hans de Goede
2014-02-11 15:54       ` Hans de Goede
2014-02-11 17:01     ` Florian Fainelli
2014-02-11 17:01       ` Florian Fainelli
2014-02-11 17:04       ` Hans de Goede
2014-02-11 17:04         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140212145613.GA9812@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.