From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: ohci-/ehci-platform: Change compatible string to ?hci-platform
Date: Tue, 11 Feb 2014 16:54:28 +0100 [thread overview]
Message-ID: <52FA47B4.50507@redhat.com> (raw)
In-Reply-To: <1635726.gc3dEs0zOi@wuerfel>
Hi,
On 02/11/2014 04:43 PM, Arnd Bergmann wrote:
> On Tuesday 11 February 2014 10:27:12 Alan Stern wrote:
>>
>> It might even be a good idea to change the "xhci-platform" string to
>> match, it that doesn't cause too much trouble.
>
> The original xhci binding was contributed by Al Cooper, but I don't
> see any dts files using it. I agree that xhci-generic is a better
> name than xhci-platform, and I think we should make that the recommended
> string. If Al or someone thinks the xhci-generic string might already
> be used in production devices, we should however allow both names
> in the binding and in the driver.
I can live with generic as pre/post fix. Looking at what seems to
be the common trend I believe it should be a pre-fix and nost a post-fix
though.
The common way to build a compatible string seems to be:
vendor,soc_model-function. We have a few deviations from this in the
usb bindings, but ie the interrupt-controller bindings use this
structure for the compatible strings everywhere.
So since generic has no vendor, we fill just the soc_model-function
part leading to:
generic-ohci
generic-ehci
And possible also:
generic-uhci
generic-xhci
So I'm going to respin my 2 fixup patches to move from ?hci-platform
to generic-?hci.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Al Cooper <alcooperx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: ohci-/ehci-platform: Change compatible string to ?hci-platform
Date: Tue, 11 Feb 2014 16:54:28 +0100 [thread overview]
Message-ID: <52FA47B4.50507@redhat.com> (raw)
In-Reply-To: <1635726.gc3dEs0zOi@wuerfel>
Hi,
On 02/11/2014 04:43 PM, Arnd Bergmann wrote:
> On Tuesday 11 February 2014 10:27:12 Alan Stern wrote:
>>
>> It might even be a good idea to change the "xhci-platform" string to
>> match, it that doesn't cause too much trouble.
>
> The original xhci binding was contributed by Al Cooper, but I don't
> see any dts files using it. I agree that xhci-generic is a better
> name than xhci-platform, and I think we should make that the recommended
> string. If Al or someone thinks the xhci-generic string might already
> be used in production devices, we should however allow both names
> in the binding and in the driver.
I can live with generic as pre/post fix. Looking at what seems to
be the common trend I believe it should be a pre-fix and nost a post-fix
though.
The common way to build a compatible string seems to be:
vendor,soc_model-function. We have a few deviations from this in the
usb bindings, but ie the interrupt-controller bindings use this
structure for the compatible strings everywhere.
So since generic has no vendor, we fill just the soc_model-function
part leading to:
generic-ohci
generic-ehci
And possible also:
generic-uhci
generic-xhci
So I'm going to respin my 2 fixup patches to move from ?hci-platform
to generic-?hci.
Regards,
Hans
next prev parent reply other threads:[~2014-02-11 15:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 14:10 ohci-/ehci-platform: Change compatible string to ?hci-platform Hans de Goede
2014-02-11 14:10 ` Hans de Goede
2014-02-11 14:10 ` [PATCH 1/2] ohci-platform: Change compatible string from usb-ohci to ohci-platform Hans de Goede
2014-02-11 14:10 ` Hans de Goede
2014-02-11 15:06 ` Kumar Gala
2014-02-11 15:06 ` Kumar Gala
2014-02-11 15:21 ` Hans de Goede
2014-02-11 15:21 ` Hans de Goede
2014-02-11 15:34 ` Kumar Gala
2014-02-11 15:34 ` Kumar Gala
2014-02-11 14:10 ` [PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform Hans de Goede
2014-02-11 14:10 ` Hans de Goede
2014-02-11 15:00 ` Roger Quadros
2014-02-11 15:00 ` Roger Quadros
2014-02-11 15:26 ` Hans de Goede
2014-02-11 15:26 ` Hans de Goede
2014-02-12 14:56 ` Maxime Ripard
2014-02-12 14:56 ` Maxime Ripard
2014-02-11 15:27 ` ohci-/ehci-platform: Change compatible string to ?hci-platform Alan Stern
2014-02-11 15:27 ` Alan Stern
2014-02-11 15:43 ` Arnd Bergmann
2014-02-11 15:43 ` Arnd Bergmann
2014-02-11 15:54 ` Hans de Goede [this message]
2014-02-11 15:54 ` Hans de Goede
2014-02-11 17:01 ` Florian Fainelli
2014-02-11 17:01 ` Florian Fainelli
2014-02-11 17:04 ` Hans de Goede
2014-02-11 17:04 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA47B4.50507@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.