All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com, Al Viro <viro@zeniv.linux.org.uk>,
	Oleg Nesterov <oleg@redhat.com>, Dave Jones <davej@redhat.com>
Subject: Re: 3.14-rc2 XFS backtrace because irqs_disabled.
Date: Fri, 14 Feb 2014 08:13:02 -0800	[thread overview]
Message-ID: <20140214161302.GA16416@infradead.org> (raw)
In-Reply-To: <CA+55aFyobyUNFo=3rpdbxTqgV7OQetCKbCfwEEbgxUcT-1+30w@mail.gmail.com>

On Wed, Feb 12, 2014 at 01:32:55PM -0800, Linus Torvalds wrote:
> We'd have to teach each user of "dequeue_signal()" to free the siginfo
> thing. Which shouldn't be too bad - I think we've collected all of
> that into generic code, and there isn't the mass or architecture code
> that knows about these things any more. But there are a few odd
> drivers etc and signalfd.

The few odd drivers are nbd, jffs2 and the usb mass storage gadget.
All of these have in common that they try to handle signals in a kernel
thread (which we don't even allow by default), and that they ignore the
siginfo.  I think they could mostly be replaced by an addition to the
kthread API to allow a kthread to be killed by signals for legacy
reasons.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Oleg Nesterov <oleg@redhat.com>, Dave Jones <davej@redhat.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: Re: 3.14-rc2 XFS backtrace because irqs_disabled.
Date: Fri, 14 Feb 2014 08:13:02 -0800	[thread overview]
Message-ID: <20140214161302.GA16416@infradead.org> (raw)
In-Reply-To: <CA+55aFyobyUNFo=3rpdbxTqgV7OQetCKbCfwEEbgxUcT-1+30w@mail.gmail.com>

On Wed, Feb 12, 2014 at 01:32:55PM -0800, Linus Torvalds wrote:
> We'd have to teach each user of "dequeue_signal()" to free the siginfo
> thing. Which shouldn't be too bad - I think we've collected all of
> that into generic code, and there isn't the mass or architecture code
> that knows about these things any more. But there are a few odd
> drivers etc and signalfd.

The few odd drivers are nbd, jffs2 and the usb mass storage gadget.
All of these have in common that they try to handle signals in a kernel
thread (which we don't even allow by default), and that they ignore the
siginfo.  I think they could mostly be replaced by an addition to the
kthread API to allow a kthread to be killed by signals for legacy
reasons.


  parent reply	other threads:[~2014-02-14 16:13 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 17:27 3.14-rc2 XFS backtrace because irqs_disabled Dave Jones
2014-02-11 17:27 ` Dave Jones
2014-02-11 21:08 ` Dave Chinner
2014-02-11 21:08   ` Dave Chinner
2014-02-11 21:49   ` Eric Sandeen
2014-02-11 21:49     ` Eric Sandeen
2014-02-12  0:44     ` Dave Jones
2014-02-12  0:44       ` Dave Jones
2014-02-12  1:09       ` Al Viro
2014-02-12  1:09         ` Al Viro
2014-02-12  2:52         ` Linus Torvalds
2014-02-12  2:52           ` Linus Torvalds
2014-02-12  4:03           ` Dave Jones
2014-02-12  4:03             ` Dave Jones
2014-02-12  4:22             ` Al Viro
2014-02-12  4:22               ` Al Viro
2014-02-12  5:40               ` Dave Chinner
2014-02-12  5:40                 ` Dave Chinner
2014-02-12  5:50                 ` Dave Jones
2014-02-12  5:50                   ` Dave Jones
2014-02-12  6:10                   ` Dave Chinner
2014-02-12  6:10                     ` Dave Chinner
2014-02-12  6:31                     ` Dave Chinner
2014-02-12  6:31                       ` Dave Chinner
2014-02-12  6:59                       ` Linus Torvalds
2014-02-12  6:59                         ` Linus Torvalds
2014-02-12  8:13                         ` Tejun Heo
2014-02-12  8:13                           ` Tejun Heo
2014-02-12 12:44                           ` Steven Rostedt
2014-02-12 12:44                             ` Steven Rostedt
2014-02-12  8:35                         ` Dave Chinner
2014-02-12  8:35                           ` Dave Chinner
2014-02-12 12:50                           ` Steven Rostedt
2014-02-12 12:50                             ` Steven Rostedt
2014-02-12 12:40                         ` Steven Rostedt
2014-02-12 12:40                           ` Steven Rostedt
2014-02-12 13:29                           ` Peter Zijlstra
2014-02-12 13:29                             ` Peter Zijlstra
2014-02-12 14:25                     ` Dave Jones
2014-02-12 14:25                       ` Dave Jones
2014-02-12 21:14                       ` Dave Chinner
2014-02-12 21:14                         ` Dave Chinner
2014-02-12 15:57                     ` Eric Sandeen
2014-02-12 15:57                       ` Eric Sandeen
2014-02-12  6:28                 ` Linus Torvalds
2014-02-12  6:28                   ` Linus Torvalds
2014-02-12  7:18                   ` Dave Chinner
2014-02-12  7:18                     ` Dave Chinner
2014-02-14  0:24                     ` Dave Chinner
2014-02-14  0:24                       ` Dave Chinner
2014-02-14 16:01                       ` Dave Jones
2014-02-14 16:01                         ` Dave Jones
2014-02-15 22:23                         ` Dave Chinner
2014-02-15 22:23                           ` Dave Chinner
2014-02-15 22:28                           ` Dave Jones
2014-02-15 22:28                             ` Dave Jones
2014-02-15 22:43                             ` Linus Torvalds
2014-02-15 22:43                               ` Linus Torvalds
2014-02-15 23:50                       ` Linus Torvalds
2014-02-15 23:50                         ` Linus Torvalds
2014-02-15 23:50                         ` Linus Torvalds
2014-02-18  1:27                         ` Dave Chinner
2014-02-18  1:27                           ` Dave Chinner
2014-02-18  1:27                           ` Dave Chinner
2014-02-12 11:39                   ` Al Viro
2014-02-12 11:39                     ` Al Viro
2014-02-12 20:13                     ` Linus Torvalds
2014-02-12 20:13                       ` Linus Torvalds
2014-02-12 21:14                       ` Al Viro
2014-02-12 21:14                         ` Al Viro
2014-02-12 21:32                         ` Linus Torvalds
2014-02-12 21:32                           ` Linus Torvalds
2014-02-12 21:44                           ` Al Viro
2014-02-12 21:44                             ` Al Viro
2014-02-13 20:51                             ` Al Viro
2014-02-13 20:51                               ` Al Viro
2014-02-14  0:09                               ` Al Viro
2014-02-14  0:09                                 ` Al Viro
2014-02-14 13:25                               ` Christoph Hellwig
2014-02-14 13:25                                 ` Christoph Hellwig
2014-02-14 13:29                                 ` Richard Weinberger
2014-02-14 13:29                                   ` Richard Weinberger
2014-02-14 15:20                                   ` Al Viro
2014-02-14 15:20                                     ` Al Viro
2014-02-14 16:08                                     ` Oleg Nesterov
2014-02-14 16:08                                       ` Oleg Nesterov
2014-02-13 17:40                           ` Oleg Nesterov
2014-02-13 17:40                             ` Oleg Nesterov
2014-02-13 17:58                             ` Linus Torvalds
2014-02-13 17:58                               ` Linus Torvalds
2014-02-13 18:10                               ` Oleg Nesterov
2014-02-13 18:10                                 ` Oleg Nesterov
2014-02-13 18:37                                 ` Oleg Nesterov
2014-02-13 18:37                                   ` Oleg Nesterov
2014-02-15  5:25                               ` Al Viro
2014-02-15  5:25                                 ` Al Viro
2014-02-15 14:27                                 ` Oleg Nesterov
2014-02-15 14:27                                   ` Oleg Nesterov
2014-02-15 15:22                                   ` Al Viro
2014-02-15 15:22                                     ` Al Viro
2014-02-15 15:33                                     ` Oleg Nesterov
2014-02-15 15:33                                       ` Oleg Nesterov
2014-02-15 15:36                                     ` Al Viro
2014-02-15 15:36                                       ` Al Viro
2014-02-15 15:58                                       ` Al Viro
2014-02-15 15:58                                         ` Al Viro
2014-02-15 16:59                                         ` Al Viro
2014-02-15 16:59                                           ` Al Viro
2014-02-15 17:43                                         ` Oleg Nesterov
2014-02-15 17:43                                           ` Oleg Nesterov
2014-02-15 18:05                                           ` Al Viro
2014-02-15 18:05                                             ` Al Viro
2014-02-15 18:45                                             ` Oleg Nesterov
2014-02-15 18:45                                               ` Oleg Nesterov
2014-02-17 16:57                                               ` Oleg Nesterov
2014-02-17 16:57                                                 ` Oleg Nesterov
2014-02-17 17:40                                                 ` Al Viro
2014-02-17 17:40                                                   ` Al Viro
2014-02-17 17:46                                                   ` Oleg Nesterov
2014-02-17 17:46                                                     ` Oleg Nesterov
2014-02-17 17:54                                                     ` Al Viro
2014-02-17 17:54                                                       ` Al Viro
2014-02-14 16:13                           ` Christoph Hellwig [this message]
2014-02-14 16:13                             ` Christoph Hellwig
2014-02-14 16:16                             ` Al Viro
2014-02-14 16:16                               ` Al Viro
2014-02-14 16:18                               ` Al Viro
2014-02-14 16:18                                 ` Al Viro
2014-02-14 16:19                               ` Christoph Hellwig
2014-02-14 16:19                                 ` Christoph Hellwig
2014-02-15 14:46                                 ` Oleg Nesterov
2014-02-15 14:46                                   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140214161302.GA16416@infradead.org \
    --to=hch@infradead.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.