Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

On Mar 13, Sergei Shtylyov wrote:
> On 03/13/2014 10:39 PM, Ezequiel Garcia wrote:
> 
> >From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> 
> >The Armada 385-DB board has a NAND flash, so enable it in the
> >devicetree and add the partitions as prepared in the factory images.
> 
> >Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> >---
> >  arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> 
> >diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts
> >index 9a13642..edcf7ff 100644
> >--- a/arch/arm/boot/dts/armada-385-db.dts
> >+++ b/arch/arm/boot/dts/armada-385-db.dts
> >@@ -80,6 +80,27 @@
> >  					reg = <1>;
> >  				};
> >  			};
> >+
> >+			flash: flash@d0000 {
> 
>    Note that you don't have to label your device the same way as it's named,
> i.e. you could have labelled it "nand" if it would make things clearer.

Right.

>    Although I don't readily see the value of labeling nodes in the board's
> .dts file. Do you really expect to refer to it somewhere?
> 

Yeah, I was thinking the same thing just after I sent this. No, I don't think
we need the label.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com