From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mike Turquette <mturquette@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org
Cc: Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Seif Mazareeb <seif@marvell.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB
Date: Thu, 13 Mar 2014 23:53:40 +0300 [thread overview]
Message-ID: <53221AD4.3090002@cogentembedded.com> (raw)
In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar>
On 03/13/2014 10:39 PM, Ezequiel Garcia wrote:
> From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> The Armada 385-DB board has a NAND flash, so enable it in the
> devicetree and add the partitions as prepared in the factory images.
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts
> index 9a13642..edcf7ff 100644
> --- a/arch/arm/boot/dts/armada-385-db.dts
> +++ b/arch/arm/boot/dts/armada-385-db.dts
> @@ -80,6 +80,27 @@
> reg = <1>;
> };
> };
> +
> + flash: flash@d0000 {
Note that you don't have to label your device the same way as it's named,
i.e. you could have labelled it "nand" if it would make things clearer.
Although I don't readily see the value of labeling nodes in the board's
.dts file. Do you really expect to refer to it somewhere?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB
Date: Thu, 13 Mar 2014 23:53:40 +0300 [thread overview]
Message-ID: <53221AD4.3090002@cogentembedded.com> (raw)
In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel@vanguardiasur.com.ar>
On 03/13/2014 10:39 PM, Ezequiel Garcia wrote:
> From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> The Armada 385-DB board has a NAND flash, so enable it in the
> devicetree and add the partitions as prepared in the factory images.
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts
> index 9a13642..edcf7ff 100644
> --- a/arch/arm/boot/dts/armada-385-db.dts
> +++ b/arch/arm/boot/dts/armada-385-db.dts
> @@ -80,6 +80,27 @@
> reg = <1>;
> };
> };
> +
> + flash: flash at d0000 {
Note that you don't have to label your device the same way as it's named,
i.e. you could have labelled it "nand" if it would make things clearer.
Although I don't readily see the value of labeling nodes in the board's
.dts file. Do you really expect to refer to it somewhere?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Ezequiel Garcia
<ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Seif Mazareeb <seif-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB
Date: Thu, 13 Mar 2014 23:53:40 +0300 [thread overview]
Message-ID: <53221AD4.3090002@cogentembedded.com> (raw)
In-Reply-To: <1394739542-30017-6-git-send-email-ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
On 03/13/2014 10:39 PM, Ezequiel Garcia wrote:
> From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> The Armada 385-DB board has a NAND flash, so enable it in the
> devicetree and add the partitions as prepared in the factory images.
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> arch/arm/boot/dts/armada-385-db.dts | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> diff --git a/arch/arm/boot/dts/armada-385-db.dts b/arch/arm/boot/dts/armada-385-db.dts
> index 9a13642..edcf7ff 100644
> --- a/arch/arm/boot/dts/armada-385-db.dts
> +++ b/arch/arm/boot/dts/armada-385-db.dts
> @@ -80,6 +80,27 @@
> reg = <1>;
> };
> };
> +
> + flash: flash@d0000 {
Note that you don't have to label your device the same way as it's named,
i.e. you could have labelled it "nand" if it would make things clearer.
Although I don't readily see the value of labeling nodes in the board's
.dts file. Do you really expect to refer to it somewhere?
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-13 20:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 19:38 [PATCH v2 0/6] Armada 380 NAND support Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 1/6] clk: mvebu: Support Armada 380 SoC on the core divider clock Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 2/6] ARM: mvebu: Add a 2 GHz fixed-clock on Armada 38x SoCs Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 3/6] ARM: mvebu: Add the Core Divider clock to " Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 19:38 ` Ezequiel Garcia
2014-03-13 20:55 ` Sergei Shtylyov
2014-03-13 20:55 ` Sergei Shtylyov
2014-03-13 20:55 ` Sergei Shtylyov
2014-03-13 20:05 ` Ezequiel Garcia
2014-03-13 20:05 ` Ezequiel Garcia
2014-03-13 20:05 ` Ezequiel Garcia
2014-03-13 19:39 ` [PATCH v2 4/6] ARM: mvebu: Add support for NAND controller in Armada 38x SoC Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
2014-03-13 19:39 ` [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
2014-03-13 20:53 ` Sergei Shtylyov [this message]
2014-03-13 20:53 ` Sergei Shtylyov
2014-03-13 20:53 ` Sergei Shtylyov
2014-03-13 20:04 ` Ezequiel Garcia
2014-03-13 20:04 ` Ezequiel Garcia
2014-03-13 20:04 ` Ezequiel Garcia
2014-03-13 19:39 ` [PATCH v2 6/6] clk: mvebu: Update binding documentation for the core divider clock Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
2014-03-13 19:39 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53221AD4.3090002@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=seif@marvell.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.