OMAP4 SDP regression...

OMAP4 SDP regression...

[Russell King - ARM Linux]

There's been a couple of regressions on OMAP4430 SDP I've only recently
noticed:

http://www.arm.linux.org.uk/developer/build/result.php?type=boot&idx=1597

Configuring network interfaces... udhcpc (v1.9.1) started
Sending discover...
Sending discover...
Sending discover...
No lease, failing
done.

No link lights come up either.  The hardware is fine because uboot manages
to successfully tftp the kernel.

It looks like it was working in -rc4+armsoc and -rc5+armsoc, but not
-rc6+armsoc.

>From what I can see, nothing has changed in drivers/net/ethernet/micrel/
since rc5.

I've been through the delta from 3.14-rc5, and I don't see anything
obvious.  Any ideas?  Known problem?

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

Re: OMAP4 SDP regression...

[Tony Lindgren]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [140317 16:35]:
> There's been a couple of regressions on OMAP4430 SDP I've only recently
> noticed:
> 
> http://www.arm.linux.org.uk/developer/build/result.php?type=boot&idx=1597
> 
> Configuring network interfaces... udhcpc (v1.9.1) started
> Sending discover...
> Sending discover...
> Sending discover...
> No lease, failing
> done.
> 
> No link lights come up either.  The hardware is fine because uboot manages
> to successfully tftp the kernel.
> 
> It looks like it was working in -rc4+armsoc and -rc5+armsoc, but not
> -rc6+armsoc.
> 
> From what I can see, nothing has changed in drivers/net/ethernet/micrel/
> since rc5.
> 
> I've been through the delta from 3.14-rc5, and I don't see anything
> obvious.  Any ideas?  Known problem?

Seems like plain v3.14-rc6 fails for me while -rc5 works. Bisecting
points to:

66fda75f regulator: core: Replace direct ops->disable usage

Also verified that v3.14-rc6 with 66fda75f reverted also works.

Markus & Mark, any ideas?

Regards,

Tony

Re: OMAP4 SDP regression...

[Markus Pargmann]

[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]

Hi,

On Mon, Mar 17, 2014 at 06:35:07PM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [140317 16:35]:
> > There's been a couple of regressions on OMAP4430 SDP I've only recently
> > noticed:
> > 
> > http://www.arm.linux.org.uk/developer/build/result.php?type=boot&idx=1597
> > 
> > Configuring network interfaces... udhcpc (v1.9.1) started
> > Sending discover...
> > Sending discover...
> > Sending discover...
> > No lease, failing
> > done.
> > 
> > No link lights come up either.  The hardware is fine because uboot manages
> > to successfully tftp the kernel.
> > 
> > It looks like it was working in -rc4+armsoc and -rc5+armsoc, but not
> > -rc6+armsoc.
> > 
> > From what I can see, nothing has changed in drivers/net/ethernet/micrel/
> > since rc5.
> > 
> > I've been through the delta from 3.14-rc5, and I don't see anything
> > obvious.  Any ideas?  Known problem?
> 
> Seems like plain v3.14-rc6 fails for me while -rc5 works. Bisecting
> points to:
> 
> 66fda75f regulator: core: Replace direct ops->disable usage
> 
> Also verified that v3.14-rc6 with 66fda75f reverted also works.
> 
> Markus & Mark, any ideas?

I just had a look into the specific dts 'omap4-sdp.dts'. It defines a
'vdd_eth' at the top of the file, which is a fixed regulator using gpios
with 'regulator-boot-on'. This regulator is also passed to the ks8851
driver as vdd-supply. But this supply is not used in the driver.

The problem may be that the fixed regulator was never enabled/disabled
before my patch. As the network driver does not enable the regulator
manually, it will be disabled by the regulator framework. A
'regulator-always-on' may help here.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]